Patch Detail
Show a patch.
GET /api/1.1/patches/17771/?format=api
{ "id": 17771, "url": "https://patchwork.libcamera.org/api/1.1/patches/17771/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17771/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221110144556.7858-7-david.plowman@raspberrypi.com>", "date": "2022-11-10T14:45:56", "name": "[libcamera-devel,6/6] libcamera: pipeline: rkisp1: Set device's flip controls correctly", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "a50d4a2e4db3acdf12e49940c2afeeb063735628", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17771/mbox/", "series": [ { "id": 3602, "url": "https://patchwork.libcamera.org/api/1.1/series/3602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3602", "date": "2022-11-10T14:45:50", "name": "Resolve invalid attempts to set sensor flip controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17771/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17771/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BC4A0C3285\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Nov 2022 14:46:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5F58B63094;\n\tThu, 10 Nov 2022 15:46:12 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF8F76308E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Nov 2022 15:46:08 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id a14so2583040wru.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Nov 2022 06:46:08 -0800 (PST)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tu24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Nov 2022 06:46:07 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668091572;\n\tbh=e014DPz7b+gu0htAFFlrLVkAeoe1Cr35f4gHPj5FQA4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=CtsY5AQ9KPyY4zOo9BO6UjZAdWXMr4FyrniyfdQ1z64EKWVS6yq9JFD6ctzx4wHbm\n\tC077XsznQuqG8+Nqe3yXfSTDEuUCxbRN1khvpnYVoouD8gCFptmyrEESG9CgQGaZxQ\n\t7eiy+HX0x5OhDhc4L7ieNY5qn8cRE2ZnSDgdZ7Xhz9ReIclog2dapfXliwHy2ElzY4\n\tc76RNYrPSnvq6G/vVPaC/lfY+PiULYr0QCw8xDeBdjreofy9C7Ifw3z4HZrzsXkTzi\n\tHnPjBj0FrGWdHaZcq/5RrZvh8QQYlOA4KH05Ni9O9BnXtSwlYeS7OwYN+TcUi1u7fG\n\tf2DJSB9U+42Kw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0Nfmi/nEOx3ooNie+tWuNhTkC5Tqi83bho3W9L7OElg=;\n\tb=enilVswcQWriDcReCuw6UbePBQuSxnyGVRxuB0z20UbPSrrOTIZ0lxFGhjAT0pGff2\n\t1rcVbUdI4k7JSi8NG95bdnNnotibNYbVc2kGyOYNTBeuPta/xGRfhUBaRMfHuRVWWouk\n\t71mZuvJ5wt8IEYVJS5UCbHYo3RBbTY5kYp0wPo/RV3P2xt89+Jz0IcMg29TnL07/ViWm\n\tWG/Hywh9EnWPsPOTAyryk3LZntxNon901lPJsSTdKHPUIWOyaP3HHQ7w5IFUxYFP3j/O\n\t4Nv3wWQ+vmqFJOl+0MwXL25L7FE9Y880DN7NK34vsiB2XyY0zTn+7/gTQa7w7cntWp9G\n\tYbvA==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"enilVswc\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=0Nfmi/nEOx3ooNie+tWuNhTkC5Tqi83bho3W9L7OElg=;\n\tb=yadRydw7C8tbBYd/EYow3yQUEEzl47QjWbQLu3rq2w4KY73JY12Ge4RVmr5x3O4ZKI\n\tEbP5ZkMsmvxUQIZYfV1nng7+/KoeeMOkso4OLtDnRpm5r5mb8Zc6yGiunuOIe/ZbVTZV\n\twIINoVR11rW/rlE8ZUxw/NwQm6RYyQ+YT8VKmsHSFezqT+/8sGbH6hnBQeogjDYifx/w\n\t+o2ktD1AH5HnfAO0B0t4zr6O4uy15iojXl4hC702o8nA28KgambZKiNvxLD1ukBAm+dX\n\tmnianUDePZn6/k3nF319/xGemDb2w7l7WBPdFM/OVH8CVkFZr1lEjjG5MzadgiSmUtgz\n\tANXA==", "X-Gm-Message-State": "ACrzQf2PqTyxd4XtJAi3/6jrrS+4HIwLSFUmATov9jTzbHLG8JDKNzCj\n\t+zdNP0vqKcWLvOESjAMFkYliDy0WsLSDCg==", "X-Google-Smtp-Source": "AMsMyM7NJO8Z88OfZnH1mh890ZEG9/onvog2zCUzNwKycj63xO8F672cgf/c7VtqWTAJ4r3BcXTnVQ==", "X-Received": "by 2002:a5d:434b:0:b0:236:c7c2:f7fc with SMTP id\n\tu11-20020a5d434b000000b00236c7c2f7fcmr37764706wrr.685.1668091568202; \n\tThu, 10 Nov 2022 06:46:08 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 10 Nov 2022 14:45:56 +0000", "Message-Id": "<20221110144556.7858-7-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221110144556.7858-1-david.plowman@raspberrypi.com>", "References": "<20221110144556.7858-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 6/6] libcamera: pipeline: rkisp1: Set\n\tdevice's flip controls correctly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the horizontal and vertical flip controls correctly by\ncalling the device's setTransform method now that this no longer\nhappens in CameraSensor::init().\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 3d3a7086..f144fabd 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret)\n \t\treturn ret;\n \n+\t/* Set up the device's horizontal and vertical flips. */\n+\tsensor->device()->setTransform(c->transform);\n+\n \t/*\n \t * Configure the format on the sensor output and propagate it through\n \t * the pipeline.\n", "prefixes": [ "libcamera-devel", "6/6" ] }