From patchwork Thu Nov 10 14:45:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17771 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BC4A0C3285 for ; Thu, 10 Nov 2022 14:46:12 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 5F58B63094; Thu, 10 Nov 2022 15:46:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668091572; bh=e014DPz7b+gu0htAFFlrLVkAeoe1Cr35f4gHPj5FQA4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CtsY5AQ9KPyY4zOo9BO6UjZAdWXMr4FyrniyfdQ1z64EKWVS6yq9JFD6ctzx4wHbm C077XsznQuqG8+Nqe3yXfSTDEuUCxbRN1khvpnYVoouD8gCFptmyrEESG9CgQGaZxQ 7eiy+HX0x5OhDhc4L7ieNY5qn8cRE2ZnSDgdZ7Xhz9ReIclog2dapfXliwHy2ElzY4 c76RNYrPSnvq6G/vVPaC/lfY+PiULYr0QCw8xDeBdjreofy9C7Ifw3z4HZrzsXkTzi HnPjBj0FrGWdHaZcq/5RrZvh8QQYlOA4KH05Ni9O9BnXtSwlYeS7OwYN+TcUi1u7fG f2DJSB9U+42Kw== Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id DF8F76308E for ; Thu, 10 Nov 2022 15:46:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="enilVswc"; dkim-atps=neutral Received: by mail-wr1-x432.google.com with SMTP id a14so2583040wru.5 for ; Thu, 10 Nov 2022 06:46:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Nfmi/nEOx3ooNie+tWuNhTkC5Tqi83bho3W9L7OElg=; b=enilVswcQWriDcReCuw6UbePBQuSxnyGVRxuB0z20UbPSrrOTIZ0lxFGhjAT0pGff2 1rcVbUdI4k7JSi8NG95bdnNnotibNYbVc2kGyOYNTBeuPta/xGRfhUBaRMfHuRVWWouk 71mZuvJ5wt8IEYVJS5UCbHYo3RBbTY5kYp0wPo/RV3P2xt89+Jz0IcMg29TnL07/ViWm WG/Hywh9EnWPsPOTAyryk3LZntxNon901lPJsSTdKHPUIWOyaP3HHQ7w5IFUxYFP3j/O 4Nv3wWQ+vmqFJOl+0MwXL25L7FE9Y880DN7NK34vsiB2XyY0zTn+7/gTQa7w7cntWp9G YbvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Nfmi/nEOx3ooNie+tWuNhTkC5Tqi83bho3W9L7OElg=; b=yadRydw7C8tbBYd/EYow3yQUEEzl47QjWbQLu3rq2w4KY73JY12Ge4RVmr5x3O4ZKI EbP5ZkMsmvxUQIZYfV1nng7+/KoeeMOkso4OLtDnRpm5r5mb8Zc6yGiunuOIe/ZbVTZV wIINoVR11rW/rlE8ZUxw/NwQm6RYyQ+YT8VKmsHSFezqT+/8sGbH6hnBQeogjDYifx/w +o2ktD1AH5HnfAO0B0t4zr6O4uy15iojXl4hC702o8nA28KgambZKiNvxLD1ukBAm+dX mnianUDePZn6/k3nF319/xGemDb2w7l7WBPdFM/OVH8CVkFZr1lEjjG5MzadgiSmUtgz ANXA== X-Gm-Message-State: ACrzQf2PqTyxd4XtJAi3/6jrrS+4HIwLSFUmATov9jTzbHLG8JDKNzCj +zdNP0vqKcWLvOESjAMFkYliDy0WsLSDCg== X-Google-Smtp-Source: AMsMyM7NJO8Z88OfZnH1mh890ZEG9/onvog2zCUzNwKycj63xO8F672cgf/c7VtqWTAJ4r3BcXTnVQ== X-Received: by 2002:a5d:434b:0:b0:236:c7c2:f7fc with SMTP id u11-20020a5d434b000000b00236c7c2f7fcmr37764706wrr.685.1668091568202; Thu, 10 Nov 2022 06:46:08 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id u24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:46:07 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 10 Nov 2022 14:45:56 +0000 Message-Id: <20221110144556.7858-7-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110144556.7858-1-david.plowman@raspberrypi.com> References: <20221110144556.7858-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 6/6] libcamera: pipeline: rkisp1: Set device's flip controls correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the horizontal and vertical flip controls correctly by calling the device's setTransform method now that this no longer happens in CameraSensor::init(). Signed-off-by: David Plowman --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 3d3a7086..f144fabd 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -632,6 +632,9 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c) if (ret) return ret; + /* Set up the device's horizontal and vertical flips. */ + sensor->device()->setTransform(c->transform); + /* * Configure the format on the sensor output and propagate it through * the pipeline.