Patch Detail
Show a patch.
GET /api/1.1/patches/17770/?format=api
{ "id": 17770, "url": "https://patchwork.libcamera.org/api/1.1/patches/17770/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17770/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221110144556.7858-6-david.plowman@raspberrypi.com>", "date": "2022-11-10T14:45:55", "name": "[libcamera-devel,5/6] libcamera: pipeline: simple: Set device's flip controls correctly", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2e4894768a2a96c65c49ef5e7c71f8a3cbd86bb7", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17770/mbox/", "series": [ { "id": 3602, "url": "https://patchwork.libcamera.org/api/1.1/series/3602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3602", "date": "2022-11-10T14:45:50", "name": "Resolve invalid attempts to set sensor flip controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17770/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17770/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABDA9BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 10 Nov 2022 14:46:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 345D463092;\n\tThu, 10 Nov 2022 15:46:10 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04BDD63087\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Nov 2022 15:46:08 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id a14so2582976wru.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 10 Nov 2022 06:46:08 -0800 (PST)", "from pi4-davidp.pitowers.org\n\t([2a00:1098:3142:14:e4a2:3070:eea4:e434])\n\tby smtp.gmail.com with ESMTPSA id\n\tu24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 10 Nov 2022 06:46:06 -0800 (PST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1668091570;\n\tbh=zWRYYLYyqkOrcUocBsRP/3O4I7Cm39CYCiABM+o6Pq4=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jzlEqyy5BnaE1ssuurCHIEwrQLbK2Nm83l4NkEZmTtFY0IV5C9D/e+IYCdTlKOmVf\n\tsJLDMJNBKhmRJuGPPGYIg33LPtiyU+tUjYrnj6q9xPNnN7F0hdKS6okfNa4Sz91aCv\n\t263S/z4W9yttYl3rWL0AGlYTuedzPk6wI6hqOpAoVL76vPTszxEft+CgyiUbvUALf9\n\trGSyJRP0X1iALi/JjI8bNiml/w3+k/+s72xPU4NWjRYq3huDtDcJxDYym/iJr1D5Aq\n\tuyloTx38gYhPhy0bD5LIuec+G9zznG7HB/Vh0ibbj15H6Puv8FynDQmjbnVdTclQCA\n\tyy7vGkJ/zSv2A==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5CHKPCI01VxfTyHQ2vD5oSpDPSjSR2dmaNqS2b4P9oQ=;\n\tb=Y5Ew5RwbsFuh1nbumC2JmL8tM3gbRXirtEirBXq/K/BrA0CSbU1ZIEPqPEk7FSPKzH\n\tFp66cSQ1VymKWsBzoSMQhwk14FjHcf67cvyOnqKyBuYm6hZj0jUcsHX+bVlAhxmt0Xc4\n\tUHaQ4vvq5uxXJvMRaV/xwPpzmH6Pa0FG0PtRm1Xhzmxg7l7mLeH9w47nf5GsJE9XaIp2\n\tc3OHYJIZ4sWOBNDuvtvzSfYCgRT9f5P8lp1PDeF9PAvXAspXLBGSJ0QzRD38DxwMG1Qi\n\tvkuUROvSaa8P/WJicHcs9gghQCqHfVRtcMAbLdwdUZMDp9TyUUDX2IJd7jzgt5f8bZJI\n\t9gUQ==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected) header.d=raspberrypi.com\n\theader.i=@raspberrypi.com\n\theader.b=\"Y5Ew5Rwb\"; dkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=5CHKPCI01VxfTyHQ2vD5oSpDPSjSR2dmaNqS2b4P9oQ=;\n\tb=WZmXyUcoJXyzc4ZpDsCukduJ5POkEqzvU1/BgpnneEyVSopTV64RRu9wANXkAbkjQH\n\tioetjaSIw+U3FuJqVmv/2JzZuBYnC7D/6whgxE3L6XX8E2TA9gkWq842Fg2vsaaXSFBx\n\t4tFq8ay9D6SPNj3vjuzgAYdNlBoaMAn23xIN0NZ8DjXS1SEqL25tiP5ERJuDikHzLeSZ\n\tE3zbVy3qGYpM+f7wM3QB8Kfrmnh6Wm8q8Sg/Kn28pxTNORu1/bDfReGDY7KlZn6SL8+h\n\tGnwM1mONjjDTJj0kIjJ+Yv3cMdyuVT9YNYuMoNjuJB7fcCajyiWY/5GpFnyg8R+7gHQV\n\t5ULQ==", "X-Gm-Message-State": "ACrzQf0U4FEXb2LoRuj8ai0UlgYiL/EfKV17B5UsgqCxAtxUQqGSg+Mw\n\tnyEyb/LzXYf5AebYEJCxSvZaKdeePHdcNw==", "X-Google-Smtp-Source": "AMsMyM4Xjg8p/Hj53VmmZ/d4jdMlTPfR1qFf6J60Yjs48hretzQn/ZO6FSYupQjorE1YDEmluc5ubA==", "X-Received": "by 2002:adf:f84c:0:b0:236:6e52:504 with SMTP id\n\td12-20020adff84c000000b002366e520504mr40182904wrq.564.1668091567061; \n\tThu, 10 Nov 2022 06:46:07 -0800 (PST)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 10 Nov 2022 14:45:55 +0000", "Message-Id": "<20221110144556.7858-6-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20221110144556.7858-1-david.plowman@raspberrypi.com>", "References": "<20221110144556.7858-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 5/6] libcamera: pipeline: simple: Set\n\tdevice's flip controls correctly", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "David Plowman via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "David Plowman <david.plowman@raspberrypi.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Set the horizontal and vertical flip controls correctly by\ncalling the device's setTransform method now that this no longer\nhappens in CameraSensor::init().\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 3 +++\n 1 file changed, 3 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a32de7f3..f25a8cc1 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1120,6 +1120,9 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)\n \tif (ret < 0)\n \t\treturn ret;\n \n+\t/* Set up the video device's horizontal and vertical flips. */\n+\tvideo->setTransform(c->transform);\n+\n \t/* Configure the video node. */\n \tV4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig->captureFormat);\n \n", "prefixes": [ "libcamera-devel", "5/6" ] }