From patchwork Thu Nov 10 14:45:55 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 17770 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id ABDA9BE08B for ; Thu, 10 Nov 2022 14:46:10 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 345D463092; Thu, 10 Nov 2022 15:46:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1668091570; bh=zWRYYLYyqkOrcUocBsRP/3O4I7Cm39CYCiABM+o6Pq4=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jzlEqyy5BnaE1ssuurCHIEwrQLbK2Nm83l4NkEZmTtFY0IV5C9D/e+IYCdTlKOmVf sJLDMJNBKhmRJuGPPGYIg33LPtiyU+tUjYrnj6q9xPNnN7F0hdKS6okfNa4Sz91aCv 263S/z4W9yttYl3rWL0AGlYTuedzPk6wI6hqOpAoVL76vPTszxEft+CgyiUbvUALf9 rGSyJRP0X1iALi/JjI8bNiml/w3+k/+s72xPU4NWjRYq3huDtDcJxDYym/iJr1D5Aq uyloTx38gYhPhy0bD5LIuec+G9zznG7HB/Vh0ibbj15H6Puv8FynDQmjbnVdTclQCA yy7vGkJ/zSv2A== Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 04BDD63087 for ; Thu, 10 Nov 2022 15:46:08 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="Y5Ew5Rwb"; dkim-atps=neutral Received: by mail-wr1-x432.google.com with SMTP id a14so2582976wru.5 for ; Thu, 10 Nov 2022 06:46:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5CHKPCI01VxfTyHQ2vD5oSpDPSjSR2dmaNqS2b4P9oQ=; b=Y5Ew5RwbsFuh1nbumC2JmL8tM3gbRXirtEirBXq/K/BrA0CSbU1ZIEPqPEk7FSPKzH Fp66cSQ1VymKWsBzoSMQhwk14FjHcf67cvyOnqKyBuYm6hZj0jUcsHX+bVlAhxmt0Xc4 UHaQ4vvq5uxXJvMRaV/xwPpzmH6Pa0FG0PtRm1Xhzmxg7l7mLeH9w47nf5GsJE9XaIp2 c3OHYJIZ4sWOBNDuvtvzSfYCgRT9f5P8lp1PDeF9PAvXAspXLBGSJ0QzRD38DxwMG1Qi vkuUROvSaa8P/WJicHcs9gghQCqHfVRtcMAbLdwdUZMDp9TyUUDX2IJd7jzgt5f8bZJI 9gUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CHKPCI01VxfTyHQ2vD5oSpDPSjSR2dmaNqS2b4P9oQ=; b=WZmXyUcoJXyzc4ZpDsCukduJ5POkEqzvU1/BgpnneEyVSopTV64RRu9wANXkAbkjQH ioetjaSIw+U3FuJqVmv/2JzZuBYnC7D/6whgxE3L6XX8E2TA9gkWq842Fg2vsaaXSFBx 4tFq8ay9D6SPNj3vjuzgAYdNlBoaMAn23xIN0NZ8DjXS1SEqL25tiP5ERJuDikHzLeSZ E3zbVy3qGYpM+f7wM3QB8Kfrmnh6Wm8q8Sg/Kn28pxTNORu1/bDfReGDY7KlZn6SL8+h GnwM1mONjjDTJj0kIjJ+Yv3cMdyuVT9YNYuMoNjuJB7fcCajyiWY/5GpFnyg8R+7gHQV 5ULQ== X-Gm-Message-State: ACrzQf0U4FEXb2LoRuj8ai0UlgYiL/EfKV17B5UsgqCxAtxUQqGSg+Mw nyEyb/LzXYf5AebYEJCxSvZaKdeePHdcNw== X-Google-Smtp-Source: AMsMyM4Xjg8p/Hj53VmmZ/d4jdMlTPfR1qFf6J60Yjs48hretzQn/ZO6FSYupQjorE1YDEmluc5ubA== X-Received: by 2002:adf:f84c:0:b0:236:6e52:504 with SMTP id d12-20020adff84c000000b002366e520504mr40182904wrq.564.1668091567061; Thu, 10 Nov 2022 06:46:07 -0800 (PST) Received: from pi4-davidp.pitowers.org ([2a00:1098:3142:14:e4a2:3070:eea4:e434]) by smtp.gmail.com with ESMTPSA id u24-20020a7bc058000000b003b476cabf1csm5249759wmc.26.2022.11.10.06.46.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 06:46:06 -0800 (PST) To: libcamera-devel@lists.libcamera.org Date: Thu, 10 Nov 2022 14:45:55 +0000 Message-Id: <20221110144556.7858-6-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221110144556.7858-1-david.plowman@raspberrypi.com> References: <20221110144556.7858-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 5/6] libcamera: pipeline: simple: Set device's flip controls correctly X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Plowman via libcamera-devel From: David Plowman Reply-To: David Plowman Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Set the horizontal and vertical flip controls correctly by calling the device's setTransform method now that this no longer happens in CameraSensor::init(). Signed-off-by: David Plowman --- src/libcamera/pipeline/simple/simple.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index a32de7f3..f25a8cc1 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1120,6 +1120,9 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c) if (ret < 0) return ret; + /* Set up the video device's horizontal and vertical flips. */ + video->setTransform(c->transform); + /* Configure the video node. */ V4L2PixelFormat videoFormat = video->toV4L2PixelFormat(pipeConfig->captureFormat);