Patch Detail
Show a patch.
GET /api/1.1/patches/17729/?format=api
{ "id": 17729, "url": "https://patchwork.libcamera.org/api/1.1/patches/17729/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17729/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221030162755.6347-1-laurent.pinchart@ideasonboard.com>", "date": "2022-10-30T16:27:55", "name": "[libcamera-devel] libcamera: Add todo comment in meson.build about switch to dependency('dl')", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "9b463ce76dd1474eb5c846b57836c1938f1c3250", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17729/mbox/", "series": [ { "id": 3588, "url": "https://patchwork.libcamera.org/api/1.1/series/3588/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3588", "date": "2022-10-30T16:27:55", "name": "[libcamera-devel] libcamera: Add todo comment in meson.build about switch to dependency('dl')", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3588/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17729/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17729/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9666BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSun, 30 Oct 2022 16:28:20 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E5E76301C;\n\tSun, 30 Oct 2022 17:28:20 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6152961F47\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 30 Oct 2022 17:28:19 +0100 (CET)", "from pendragon.ideasonboard.com (85-76-73-45-nat.elisa-mobile.fi\n\t[85.76.73.45])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 90D9F706\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 30 Oct 2022 17:28:18 +0100 (CET)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1667147300;\n\tbh=ih+AFBPWWxRHsJHSFmOf6mFU4wYjVfxXa0z1ibg/278=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=z5KPk/OrlnYHMLt9dU2UbmHSd21NEIToCGl5TvEE8fba2pcWW2o9MhQ5GAu04mgVO\n\t3PlKvcUrjobcxX1cEHJFn9GZjIv+Y+w23EkHFIYuLy++LszokStEy3wQlziz4nx5QT\n\tkW1j3RbpFUVw1L2Z2TJvDtSBYaCT1F/efHwLRgDg8spkKjXTkr3O+AwxzP6NsVLgq+\n\tmk+a8AI8oRuosyMe3sU80m1Cn9Lzpe6bqycPtmyFEHdl/8z14ZMOW+FLFOjcKAey+Y\n\toGWILLUC7G88oIwgXs/hnf08i825BZR5hEG+DpXjeGMjcNWnRF6Rt5eD+A4bLzO52Y\n\tv6w6XiFby+QTw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1667147299;\n\tbh=ih+AFBPWWxRHsJHSFmOf6mFU4wYjVfxXa0z1ibg/278=;\n\th=From:To:Subject:Date:From;\n\tb=uYPjLb/cfowFJXI/UkLo+1U5WTzqGmSg78Byk7h7HUbQjW8XynE7nlZl1HXdPFEVv\n\thlqrzpn3DkVao1RjnaOA0aDWbgx8aMJNb53LtRyp3ueUCJoRQ/rcBWiANs+Er9PRyj\n\tlUJUUFllDQ7qLC0stz9zP1/NTUifTgaqo/+/Beys=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"uYPjLb/c\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sun, 30 Oct 2022 18:27:55 +0200", "Message-Id": "<20221030162755.6347-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.37.4", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] libcamera: Add todo comment in\n\tmeson.build about switch to dependency('dl')", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The dlopen() & co. functions are provided by libdl on some systems, and\nbut the C library on others. Starting from version 0.62.0, meson handles\nthis behind the scenes when using dependency('dl'). Add a todo comment\nto remember we should replace the manual implementation with a\ndependency() call when updating to meson 0.62.0.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/meson.build | 1 +\n 1 file changed, 1 insertion(+)\n\n\nbase-commit: 2f0987d1dbd4a1529a701720c11d693a4fcdef3e", "diff": "diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\nindex 0494e808f7d0..65b0ed047b48 100644\n--- a/src/libcamera/meson.build\n+++ b/src/libcamera/meson.build\n@@ -67,6 +67,7 @@ subdir('proxy')\n \n null_dep = dependency('', required : false)\n \n+# TODO: Use dependency('dl') when updating to meson 0.62.0.\n libdl = null_dep\n if not cc.has_function('dlopen')\n libdl = cc.find_library('dl')\n", "prefixes": [ "libcamera-devel" ] }