[libcamera-devel] libcamera: Add todo comment in meson.build about switch to dependency('dl')
diff mbox series

Message ID 20221030162755.6347-1-laurent.pinchart@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel] libcamera: Add todo comment in meson.build about switch to dependency('dl')
Related show

Commit Message

Laurent Pinchart Oct. 30, 2022, 4:27 p.m. UTC 
The dlopen() & co. functions are provided by libdl on some systems, and
but the C library on others. Starting from version 0.62.0, meson handles
this behind the scenes when using dependency('dl'). Add a todo comment
to remember we should replace the manual implementation with a
dependency() call when updating to meson 0.62.0.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 src/libcamera/meson.build | 1 +
 1 file changed, 1 insertion(+)


base-commit: 2f0987d1dbd4a1529a701720c11d693a4fcdef3e

Comments

Kieran Bingham Oct. 31, 2022, 12:08 a.m. UTC | #1 
Quoting Laurent Pinchart via libcamera-devel (2022-10-30 16:27:55)
> The dlopen() & co. functions are provided by libdl on some systems, and
> but the C library on others. Starting from version 0.62.0, meson handles
> this behind the scenes when using dependency('dl'). Add a todo comment
> to remember we should replace the manual implementation with a
> dependency() call when updating to meson 0.62.0.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>  src/libcamera/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 0494e808f7d0..65b0ed047b48 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -67,6 +67,7 @@ subdir('proxy')
>  
>  null_dep = dependency('', required : false)
>  
> +# TODO: Use dependency('dl') when updating to meson 0.62.0.

That's very predictive that we will only update /to/ 0.62.0 next, and
not beyond ... ;-)

I guess it depends on what makes it into the next LTS/stable releases on
the distros?

But either way,

Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


>  libdl = null_dep
>  if not cc.has_function('dlopen')
>      libdl = cc.find_library('dl')
> 
> base-commit: 2f0987d1dbd4a1529a701720c11d693a4fcdef3e
> -- 
> Regards,
> 
> Laurent Pinchart
>

Patch
diff mbox series 

diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
index 0494e808f7d0..65b0ed047b48 100644
--- a/src/libcamera/meson.build
+++ b/src/libcamera/meson.build
@@ -67,6 +67,7 @@  subdir('proxy')
 
 null_dep = dependency('', required : false)
 
+# TODO: Use dependency('dl') when updating to meson 0.62.0.
 libdl = null_dep
 if not cc.has_function('dlopen')
     libdl = cc.find_library('dl')