Patch Detail
Show a patch.
GET /api/1.1/patches/17679/?format=api
{ "id": 17679, "url": "https://patchwork.libcamera.org/api/1.1/patches/17679/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17679/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221024055543.116040-5-nicholas@rothemail.net>", "date": "2022-10-24T05:55:36", "name": "[libcamera-devel,04/11] Adds metadata for the ov8858, which the PinePhone Pro uses.", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "09333163d133614ea44640b01d6a2da2aab26f28", "submitter": { "id": 97, "url": "https://patchwork.libcamera.org/api/1.1/people/97/?format=api", "name": "Nicolas Dufresne via libcamera-devel", "email": "libcamera-devel@lists.libcamera.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17679/mbox/", "series": [ { "id": 3575, "url": "https://patchwork.libcamera.org/api/1.1/series/3575/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3575", "date": "2022-10-24T05:55:33", "name": "[libcamera-devel,01/11] Fixes Bug 156, which breaks libcamera on Android < 12.", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3575/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17679/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17679/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BAD7BD16B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 24 Oct 2022 05:55:58 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DF3A262EFB;\n\tMon, 24 Oct 2022 07:55:57 +0200 (CEST)", "from mail-ot1-x334.google.com (mail-ot1-x334.google.com\n\t[IPv6:2607:f8b0:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 54F3362EF6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 24 Oct 2022 07:55:56 +0200 (CEST)", "by mail-ot1-x334.google.com with SMTP id\n\tw6-20020a056830110600b00665bf86f012so207720otq.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSun, 23 Oct 2022 22:55:56 -0700 (PDT)", "from nroth-pc.attlocal.net\n\t([2600:1700:20:20c0:7bc3:aed3:676f:10a0])\n\tby smtp.gmail.com with ESMTPSA id\n\tx15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tSun, 23 Oct 2022 22:55:54 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1666590958;\n\tbh=ktXcytuB3Jdh41eKmKNNYbYKnPgRWZSaWHPJNGA5AiA=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=pH997UAoDmBwOYfAQpodKD+g8EIHZwj1jlv7pGNJAK1iDbYekKQfjuK7N4tTwm4ym\n\t2SKSBErSlUF7v7nkHQpsty/2usu1hOSHUN7ZF8sK3i0Cxg93E6JTtni2zUH0xXGxRV\n\tvxZ+rvx44dfz3HSpKb3V+ls1a04E3puQ6LE+SAarjHWcuxIWXVxK6kQfXzqueUfHCH\n\t6/I89PAPSwiUM2HtsHe0vs3EDS4GDmapsDS1YEZzei76r1+rY22yrFf/5S3IQaducv\n\tBCBbGhwGOPKfnt4ngbK8v6t+P9We3CtXFR+YOmBL0O6R21/tdMQZSA7s0Z6hUcj5kI\n\tsXS2tiAxGwHhw==", "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=rothemail-net.20210112.gappssmtp.com; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=bOAoyEBkd5by/xGJCiHnwCn4ZxsEtwV5enJoK+EaJao=;\n\tb=Hr6u9crWYInpzQuVXUBYxGyHSUWw4oDdiaD5AWFZ78N0SloShaeSoV7OrdOLbk4nWa\n\tqqt90uoSLNBBzjUWvnoU0FXzEgge3KdDefig5i0onW6WF7estJSFKvEZhAJja5L02xvU\n\t8EHXk86vUZkvIu+2x0bwcEThAurNmf/dauCUUJcuAKNTvzMcMalOBinGDhtimYZT6r1u\n\t4l1tpb7eXhSUka7c4fK1WeRTa9zGJ4d2ZrZ9uyunEptwwA1mYjiB8O9eP64osjk9GD6v\n\t7Q9PFZB1iwG/KwNsPA72qG3tgJ/zZOVqs2z02LMNRjAZ79P+q8uZrVs1s+XVkMp/fX/q\n\tYyEg==" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key; \n\tunprotected)\n\theader.d=rothemail-net.20210112.gappssmtp.com\n\theader.i=@rothemail-net.20210112.gappssmtp.com header.b=\"Hr6u9crW\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=content-transfer-encoding:mime-version:reply-to:references\n\t:in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=bOAoyEBkd5by/xGJCiHnwCn4ZxsEtwV5enJoK+EaJao=;\n\tb=iNMMsZP5HwacO7lg/qSmwEDzO1MIJt1BlZbyQvxYnCN/5kpDah230/vn4bVJWJhCXR\n\tnfi+hbNG2u/rGnfILoLj9qemZohoMAk1Ikm1lSNqRio8jrMbFpFpghydXMCh0Pk4YIwV\n\tSGJw3Bh2mYFhhPvUzMStjU3hEwwembl3dJSMEHGSlrD1fcZsRlUg0HzmvGFiw007H8yu\n\t8xXYKLBwO3tiCfii/VXBIQaRDzR9HnvDc4DUirAIsSTUjuGIlqdvQWBzxdwMJc4YPiUK\n\tKJ7S/zhOyoehFSknINdFxy2PM//XcA6pieY7Xz0i4SxlnpVhNpFyWkyWEnEdA8HmpLog\n\tGo8g==", "X-Gm-Message-State": "ACrzQf3IlDfuXYpbedCLdBLUG+CYDq5QhY4/mj51uAOJsveU/PFvJRad\n\tl0jL1oNqhPhARxyTVWLc9R+PJp4Wh9HhlXfm", "X-Google-Smtp-Source": "AMsMyM4O0JtZVubEnjIOmgu8hHfmimDPsknjX6F6sLfnc728XKeOv75E3WF4RPaEtMCoNYk+MSJbnQ==", "X-Received": "by 2002:a05:6830:6083:b0:660:d54e:583 with SMTP id\n\tby3-20020a056830608300b00660d54e0583mr15583735otb.282.1666590954833; \n\tSun, 23 Oct 2022 22:55:54 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 24 Oct 2022 00:55:36 -0500", "Message-Id": "<20221024055543.116040-5-nicholas@rothemail.net>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20221024055543.116040-1-nicholas@rothemail.net>", "References": "<20221024055543.116040-1-nicholas@rothemail.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 04/11] Adds metadata for the ov8858,\n\twhich the PinePhone Pro uses.", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Nicholas Roth via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "libcamera-devel@lists.libcamera.org", "Cc": "nicholas@rothemail.net", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Nicholas Roth <nicholas@rothemail.net>\n\n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++\n 2 files changed, 25 insertions(+)", "diff": "diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex 35056bec..1d9a45a7 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -476,6 +476,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"ov5693\", CameraSensorHelperOv5693)\n \n+class CameraSensorHelperOv8858 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperOv8858()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 1, 0, 0, 128 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"m00_f_ov8858\", CameraSensorHelperOv8858)\n+\n class CameraSensorHelperOv8865 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp\nindex e5f27f06..d0757c15 100644\n--- a/src/libcamera/camera_sensor_properties.cpp\n+++ b/src/libcamera/camera_sensor_properties.cpp\n@@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t */\n \t\t\t},\n \t\t} },\n+\t\t{ \"m00_f_ov8858\", {\n+\t\t\t.unitCellSize = { 1200, 1200 },\n+\t\t\t.testPatternModes = {\n+\t\t\t\t{ controls::draft::TestPatternModeOff, 0 },\n+\t\t\t\t{ controls::draft::TestPatternModeColorBars, 1 },\n+\t\t\t\t/*\n+\t\t\t\t * No best corresponding test pattern for:\n+\t\t\t\t * 1: \"Vertical Color Bar Type 1\",\n+\t\t\t\t * 2: \"Vertical Color Bar Type 2\",\n+\t\t\t\t * 3: \"Vertical Color Bar Type 3\",\n+\t\t\t\t * 4: \"Vertical Color Bar Type 4\"\n+\t\t\t\t */\n+\t\t\t},\n+\t\t} },\n \t\t{ \"ov8865\", {\n \t\t\t.unitCellSize = { 1400, 1400 },\n \t\t\t.testPatternModes = {\n", "prefixes": [ "libcamera-devel", "04/11" ] }