From patchwork Mon Oct 24 05:55:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dufresne via libcamera-devel X-Patchwork-Id: 17679 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 5BAD7BD16B for ; Mon, 24 Oct 2022 05:55:58 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id DF3A262EFB; Mon, 24 Oct 2022 07:55:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1666590958; bh=ktXcytuB3Jdh41eKmKNNYbYKnPgRWZSaWHPJNGA5AiA=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pH997UAoDmBwOYfAQpodKD+g8EIHZwj1jlv7pGNJAK1iDbYekKQfjuK7N4tTwm4ym 2SKSBErSlUF7v7nkHQpsty/2usu1hOSHUN7ZF8sK3i0Cxg93E6JTtni2zUH0xXGxRV vxZ+rvx44dfz3HSpKb3V+ls1a04E3puQ6LE+SAarjHWcuxIWXVxK6kQfXzqueUfHCH 6/I89PAPSwiUM2HtsHe0vs3EDS4GDmapsDS1YEZzei76r1+rY22yrFf/5S3IQaducv BCBbGhwGOPKfnt4ngbK8v6t+P9We3CtXFR+YOmBL0O6R21/tdMQZSA7s0Z6hUcj5kI sXS2tiAxGwHhw== Received: from mail-ot1-x334.google.com (mail-ot1-x334.google.com [IPv6:2607:f8b0:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 54F3362EF6 for ; Mon, 24 Oct 2022 07:55:56 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (2048-bit key; unprotected) header.d=rothemail-net.20210112.gappssmtp.com header.i=@rothemail-net.20210112.gappssmtp.com header.b="Hr6u9crW"; dkim-atps=neutral Received: by mail-ot1-x334.google.com with SMTP id w6-20020a056830110600b00665bf86f012so207720otq.0 for ; Sun, 23 Oct 2022 22:55:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothemail-net.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=bOAoyEBkd5by/xGJCiHnwCn4ZxsEtwV5enJoK+EaJao=; b=Hr6u9crWYInpzQuVXUBYxGyHSUWw4oDdiaD5AWFZ78N0SloShaeSoV7OrdOLbk4nWa qqt90uoSLNBBzjUWvnoU0FXzEgge3KdDefig5i0onW6WF7estJSFKvEZhAJja5L02xvU 8EHXk86vUZkvIu+2x0bwcEThAurNmf/dauCUUJcuAKNTvzMcMalOBinGDhtimYZT6r1u 4l1tpb7eXhSUka7c4fK1WeRTa9zGJ4d2ZrZ9uyunEptwwA1mYjiB8O9eP64osjk9GD6v 7Q9PFZB1iwG/KwNsPA72qG3tgJ/zZOVqs2z02LMNRjAZ79P+q8uZrVs1s+XVkMp/fX/q YyEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=bOAoyEBkd5by/xGJCiHnwCn4ZxsEtwV5enJoK+EaJao=; b=iNMMsZP5HwacO7lg/qSmwEDzO1MIJt1BlZbyQvxYnCN/5kpDah230/vn4bVJWJhCXR nfi+hbNG2u/rGnfILoLj9qemZohoMAk1Ikm1lSNqRio8jrMbFpFpghydXMCh0Pk4YIwV SGJw3Bh2mYFhhPvUzMStjU3hEwwembl3dJSMEHGSlrD1fcZsRlUg0HzmvGFiw007H8yu 8xXYKLBwO3tiCfii/VXBIQaRDzR9HnvDc4DUirAIsSTUjuGIlqdvQWBzxdwMJc4YPiUK KJ7S/zhOyoehFSknINdFxy2PM//XcA6pieY7Xz0i4SxlnpVhNpFyWkyWEnEdA8HmpLog Go8g== X-Gm-Message-State: ACrzQf3IlDfuXYpbedCLdBLUG+CYDq5QhY4/mj51uAOJsveU/PFvJRad l0jL1oNqhPhARxyTVWLc9R+PJp4Wh9HhlXfm X-Google-Smtp-Source: AMsMyM4O0JtZVubEnjIOmgu8hHfmimDPsknjX6F6sLfnc728XKeOv75E3WF4RPaEtMCoNYk+MSJbnQ== X-Received: by 2002:a05:6830:6083:b0:660:d54e:583 with SMTP id by3-20020a056830608300b00660d54e0583mr15583735otb.282.1666590954833; Sun, 23 Oct 2022 22:55:54 -0700 (PDT) Received: from nroth-pc.attlocal.net ([2600:1700:20:20c0:7bc3:aed3:676f:10a0]) by smtp.gmail.com with ESMTPSA id x15-20020a9d628f000000b0066193df8edasm3980278otk.34.2022.10.23.22.55.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Oct 2022 22:55:54 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Mon, 24 Oct 2022 00:55:36 -0500 Message-Id: <20221024055543.116040-5-nicholas@rothemail.net> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221024055543.116040-1-nicholas@rothemail.net> References: <20221024055543.116040-1-nicholas@rothemail.net> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 04/11] Adds metadata for the ov8858, which the PinePhone Pro uses. X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Nicholas Roth via libcamera-devel From: Nicolas Dufresne via libcamera-devel Reply-To: libcamera-devel@lists.libcamera.org Cc: nicholas@rothemail.net Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Nicholas Roth --- src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++ src/libcamera/camera_sensor_properties.cpp | 14 ++++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp index 35056bec..1d9a45a7 100644 --- a/src/ipa/libipa/camera_sensor_helper.cpp +++ b/src/ipa/libipa/camera_sensor_helper.cpp @@ -476,6 +476,17 @@ public: }; REGISTER_CAMERA_SENSOR_HELPER("ov5693", CameraSensorHelperOv5693) +class CameraSensorHelperOv8858 : public CameraSensorHelper +{ +public: + CameraSensorHelperOv8858() + { + gainType_ = AnalogueGainLinear; + gainConstants_.linear = { 1, 0, 0, 128 }; + } +}; +REGISTER_CAMERA_SENSOR_HELPER("m00_f_ov8858", CameraSensorHelperOv8858) + class CameraSensorHelperOv8865 : public CameraSensorHelper { public: diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp index e5f27f06..d0757c15 100644 --- a/src/libcamera/camera_sensor_properties.cpp +++ b/src/libcamera/camera_sensor_properties.cpp @@ -146,6 +146,20 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen */ }, } }, + { "m00_f_ov8858", { + .unitCellSize = { 1200, 1200 }, + .testPatternModes = { + { controls::draft::TestPatternModeOff, 0 }, + { controls::draft::TestPatternModeColorBars, 1 }, + /* + * No best corresponding test pattern for: + * 1: "Vertical Color Bar Type 1", + * 2: "Vertical Color Bar Type 2", + * 3: "Vertical Color Bar Type 3", + * 4: "Vertical Color Bar Type 4" + */ + }, + } }, { "ov8865", { .unitCellSize = { 1400, 1400 }, .testPatternModes = {