Patch Detail
Show a patch.
GET /api/1.1/patches/17554/?format=api
{ "id": 17554, "url": "https://patchwork.libcamera.org/api/1.1/patches/17554/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17554/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>", "date": "2022-10-06T22:15:06", "name": "[libcamera-devel] test: controls: control_info: Test default def() values", "commit_ref": "b5ef421e0320d4a0578dee0109049637a7ad7a0d", "pull_url": null, "state": "accepted", "archived": false, "hash": "c7965395bd0c859d59ef35af480040b4e84c5489", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17554/mbox/", "series": [ { "id": 3540, "url": "https://patchwork.libcamera.org/api/1.1/series/3540/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3540", "date": "2022-10-06T22:15:06", "name": "[libcamera-devel] test: controls: control_info: Test default def() values", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3540/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17554/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17554/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FCE9C0DA4\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 6 Oct 2022 22:15:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 07A0E62CF5;\n\tFri, 7 Oct 2022 00:15:13 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C80EC601C7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 7 Oct 2022 00:15:11 +0200 (CEST)", "from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi\n\t[62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 15C966D6;\n\tFri, 7 Oct 2022 00:15:10 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1665094513;\n\tbh=qDdR6cxpajR1Ks3ZvpEqct03EzkjtuqjKUhHpWJLajg=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=sBuSE6ipOwBYt72JkeWhUmBtSv6zMJZvt4Dcgi4TJ3s7h3qmHPoTUAZ/mpBVMNzeZ\n\thhLJvU8zRmBK1bBRVI4WJ/Al/l2/K159VX5eND+sXEqVgP59KGLRv4XEPQVZlx4Bzd\n\tNHhI/PoUaWzHc6svEZYgDGJ+4yUWUqfNsDmcQ/yYsmbWeAQa0lXAGhEcc+N9tlmMbV\n\t9x1h/x39vS7q4eiYnrcmi9+B+i+lokhz/0r+yHdVKz048aGz4jnnjFKo8tfWOq9Oo1\n\t98z5b/9Gx7jkjLHlIOpajF93NFOf6GKs3ka7cgcgJjjeQit2vdaQQ6ZMHzZ+YNVvah\n\thhyOJVqdp0gDw==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1665094511;\n\tbh=qDdR6cxpajR1Ks3ZvpEqct03EzkjtuqjKUhHpWJLajg=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=oEXNf+kPVQAWscg/ON0Xxx0YTlXaqTMaX/FZYgkrItzJq9+Qcefvwy2oba6fYcOVj\n\t9tCgMpaL+FIIpjKQImiH18iQG/Q29Y+vKDCVUqFVnl4DTpj03zpLlfcXAGkmOJY0in\n\tNmNBUpqv4W+ZaOOp9JCcCq2XB+ukCcMG4Mor4y7M=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"oEXNf+kP\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 7 Oct 2022 01:15:06 +0300", "Message-Id": "<20221006221506.16948-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] test: controls: control_info: Test\n\tdefault def() values", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Extend the ControlInfoMap test to verify the behaviour of the default\n'def' argument to the ControlInfoMap constructor.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n test/controls/control_info.cpp | 8 +++++---\n 1 file changed, 5 insertions(+), 3 deletions(-)", "diff": "diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp\nindex 56b4101f72fe..1176a5024b3a 100644\n--- a/test/controls/control_info.cpp\n+++ b/test/controls/control_info.cpp\n@@ -27,19 +27,21 @@ protected:\n \t\tControlInfo brightness;\n \n \t\tif (brightness.min().type() != ControlType::ControlTypeNone ||\n-\t\t brightness.max().type() != ControlType::ControlTypeNone) {\n+\t\t brightness.max().type() != ControlType::ControlTypeNone ||\n+\t\t brightness.def().type() != ControlType::ControlTypeNone) {\n \t\t\tcout << \"Invalid control range for Brightness\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n \n \t\t/*\n \t\t * Test information retrieval from a control with a minimum and\n-\t\t * a maximum value.\n+\t\t * a maximum value, and an implicit default value.\n \t\t */\n \t\tControlInfo contrast(10, 200);\n \n \t\tif (contrast.min().get<int32_t>() != 10 ||\n-\t\t contrast.max().get<int32_t>() != 200) {\n+\t\t contrast.max().get<int32_t>() != 200 ||\n+\t\t !contrast.def().isNone()) {\n \t\t\tcout << \"Invalid control range for Contrast\" << endl;\n \t\t\treturn TestFail;\n \t\t}\n", "prefixes": [ "libcamera-devel" ] }