From patchwork Thu Oct 6 22:15:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 17554 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 9FCE9C0DA4 for ; Thu, 6 Oct 2022 22:15:13 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 07A0E62CF5; Fri, 7 Oct 2022 00:15:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1665094513; bh=qDdR6cxpajR1Ks3ZvpEqct03EzkjtuqjKUhHpWJLajg=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=sBuSE6ipOwBYt72JkeWhUmBtSv6zMJZvt4Dcgi4TJ3s7h3qmHPoTUAZ/mpBVMNzeZ hhLJvU8zRmBK1bBRVI4WJ/Al/l2/K159VX5eND+sXEqVgP59KGLRv4XEPQVZlx4Bzd NHhI/PoUaWzHc6svEZYgDGJ+4yUWUqfNsDmcQ/yYsmbWeAQa0lXAGhEcc+N9tlmMbV 9x1h/x39vS7q4eiYnrcmi9+B+i+lokhz/0r+yHdVKz048aGz4jnnjFKo8tfWOq9Oo1 98z5b/9Gx7jkjLHlIOpajF93NFOf6GKs3ka7cgcgJjjeQit2vdaQQ6ZMHzZ+YNVvah hhyOJVqdp0gDw== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C80EC601C7 for ; Fri, 7 Oct 2022 00:15:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="oEXNf+kP"; dkim-atps=neutral Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 15C966D6; Fri, 7 Oct 2022 00:15:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1665094511; bh=qDdR6cxpajR1Ks3ZvpEqct03EzkjtuqjKUhHpWJLajg=; h=From:To:Cc:Subject:Date:From; b=oEXNf+kPVQAWscg/ON0Xxx0YTlXaqTMaX/FZYgkrItzJq9+Qcefvwy2oba6fYcOVj 9tCgMpaL+FIIpjKQImiH18iQG/Q29Y+vKDCVUqFVnl4DTpj03zpLlfcXAGkmOJY0in NmNBUpqv4W+ZaOOp9JCcCq2XB+ukCcMG4Mor4y7M= To: libcamera-devel@lists.libcamera.org Date: Fri, 7 Oct 2022 01:15:06 +0300 Message-Id: <20221006221506.16948-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH] test: controls: control_info: Test default def() values X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Extend the ControlInfoMap test to verify the behaviour of the default 'def' argument to the ControlInfoMap constructor. Signed-off-by: Laurent Pinchart Reviewed-by: Kieran Bingham Reviewed-by: Umang Jain --- test/controls/control_info.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp index 56b4101f72fe..1176a5024b3a 100644 --- a/test/controls/control_info.cpp +++ b/test/controls/control_info.cpp @@ -27,19 +27,21 @@ protected: ControlInfo brightness; if (brightness.min().type() != ControlType::ControlTypeNone || - brightness.max().type() != ControlType::ControlTypeNone) { + brightness.max().type() != ControlType::ControlTypeNone || + brightness.def().type() != ControlType::ControlTypeNone) { cout << "Invalid control range for Brightness" << endl; return TestFail; } /* * Test information retrieval from a control with a minimum and - * a maximum value. + * a maximum value, and an implicit default value. */ ControlInfo contrast(10, 200); if (contrast.min().get() != 10 || - contrast.max().get() != 200) { + contrast.max().get() != 200 || + !contrast.def().isNone()) { cout << "Invalid control range for Contrast" << endl; return TestFail; }