Patch Detail
Show a patch.
GET /api/1.1/patches/17262/?format=api
{ "id": 17262, "url": "https://patchwork.libcamera.org/api/1.1/patches/17262/?format=api", "web_url": "https://patchwork.libcamera.org/patch/17262/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220830202124.457253-1-Rauch.Christian@gmx.de>", "date": "2022-08-30T20:21:23", "name": "[libcamera-devel,v2,1/2] libcamera: control: initialise control info to ControlTypeNone by default", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "18e92f143aea1159abf2e7c858d419d0c08fd2dc", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/17262/mbox/", "series": [ { "id": 3456, "url": "https://patchwork.libcamera.org/api/1.1/series/3456/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3456", "date": "2022-08-30T20:21:23", "name": "[libcamera-devel,v2,1/2] libcamera: control: initialise control info to ControlTypeNone by default", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3456/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/17262/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/17262/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4FCD2C3272\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 30 Aug 2022 20:21:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A161561FC0;\n\tTue, 30 Aug 2022 22:21:28 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA6A61F9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 30 Aug 2022 22:21:27 +0200 (CEST)", "from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005\n\t[212.227.17.190]) with ESMTPSA (Nemesis) id 1McY8d-1ozRkZ3Jkr-00cvce;\n\tTue, 30 Aug 2022 22:21:26 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1661890888;\n\tbh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=;\n\th=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post:\n\tList-Help:List-Subscribe:From:Reply-To:From;\n\tb=YmwyUNky/4xS6M/rKrvlH6nYU3tpvGRAzjdKZN92/+ay4nHimU8gQIeCLvw9XhnMh\n\teIu1N3Ki+jYZu0rPtW7+9bcrDhFH2Q4gVc/8sylnkt89wPZxBToJsu9ob2LejVnSHZ\n\t9bJgzF76xlJWBwJFgJiJwOIWrKI/gHk4neQf6mw6cIy1gkCk6hVcVYR/8Kf6okXC3r\n\t2Nw82uKb7o7Zki0Jt57g9xM64AZIdDM/+ZBF7z2GSk+NPh0nMHpEunUTORsF9g7f3u\n\t5LknfhXUoG9unksksaGqn09HzLSi+4pK2axFgfkopTGjEwQZ6hwv/a8rpcnCbw0tvS\n\t4j5fCgqgMkxAA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1661890887;\n\tbh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date;\n\tb=bC9Z3S+8OSXxEBq5MNLpFq7yek7W84ueLj7LrOw4jxWNvYuj+E565N+S96imeBdbM\n\tPmXnj/MLTOxVdWLnPvdqk32Udr7MozU/MZUkJqZG7ZPGYjtrDPShBxwSJRD40Yvd+C\n\tFhmsuBGuFBCxvHPEZSLWVCQW/5cH/V3nATu2wt6g=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"bC9Z3S+8\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 30 Aug 2022 22:21:23 +0200", "Message-Id": "<20220830202124.457253-1-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:KXe2+csuTT4xvrh5bcUIyEi3M6h0Q2CIYSwiEem1tBc/ThfQJIX\n\tsQCkTIATfavvDNhMMfYbxJj3QpImAhCUb1EXBUEB/7QNlhQwv8/NbX/kycbkltlaLwB+lKE\n\tasTFrLV43GRbBo1e+64WZhOVJs1dhl1KsBp+LPGpywd2gm/zQn3HZsIdhoI7+eu9YVxDdhp\n\t6KChOi5CHRPIj7hzMc0Zw==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:6qJP1byFpcU=:fBFX+0Y6oRWRqPhELtiKV6\n\tmq27v1BVniPN8yLX5X69eXDU+kiwFCns5Zrdf9+iOUfQuTc9fXzRni/yWOujZv6Pe7YOX7Y8H\n\t8pinl/xAU3tK6VT3HshYZ62EBD3SQhi44/5ntsOy2HxFQNZH/3HoQTBw4BygY1c324SUHoCdH\n\tOtRvsJou0+j2AVW3Za7vVx27SULUjXDl2pSxc4vReXusntb8zMq6okM9ftApyMQW5mbbWdrF7\n\t9VVQkfLwmkxbEn0Gxo2u7qQFFODFLV8zLUOKxoVY7sVYnUP997p/T13Imso5RLhNnEUtBmhOR\n\tDg6hoEOEuu72RJg2aURLM+5ACTp1H5zpwH0GfnPlDvcx5W0d5rcgMotQQFxVWmClpcVt6d4E7\n\tqYLM7Lww1MQXLOQEWR/9joeG8m7IOgqkDWnAuChc04WvGJL9mjownj6pkaWyKWcuU0di45SRs\n\tDzGMma73PTtGjEFVuvsKqFIqJxbngcsFzOxlxb5fgw0ZJGLxW5nI3MOXrhuj37thhcgM0bfoC\n\tpTvYkkse7R3Ex7JipMQAv1WBMZQlH7/bnc//x0UumY8aEp+tIHOgzHDsx68x5e2BtqU5ZRIS1\n\tdlBAJrxicx3OwkffTKPvj7oh9AWmTGn1o2nyaGbv5ObB1d5qA3xziolnKIps6gIyqIlmjkN1b\n\thaeVy2ogImjp6D7idbgdkttafQMtj7YNSop8IqrV77fvw0GOs3CJGiE3Dubdp74JM2UhH69Yn\n\tlQzv6pgeVz3OUpXJnoKYx/dL0VZLsTGZSBoGM/GMSogyHNMCRiZSwqqMKYsbfltz2oQnS8MoL\n\tD341mDeHIeSx3TwT3oVYIiqCj3HVs/62QHHI6SX1TyGSOwW/O7UzDTESFaJbRXQ+I0fBF9d6D\n\tYdv4SrcR6Vk7C3u7WR0rX/996hgrA7qxWFWv5YNHGkcaT4ay7a9n3yQiTW+7vfR6xgeuE+Zjq\n\t+qQXE/XwmlvoIhIO8Yag5bPcZoTrMVNzYNx1jxY7mLw7gZpF+U90pHuXX2VsaKgvZJxMdtbuX\n\tjkFVo0VBOVqAbHkR6/2weBkvjXEvZt+Z84C56hORypYvULat8yNZIJHFFUxI65IpQEOedmhLs\n\ttY4pF/1KcSHkHkaY7IoOeMD6UXTqh6Nq7HKH05kAHTYKkW44BT42SUWBr2hZWK5HQGUxrL/di\n\tOC+zGbQlRTaL9ICAKxwYWZyxSo", "Subject": "[libcamera-devel] [PATCH v2 1/2] libcamera: control: initialise\n\tcontrol info to ControlTypeNone by default", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default ControlInfo constructor allows to partially initialised the\nmin/max/def values. Uninitialised values are assigned to 0 by default. This\nimplicit initialisation makes it impossible to distinguish between and\nuninitialised and an explicitly 0-initialised ControlValue.\n\nDefault construct the ControlValue in the ControlInfo default contructor to\nexplicitly represent uninitialised values by the ControlTypeNone type.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\n---\n include/libcamera/controls.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex ebc168fc..38d0a3e8 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -268,9 +268,9 @@ private:\n class ControlInfo\n {\n public:\n-\texplicit ControlInfo(const ControlValue &min = 0,\n-\t\t\t const ControlValue &max = 0,\n-\t\t\t const ControlValue &def = 0);\n+\texplicit ControlInfo(const ControlValue &min = {},\n+\t\t\t const ControlValue &max = {},\n+\t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(Span<const ControlValue> values,\n \t\t\t const ControlValue &def = {});\n \texplicit ControlInfo(std::set<bool> values, bool def);\n", "prefixes": [ "libcamera-devel", "v2", "1/2" ] }