From patchwork Tue Aug 30 20:21:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17262 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4FCD2C3272 for ; Tue, 30 Aug 2022 20:21:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A161561FC0; Tue, 30 Aug 2022 22:21:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661890888; bh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=; h=To:Date:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YmwyUNky/4xS6M/rKrvlH6nYU3tpvGRAzjdKZN92/+ay4nHimU8gQIeCLvw9XhnMh eIu1N3Ki+jYZu0rPtW7+9bcrDhFH2Q4gVc/8sylnkt89wPZxBToJsu9ob2LejVnSHZ 9bJgzF76xlJWBwJFgJiJwOIWrKI/gHk4neQf6mw6cIy1gkCk6hVcVYR/8Kf6okXC3r 2Nw82uKb7o7Zki0Jt57g9xM64AZIdDM/+ZBF7z2GSk+NPh0nMHpEunUTORsF9g7f3u 5LknfhXUoG9unksksaGqn09HzLSi+4pK2axFgfkopTGjEwQZ6hwv/a8rpcnCbw0tvS 4j5fCgqgMkxAA== Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 3CA6A61F9C for ; Tue, 30 Aug 2022 22:21:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="bC9Z3S+8"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661890887; bh=tIaonYy4IBbM0ubtpXEfksF3Htg5EcUEV2iQclBuypU=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=bC9Z3S+8OSXxEBq5MNLpFq7yek7W84ueLj7LrOw4jxWNvYuj+E565N+S96imeBdbM PmXnj/MLTOxVdWLnPvdqk32Udr7MozU/MZUkJqZG7ZPGYjtrDPShBxwSJRD40Yvd+C FhmsuBGuFBCxvHPEZSLWVCQW/5cH/V3nATu2wt6g= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1McY8d-1ozRkZ3Jkr-00cvce; Tue, 30 Aug 2022 22:21:26 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Aug 2022 22:21:23 +0200 Message-Id: <20220830202124.457253-1-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Provags-ID: V03:K1:KXe2+csuTT4xvrh5bcUIyEi3M6h0Q2CIYSwiEem1tBc/ThfQJIX sQCkTIATfavvDNhMMfYbxJj3QpImAhCUb1EXBUEB/7QNlhQwv8/NbX/kycbkltlaLwB+lKE asTFrLV43GRbBo1e+64WZhOVJs1dhl1KsBp+LPGpywd2gm/zQn3HZsIdhoI7+eu9YVxDdhp 6KChOi5CHRPIj7hzMc0Zw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:6qJP1byFpcU=:fBFX+0Y6oRWRqPhELtiKV6 mq27v1BVniPN8yLX5X69eXDU+kiwFCns5Zrdf9+iOUfQuTc9fXzRni/yWOujZv6Pe7YOX7Y8H 8pinl/xAU3tK6VT3HshYZ62EBD3SQhi44/5ntsOy2HxFQNZH/3HoQTBw4BygY1c324SUHoCdH OtRvsJou0+j2AVW3Za7vVx27SULUjXDl2pSxc4vReXusntb8zMq6okM9ftApyMQW5mbbWdrF7 9VVQkfLwmkxbEn0Gxo2u7qQFFODFLV8zLUOKxoVY7sVYnUP997p/T13Imso5RLhNnEUtBmhOR Dg6hoEOEuu72RJg2aURLM+5ACTp1H5zpwH0GfnPlDvcx5W0d5rcgMotQQFxVWmClpcVt6d4E7 qYLM7Lww1MQXLOQEWR/9joeG8m7IOgqkDWnAuChc04WvGJL9mjownj6pkaWyKWcuU0di45SRs DzGMma73PTtGjEFVuvsKqFIqJxbngcsFzOxlxb5fgw0ZJGLxW5nI3MOXrhuj37thhcgM0bfoC pTvYkkse7R3Ex7JipMQAv1WBMZQlH7/bnc//x0UumY8aEp+tIHOgzHDsx68x5e2BtqU5ZRIS1 dlBAJrxicx3OwkffTKPvj7oh9AWmTGn1o2nyaGbv5ObB1d5qA3xziolnKIps6gIyqIlmjkN1b haeVy2ogImjp6D7idbgdkttafQMtj7YNSop8IqrV77fvw0GOs3CJGiE3Dubdp74JM2UhH69Yn lQzv6pgeVz3OUpXJnoKYx/dL0VZLsTGZSBoGM/GMSogyHNMCRiZSwqqMKYsbfltz2oQnS8MoL D341mDeHIeSx3TwT3oVYIiqCj3HVs/62QHHI6SX1TyGSOwW/O7UzDTESFaJbRXQ+I0fBF9d6D Ydv4SrcR6Vk7C3u7WR0rX/996hgrA7qxWFWv5YNHGkcaT4ay7a9n3yQiTW+7vfR6xgeuE+Zjq +qQXE/XwmlvoIhIO8Yag5bPcZoTrMVNzYNx1jxY7mLw7gZpF+U90pHuXX2VsaKgvZJxMdtbuX jkFVo0VBOVqAbHkR6/2weBkvjXEvZt+Z84C56hORypYvULat8yNZIJHFFUxI65IpQEOedmhLs tY4pF/1KcSHkHkaY7IoOeMD6UXTqh6Nq7HKH05kAHTYKkW44BT42SUWBr2hZWK5HQGUxrL/di OC+zGbQlRTaL9ICAKxwYWZyxSo Subject: [libcamera-devel] [PATCH v2 1/2] libcamera: control: initialise control info to ControlTypeNone by default X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The default ControlInfo constructor allows to partially initialised the min/max/def values. Uninitialised values are assigned to 0 by default. This implicit initialisation makes it impossible to distinguish between and uninitialised and an explicitly 0-initialised ControlValue. Default construct the ControlValue in the ControlInfo default contructor to explicitly represent uninitialised values by the ControlTypeNone type. Signed-off-by: Christian Rauch --- include/libcamera/controls.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.34.1 diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h index ebc168fc..38d0a3e8 100644 --- a/include/libcamera/controls.h +++ b/include/libcamera/controls.h @@ -268,9 +268,9 @@ private: class ControlInfo { public: - explicit ControlInfo(const ControlValue &min = 0, - const ControlValue &max = 0, - const ControlValue &def = 0); + explicit ControlInfo(const ControlValue &min = {}, + const ControlValue &max = {}, + const ControlValue &def = {}); explicit ControlInfo(Span values, const ControlValue &def = {}); explicit ControlInfo(std::set values, bool def); From patchwork Tue Aug 30 20:21:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 17263 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BBB27C3272 for ; Tue, 30 Aug 2022 20:21:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8CDF461FC4; Tue, 30 Aug 2022 22:21:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1661890889; bh=wOJwDrNf0xdBeE0FltnByPOrSE8MMXUO8R+6Wl9E6fI=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=0cteoDbl0WKRQSmAiRraHeSwUQxZfm/TnxWrViiDlEFIFj2U5DsTbnNumE4qdGlDc Y5X1C52XgGfuidr4/A0Q3PaOvlJBWtsWNyiG1nZGCrgxhrQ9ydKlUDxBcymYELuJZH rpzFWICcHjqkmu4wLjy1/Qt2gNiWNJHhyYINAz1R0V1sHppu+IFIQ1oG4ChSxEOQoj lftKC5FzF7HUoAbeTgmYn62wHL/JTq9pN6Igml14Nqew2Usr/PubGYPeI2bGaP/VnT IyLV+ux5mJw+SQ9D3bBriP7n5IxWjq/NBrrKZAEave7tz2REMjAyaIU+gq6eYjmLUG q8YdwEjJkcIMQ== Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 59AD461F9E for ; Tue, 30 Aug 2022 22:21:27 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="kCfuDAPN"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1661890887; bh=wOJwDrNf0xdBeE0FltnByPOrSE8MMXUO8R+6Wl9E6fI=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=kCfuDAPNAwk9hiYMWGAj2DcCz1bFtVyJSLct6JED3AYDxES6NGOeAM2qqNjn6iPB5 94PrKMr4+vdAiSNzc+f10dpNSQANKfbl+t4RZxFpT7nHro2YVIORln9PEGmRhcIKaC +bXTjKdltJzDIs+66t9PhLw3a3zfiL59zr/Lgv2E= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from voyager ([88.152.184.103]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MnakR-1pAP353uzN-00jZTE; Tue, 30 Aug 2022 22:21:27 +0200 To: libcamera-devel@lists.libcamera.org Date: Tue, 30 Aug 2022 22:21:24 +0200 Message-Id: <20220830202124.457253-2-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220830202124.457253-1-Rauch.Christian@gmx.de> References: <20220830202124.457253-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:YLfPpHiEBGYWMZ28F4JCtdPlfWSV6GTqGpW4k2PIxc8vIjovsZ5 /0Hlksk3X0B1SkO5XoW7iwmcNM+KbJBUFNe47u4VPzG0gdn1OEucFR0TfJxdrqxsL4JK628 a26YV9nb+nGqBuslHLGs/ziZ4mhop0TnySDsyf+ahcHvHhPxb2U4mCkMpQOa3UdExgUlBqB WwvitfVkTlHnJ2ehC9nGw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:awd+5/3pgic=:wN8ON1Wms3YXwdQcpq58o1 GbJzJA1i53iRQ0yXtHn3mtIG+2d83HQgPPDx9XmOiBCd79kP7UOxG0H8OPt25xhhGugK4Jj7Q Z5aU0ZWSeyE0q1ApAV9Yx69et6WHvGXzG6jMrEcX/hIUUFIkipa63lENJE+LjdgJ88CtttL6h Jcioreo9QEVBvpiJf+VecwHtxUvvzSrUljh0js6AuEJANH+u2Nl1k/2WCYkDDi/Xs/2D27kZc UO/0R5NMYTZdVXZWnN2oDgfCish47cQEeRbTUwXhKe0XOlcBQoh1cNocLyZ7F3JOtSzSJ2Rhh mLYgUkDJ5LDSjMjFpCOesO8XTbR9AAjoQ7PRsNKzJNVZrrvgH7yAEdPFaHqaNu3miuMDyThlE gbH/ZbpPUDpMXQpgHN5aDFo9MbjidT43gWPnL5j/6gQ1AA+yC608wQHLR9tA2zvEf4/O37piK qr1ASa3pmXIQ5WqX8rUVjFJ+ABtheFSHSioonhVKd7RyNddxKc8shdgztGPfunZT36MDd0w1k zDQAsc77vefR4BM4XD0hqzqvcHuCG9vIk7ckzAPVQidvFf/u/I3uMFrnhIgk2+VXGo05dA3wE QYoAjZMNO/VeWIoqOeVCKmmz37vbIyQx/3MNV3SkW4NTqyVm387jMk4Cxi6wdaOQ12nRg07fs 0SOggYQxJ6DiKRq0ytYgqLdLIkGJiNjM+lIWEVXc/BA7CqNGLjVEblhzCUFHlB6AGoTSFf4ao U7cowfEuWpnG5Rn2TrYRUOGDYYBuM09NMCUsQLnU9TWBerKXtO9Edx8mgyZd6EiJLJDioyY5Z pZI/V74gYpmzWL/94W+xdk/BdxR86MUOtU3kuf6YYy0JIu/CL1fI1lZc62ls20zsL9gOShKv+ 4+OYF4As2bi+cQzZ27Pc1lAObqvQ+tGOcbe3DTmQSRU7ByFzI+7i2yePuhyrZiMDT7goSNznu k3j1+QjFPrAwjo22tvhj3ARcpgQSPNyihXZXR4F5TBcZDyVcWwag4PBfIyOf7asQJVB/NevZv 294b23iTQmw1MaodIZqeBwRZrqASy5Nae31zjpAwBsjDQ6DZJ05U9/PwJJei9g1OBmIPd5hzP TCg+ziFbIkr4wtFUdWHa5hJSDgE1zFPj36PjgIQNFunw37Z6pFg3C4pIA== Subject: [libcamera-devel] [PATCH v2 2/2] test: represent uninitialised values via ControlTypeNone X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Previously, not explicitly initialised values were represented by 0. This was replaced by ControlTypeNone for better semantics. Signed-off-by: Christian Rauch --- test/controls/control_info.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1 diff --git a/test/controls/control_info.cpp b/test/controls/control_info.cpp index 2827473b..56b4101f 100644 --- a/test/controls/control_info.cpp +++ b/test/controls/control_info.cpp @@ -26,8 +26,8 @@ protected: */ ControlInfo brightness; - if (brightness.min().get() != 0 || - brightness.max().get() != 0) { + if (brightness.min().type() != ControlType::ControlTypeNone || + brightness.max().type() != ControlType::ControlTypeNone) { cout << "Invalid control range for Brightness" << endl; return TestFail; }