Patch Detail
Show a patch.
GET /api/1.1/patches/16450/?format=api
{ "id": 16450, "url": "https://patchwork.libcamera.org/api/1.1/patches/16450/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16450/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220630063443.357054-1-umang.jain@ideasonboard.com>", "date": "2022-06-30T06:34:43", "name": "[libcamera-devel,v1.1] gstreamer: Be pedantic on srcpads access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "dc2be480a9d285142af132057c3c6ea1cc7d5e64", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16450/mbox/", "series": [ { "id": 3235, "url": "https://patchwork.libcamera.org/api/1.1/series/3235/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3235", "date": "2022-06-30T06:34:43", "name": "[libcamera-devel,v1.1] gstreamer: Be pedantic on srcpads access", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3235/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16450/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16450/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 61C39BD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 30 Jun 2022 06:34:55 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0A476564E;\n\tThu, 30 Jun 2022 08:34:54 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6840160403\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 30 Jun 2022 08:34:52 +0200 (CEST)", "from perceval.ideasonboard.com (unknown\n\t[IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B6DA45F;\n\tThu, 30 Jun 2022 08:34:50 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1656570894;\n\tbh=NeywukeifjWUPXujJOht7K18Um1Kkk/5QPCSyRGw69o=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=jPCPP8jzHQpQr4uSauBL7cUWJbPzj5mW7fMwjI1BrGzO4PE/1YScc8dfa3dYtvkEP\n\tplG58JupzAf6urlEWKBTgVfA7evwzRpnn9zQVUNqY1fNc77icWGjvx8XeG7ehtjgpc\n\tswVQoM/M6KvnzxBqp1nHzhwEewtxZaoum+AGjvlyUDXDVn817PRZUQ8pxXZtla0MGi\n\tKuagG13hTnO1khrrXTMltfEfRJYkaITdGOAywVzTX/ZeF4AY4MZp25IpGUBCxuWKVV\n\tZiJuH2Kq05EaKuCF5cA4+dIHVxSxNYigSCh+upTilMVaO/c+3fq/BwAtASJuzX4xPa\n\tpvtm+UBDADZPA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1656570892;\n\tbh=NeywukeifjWUPXujJOht7K18Um1Kkk/5QPCSyRGw69o=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ThxvQIBsCnctpqKSCpSb0WAxBbU/WXXpaeyguVPpeeVbRccVEMSvll/YBAxtNzKZr\n\tZWTg7yGBaG+4hlOA3kKqsCSSinhSPGMHhSWs4bqRUEbKoULEQ66prx2C7Z74nBi4io\n\tj307A0vXjr52q8ET1k9HMFk4nvUfxgDExwMUnO1s=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"ThxvQIBs\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 30 Jun 2022 12:04:43 +0530", "Message-Id": "<20220630063443.357054-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<YrzsIzvGidYDZvR/@pendragon.ideasonboard.com>", "References": "<YrzsIzvGidYDZvR/@pendragon.ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on srcpads\n\taccess", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Umang Jain via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Umang Jain <umang.jain@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use the std::vector::back() instead of [0] index which corresponds\nto std::vector::push_back() for tracking of pads. This doesn't\nintroduce a functional change as the gst_libcamera_src_init() will\nonly add one pad but it helps with readability.\n\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 46fd02d2..4813ab96 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)\n \tgst_task_set_lock(self->task, &self->stream_lock);\n \n \tstate->srcpads_.push_back(gst_pad_new_from_template(templ, \"src\"));\n-\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);\n+\tgst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());\n \n \t/* C-style friend. */\n \tstate->src_ = self;\n", "prefixes": [ "libcamera-devel", "v1.1" ] }