From patchwork Thu Jun 30 06:34:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 16450 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 61C39BD808 for ; Thu, 30 Jun 2022 06:34:55 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B0A476564E; Thu, 30 Jun 2022 08:34:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1656570894; bh=NeywukeifjWUPXujJOht7K18Um1Kkk/5QPCSyRGw69o=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=jPCPP8jzHQpQr4uSauBL7cUWJbPzj5mW7fMwjI1BrGzO4PE/1YScc8dfa3dYtvkEP plG58JupzAf6urlEWKBTgVfA7evwzRpnn9zQVUNqY1fNc77icWGjvx8XeG7ehtjgpc swVQoM/M6KvnzxBqp1nHzhwEewtxZaoum+AGjvlyUDXDVn817PRZUQ8pxXZtla0MGi KuagG13hTnO1khrrXTMltfEfRJYkaITdGOAywVzTX/ZeF4AY4MZp25IpGUBCxuWKVV ZiJuH2Kq05EaKuCF5cA4+dIHVxSxNYigSCh+upTilMVaO/c+3fq/BwAtASJuzX4xPa pvtm+UBDADZPA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6840160403 for ; Thu, 30 Jun 2022 08:34:52 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ThxvQIBs"; dkim-atps=neutral Received: from perceval.ideasonboard.com (unknown [IPv6:2401:4900:1f3f:ca21:e286:106b:5da4:9482]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 0B6DA45F; Thu, 30 Jun 2022 08:34:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1656570892; bh=NeywukeifjWUPXujJOht7K18Um1Kkk/5QPCSyRGw69o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ThxvQIBsCnctpqKSCpSb0WAxBbU/WXXpaeyguVPpeeVbRccVEMSvll/YBAxtNzKZr ZWTg7yGBaG+4hlOA3kKqsCSSinhSPGMHhSWs4bqRUEbKoULEQ66prx2C7Z74nBi4io j307A0vXjr52q8ET1k9HMFk4nvUfxgDExwMUnO1s= To: libcamera-devel@lists.libcamera.org Date: Thu, 30 Jun 2022 12:04:43 +0530 Message-Id: <20220630063443.357054-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on srcpads access X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Umang Jain via libcamera-devel From: Umang Jain Reply-To: Umang Jain Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Use the std::vector::back() instead of [0] index which corresponds to std::vector::push_back() for tracking of pads. This doesn't introduce a functional change as the gst_libcamera_src_init() will only add one pad but it helps with readability. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/gstreamer/gstlibcamerasrc.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp index 46fd02d2..4813ab96 100644 --- a/src/gstreamer/gstlibcamerasrc.cpp +++ b/src/gstreamer/gstlibcamerasrc.cpp @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self) gst_task_set_lock(self->task, &self->stream_lock); state->srcpads_.push_back(gst_pad_new_from_template(templ, "src")); - gst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]); + gst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back()); /* C-style friend. */ state->src_ = self;