Patch Detail
Show a patch.
GET /api/1.1/patches/16145/?format=api
{ "id": 16145, "url": "https://patchwork.libcamera.org/api/1.1/patches/16145/?format=api", "web_url": "https://patchwork.libcamera.org/patch/16145/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220603220712.73673-4-Rauch.Christian@gmx.de>", "date": "2022-06-03T22:07:10", "name": "[libcamera-devel,v6,3/5] libcamera: controls: Define size of array controls as a shape vector", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "3b18e268fd1237c12c7964bf59403f3158744e57", "submitter": { "id": 111, "url": "https://patchwork.libcamera.org/api/1.1/people/111/?format=api", "name": "Christian Rauch", "email": "Rauch.Christian@gmx.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/16145/mbox/", "series": [ { "id": 3158, "url": "https://patchwork.libcamera.org/api/1.1/series/3158/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3158", "date": "2022-06-03T22:07:07", "name": "generate and use fixed-sized Span Control types", "version": 6, "mbox": "https://patchwork.libcamera.org/series/3158/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/16145/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/16145/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D71D5C3274\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 3 Jun 2022 22:07:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B03B46563D;\n\tSat, 4 Jun 2022 00:07:20 +0200 (CEST)", "from mout.gmx.net (mout.gmx.net [212.227.15.18])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFB836040E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 4 Jun 2022 00:07:16 +0200 (CEST)", "from localhost.localdomain ([92.18.80.244]) by mail.gmx.net\n\t(mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id\n\t1Mel7v-1nPHk11ui5-00anMn; Sat, 04 Jun 2022 00:07:16 +0200" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1654294040;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=EeWQgfLhGpAGDp0o023SKLoWfKiJi+owpOr8I72O4O+sFrk+cjVHj1rd/CZw3nACY\n\txgRZK6uPM91LHR9j97iCktyFjsL4Er3tggyEl2smtgRBdIinRWeehmOuBmusWwu/Pj\n\tzrTw36AISu69srREWfuqxUCu/QHYSum8vrvHOH2sc9l5zK9tYr5QtTOnUDJRGB6bFf\n\tSPNVu7U6u0ZziPKG/Ce5n/OgNB7OyL1Q+EiYFaEXrZwEllou/4PommJwEEte4olChp\n\ts8bRJBubtzCk44J3gYDH2eNhCzlRyrbcgrR6fLURP9BEpshPMiRyG/7Z3rvYLE6d+e\n\tiPQPU5cTxAS2Q==", "v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;\n\ts=badeba3b8450; t=1654294036;\n\tbh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=;\n\th=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References;\n\tb=Qf+jAdp/+SO5ygnFC0bq5Pq+gkxsPezXyKi0/vc0b4r5frQ+26fKotNqwXLE72HA4\n\tewX5cP6aBGw+KeHHm0JFyvDFcLzyhgv/lJoriiQWoCxT6e5reyteq4q8YFIocjW46C\n\tklJ6cYnig1ZvwQVBX5XD0Pa5iEFwvP/Fant0JeYY=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=gmx.net header.i=@gmx.net\n\theader.b=\"Qf+jAdp/\"; dkim-atps=neutral", "X-UI-Sender-Class": "01bb95c1-4bf8-414a-932a-4f6e2808ef9c", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 3 Jun 2022 23:07:10 +0100", "Message-Id": "<20220603220712.73673-4-Rauch.Christian@gmx.de>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20220603220712.73673-1-Rauch.Christian@gmx.de>", "References": "<20220603220712.73673-1-Rauch.Christian@gmx.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "quoted-printable", "X-Provags-ID": "V03:K1:cw4zqUgiJ3IRKT5gDBzksz74zzYEH3Q2ZoKQNVIYkopkvOgkY6o\n\t1qi+qH15E33vme5Tm9bmx0LNdyRWyBXTP901mqJZe/UQn2HtskB2dHcamVoFiOnCeCE9Kp5\n\tueW/ESE8rm4PFrXx0JZ0fjTh+PyrO0H0NNRks90BLFQFyj//5DxfOzzxwNSa6c6RX2Txsi6\n\toXfCt/f23JQrMdJ0EJ4rg==", "X-Spam-Flag": "NO", "X-UI-Out-Filterresults": "notjunk:1; V03:K0:/XctwigR1yk=:fhY9qK+IjfXVLMFFIoxPKK\n\tXg2WOdLrskF5etJ6absGTWvQtyL/n6eKQCDVjfkYosS3wLrZQkrXbX1BWlX6C8XRbVm5+zi8j\n\tAexWVaWenV01PokjQJnOA63EDITfB7bXgXyKOFVGwSNZOos4MYiWK+jcWKb8sEfizY4XlxVgm\n\t7I7BMCJUc6OeWZ7Y9yV6xUUj42ElV8myABio6T5PGR9IhvsLPVQHq9kEtG/aoXNVEb5bw5aAg\n\txttdCJfkgPpR/+ApnsrVItNzYvDpjfrvjf7RjBAQMJ/vv/ATvua55/bDuHUluRia9Oe2500sj\n\tGXykiNAJcBJOUg3yDZJDbydi1CaR9gJYSwfxaX6Y84E5vHRvhK3VEApGsUt0pZHPy8w0VnSNt\n\tRVF6SVD8UPw5SDVvP9vwAFKSkkeDAOd4vPlrakD17K+n/Pi4mu1GkF/8UD/MZE0oZhgQnseaw\n\tPsXcxM9JQXB6fiE7P87Ya8WObpep74pILVFBn35CUfRTRUNyJdyadnMlkcHNCcOD7MHsahjOV\n\tq694/0oWQwKn7h1DUOblit4VXj6XaqE5yDpizrOazrfuXm3O+E4pn0fs70JFLpOGjxcJoBFgE\n\t7PPQnyRL87eqLfe7a0c228jpP4J/C0j31vimEPFKefZXZAIC1vIokUDv6CANZ2RklQfX4hSjo\n\tw96ViraqlxfaHUacexCkg/n868YtjYOWxe/5ai6LeYUPT5Rr8lnBmejeJ3MShgXNQxTlmEMLD\n\tWKZrMh96fYgOUJKSF0zWYp9ck9ntSS5elMtFnR+lw6X658PEWur87RzDKal8h6dcg14r0PT6y\n\tUoczOUj8LfXK+vz2oM8rGuqbzA2IUDKHH3TWlWcXR7PRFcVLRAeR3Wi+zaUMzQ2pNQ7iZ5vbp\n\tbyxIBdAKiElhm8UQhTQLXLwf92iIzuQpI1fvrExFT9Kp50+NdkyYU1YKYNw7VpAUJ1xk23u+0\n\tFvF3cxr1KiBZ2Q1Qx7T+/RKiLv4VdKfJnszZ4KCUiYwODrIhGtSnjTBGzPU9BXrdm7c9ENs7o\n\t/oMNXRwXaP3J1SA3dCQuic725rKTAJwpNKHVVp+WQzpifO7G0Cq6b8TE5A0HRF9/Ux/wpsDSc\n\t1hmbso2ahduJiGxfWbDxtXLtLWX9wXWWvmkBHjc0BgM2U4nMZU6s4A0Tg==", "Subject": "[libcamera-devel] [PATCH v6 3/5] libcamera: controls: Define size\n\tof array controls as a shape vector", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Christian Rauch via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Christian Rauch <Rauch.Christian@gmx.de>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "This follows the convention in other Tensor APIs. Since all tensors are\nrepresented as a Span with a single dimension, values provided in 'size'\nare interpreted as fixed-size Spans, while an empty array (\"[]\") will be\ninterpreted as variable-sized Span.\n\nSigned-off-by: Christian Rauch <Rauch.Christian@gmx.de>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 4 ++--\n src/libcamera/property_ids.yaml | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)\n\n--\n2.34.1", "diff": "diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex cd1d4512..f707c1f5 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -291,7 +291,7 @@ controls:\n transformation. The 3x3 matrix is stored in conventional reading\n order in an array of 9 floating point values.\n\n- size: [3x3]\n+ size: [3,3]\n\n - ScalerCrop:\n type: Rectangle\n@@ -515,7 +515,7 @@ controls:\n the window where the focal distance for the objects shown in that part\n of the image are closest to the camera.\n\n- size: [n]\n+ size: []\n\n - AfTrigger:\n type: int32_t\ndiff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml\nindex 11b7ebdc..a87485d7 100644\n--- a/src/libcamera/property_ids.yaml\n+++ b/src/libcamera/property_ids.yaml\n@@ -497,7 +497,7 @@ controls:\n\n - PixelArrayOpticalBlackRectangles:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The pixel array region(s) which contain optical black pixels\n considered valid for calibration purposes.\n@@ -592,7 +592,7 @@ controls:\n\n - PixelArrayActiveAreas:\n type: Rectangle\n- size: [n]\n+ size: []\n description: |\n The PixelArrayActiveAreas property defines the (possibly multiple and\n overlapping) portions of the camera sensor readable pixel matrix\n", "prefixes": [ "libcamera-devel", "v6", "3/5" ] }