From patchwork Fri Jun 3 22:07:10 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Rauch X-Patchwork-Id: 16145 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id D71D5C3274 for ; Fri, 3 Jun 2022 22:07:23 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id B03B46563D; Sat, 4 Jun 2022 00:07:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1654294040; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EeWQgfLhGpAGDp0o023SKLoWfKiJi+owpOr8I72O4O+sFrk+cjVHj1rd/CZw3nACY xgRZK6uPM91LHR9j97iCktyFjsL4Er3tggyEl2smtgRBdIinRWeehmOuBmusWwu/Pj zrTw36AISu69srREWfuqxUCu/QHYSum8vrvHOH2sc9l5zK9tYr5QtTOnUDJRGB6bFf SPNVu7U6u0ZziPKG/Ce5n/OgNB7OyL1Q+EiYFaEXrZwEllou/4PommJwEEte4olChp s8bRJBubtzCk44J3gYDH2eNhCzlRyrbcgrR6fLURP9BEpshPMiRyG/7Z3rvYLE6d+e iPQPU5cTxAS2Q== Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CFB836040E for ; Sat, 4 Jun 2022 00:07:16 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=gmx.net header.i=@gmx.net header.b="Qf+jAdp/"; dkim-atps=neutral DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1654294036; bh=zcOLN4jTQsCp6vUKu3Yx2tGvQEPJLyoWBisxOznYHvg=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To:References; b=Qf+jAdp/+SO5ygnFC0bq5Pq+gkxsPezXyKi0/vc0b4r5frQ+26fKotNqwXLE72HA4 ewX5cP6aBGw+KeHHm0JFyvDFcLzyhgv/lJoriiQWoCxT6e5reyteq4q8YFIocjW46C klJ6cYnig1ZvwQVBX5XD0Pa5iEFwvP/Fant0JeYY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from localhost.localdomain ([92.18.80.244]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1Mel7v-1nPHk11ui5-00anMn; Sat, 04 Jun 2022 00:07:16 +0200 To: libcamera-devel@lists.libcamera.org Date: Fri, 3 Jun 2022 23:07:10 +0100 Message-Id: <20220603220712.73673-4-Rauch.Christian@gmx.de> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220603220712.73673-1-Rauch.Christian@gmx.de> References: <20220603220712.73673-1-Rauch.Christian@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:cw4zqUgiJ3IRKT5gDBzksz74zzYEH3Q2ZoKQNVIYkopkvOgkY6o 1qi+qH15E33vme5Tm9bmx0LNdyRWyBXTP901mqJZe/UQn2HtskB2dHcamVoFiOnCeCE9Kp5 ueW/ESE8rm4PFrXx0JZ0fjTh+PyrO0H0NNRks90BLFQFyj//5DxfOzzxwNSa6c6RX2Txsi6 oXfCt/f23JQrMdJ0EJ4rg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1; V03:K0:/XctwigR1yk=:fhY9qK+IjfXVLMFFIoxPKK Xg2WOdLrskF5etJ6absGTWvQtyL/n6eKQCDVjfkYosS3wLrZQkrXbX1BWlX6C8XRbVm5+zi8j AexWVaWenV01PokjQJnOA63EDITfB7bXgXyKOFVGwSNZOos4MYiWK+jcWKb8sEfizY4XlxVgm 7I7BMCJUc6OeWZ7Y9yV6xUUj42ElV8myABio6T5PGR9IhvsLPVQHq9kEtG/aoXNVEb5bw5aAg xttdCJfkgPpR/+ApnsrVItNzYvDpjfrvjf7RjBAQMJ/vv/ATvua55/bDuHUluRia9Oe2500sj GXykiNAJcBJOUg3yDZJDbydi1CaR9gJYSwfxaX6Y84E5vHRvhK3VEApGsUt0pZHPy8w0VnSNt RVF6SVD8UPw5SDVvP9vwAFKSkkeDAOd4vPlrakD17K+n/Pi4mu1GkF/8UD/MZE0oZhgQnseaw PsXcxM9JQXB6fiE7P87Ya8WObpep74pILVFBn35CUfRTRUNyJdyadnMlkcHNCcOD7MHsahjOV q694/0oWQwKn7h1DUOblit4VXj6XaqE5yDpizrOazrfuXm3O+E4pn0fs70JFLpOGjxcJoBFgE 7PPQnyRL87eqLfe7a0c228jpP4J/C0j31vimEPFKefZXZAIC1vIokUDv6CANZ2RklQfX4hSjo w96ViraqlxfaHUacexCkg/n868YtjYOWxe/5ai6LeYUPT5Rr8lnBmejeJ3MShgXNQxTlmEMLD WKZrMh96fYgOUJKSF0zWYp9ck9ntSS5elMtFnR+lw6X658PEWur87RzDKal8h6dcg14r0PT6y UoczOUj8LfXK+vz2oM8rGuqbzA2IUDKHH3TWlWcXR7PRFcVLRAeR3Wi+zaUMzQ2pNQ7iZ5vbp byxIBdAKiElhm8UQhTQLXLwf92iIzuQpI1fvrExFT9Kp50+NdkyYU1YKYNw7VpAUJ1xk23u+0 FvF3cxr1KiBZ2Q1Qx7T+/RKiLv4VdKfJnszZ4KCUiYwODrIhGtSnjTBGzPU9BXrdm7c9ENs7o /oMNXRwXaP3J1SA3dCQuic725rKTAJwpNKHVVp+WQzpifO7G0Cq6b8TE5A0HRF9/Ux/wpsDSc 1hmbso2ahduJiGxfWbDxtXLtLWX9wXWWvmkBHjc0BgM2U4nMZU6s4A0Tg== Subject: [libcamera-devel] [PATCH v6 3/5] libcamera: controls: Define size of array controls as a shape vector X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Christian Rauch via libcamera-devel From: Christian Rauch Reply-To: Christian Rauch Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" This follows the convention in other Tensor APIs. Since all tensors are represented as a Span with a single dimension, values provided in 'size' are interpreted as fixed-size Spans, while an empty array ("[]") will be interpreted as variable-sized Span. Signed-off-by: Christian Rauch Reviewed-by: Jacopo Mondi --- src/libcamera/control_ids.yaml | 4 ++-- src/libcamera/property_ids.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) -- 2.34.1 diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml index cd1d4512..f707c1f5 100644 --- a/src/libcamera/control_ids.yaml +++ b/src/libcamera/control_ids.yaml @@ -291,7 +291,7 @@ controls: transformation. The 3x3 matrix is stored in conventional reading order in an array of 9 floating point values. - size: [3x3] + size: [3,3] - ScalerCrop: type: Rectangle @@ -515,7 +515,7 @@ controls: the window where the focal distance for the objects shown in that part of the image are closest to the camera. - size: [n] + size: [] - AfTrigger: type: int32_t diff --git a/src/libcamera/property_ids.yaml b/src/libcamera/property_ids.yaml index 11b7ebdc..a87485d7 100644 --- a/src/libcamera/property_ids.yaml +++ b/src/libcamera/property_ids.yaml @@ -497,7 +497,7 @@ controls: - PixelArrayOpticalBlackRectangles: type: Rectangle - size: [n] + size: [] description: | The pixel array region(s) which contain optical black pixels considered valid for calibration purposes. @@ -592,7 +592,7 @@ controls: - PixelArrayActiveAreas: type: Rectangle - size: [n] + size: [] description: | The PixelArrayActiveAreas property defines the (possibly multiple and overlapping) portions of the camera sensor readable pixel matrix