Patch Detail
Show a patch.
GET /api/1.1/patches/15993/?format=api
{ "id": 15993, "url": "https://patchwork.libcamera.org/api/1.1/patches/15993/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15993/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220520165234.7642-3-laurent.pinchart@ideasonboard.com>", "date": "2022-05-20T16:52:33", "name": "[libcamera-devel,v2,2/3] cam: Queue requests through CameraSession::queueRequest()", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d8f576df54ce5fbb430a06289f70794ba02f5471", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15993/mbox/", "series": [ { "id": 3131, "url": "https://patchwork.libcamera.org/api/1.1/series/3131/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3131", "date": "2022-05-20T16:52:31", "name": "cam: Add support for capture scripts", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3131/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15993/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15993/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 411EDC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 20 May 2022 16:52:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 463F16566F;\n\tFri, 20 May 2022 18:52:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB20865653\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 20 May 2022 18:52:45 +0200 (CEST)", "from localhost.localdomain (unknown [45.131.31.124])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 669E85A4;\n\tFri, 20 May 2022 18:52:45 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1653065568;\n\tbh=CsJGxDB+lznfsPzdwGWvVrfUxFStto0ILMnvgpVn4XE=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:\n\tFrom;\n\tb=o+fEw79MTc3NPsN2BD23/1pOBfB4m6hDP85LqV/hIsfl0s2r7iAl9EiwSVmyin3OC\n\tNfkIptQc03B4pi9nMxHpmqCkiProJA3WlOMd6Gdp48+k6V6PeWAJUKFvuEGSjEG3ug\n\te/Hbx3mdugL0qaQ3+3FidqHD3jl8pLMGMHc1u7r/BMG4YL5NZt8Kik4+FbIKBsajmZ\n\t3HhLKtVBn/3lEUP23wm7+Y5C316rC1a7qOTsniL8FrNVu421hTvPZvhZORA29w1s/s\n\tJlwZMusP7M+QaVTZIVHULvvS1YAd0yiLyL3yFtXmsRF9a6BEVZIdWrZqxGNhiEDcQx\n\t53f/++9kXy4QA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1653065565;\n\tbh=CsJGxDB+lznfsPzdwGWvVrfUxFStto0ILMnvgpVn4XE=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=H/JkwRSaOGMx3nY0qOYyMm8mV1vV3STbkW0jDCCSYqqhWcaxtHIA+wvINRzeIdRnY\n\tY7nXRE+3J4Oec5qTYvhyKRbZTWRI4Qmscyc19D6P2bD2Yb5UWyp7kNVMoAc/C6MeAe\n\tW+eMMoWHYcVQWJMIEt7+V4m2pgFsRC7aP4hx+n2E=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"H/JkwRSa\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 20 May 2022 19:52:33 +0300", "Message-Id": "<20220520165234.7642-3-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220520165234.7642-1-laurent.pinchart@ideasonboard.com>", "References": "<20220520165234.7642-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 2/3] cam: Queue requests through\n\tCameraSession::queueRequest()", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo@jmondi.org>\n\nThe CameraSession::processRequest() frame completion handler currently\nre-queues completed requests by calling Camera::queueRequests()\nexplicitely.\n\nIn order to maintain the CameraSession::queuedRequest_ counter up to\ndate with the actual number of queued requests, call the\nCameraSession::queueRequest() instead of operating the Camera directly.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/camera_session.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp\nindex efffafbf9e9a..0bb95c8bf682 100644\n--- a/src/cam/camera_session.cpp\n+++ b/src/cam/camera_session.cpp\n@@ -418,7 +418,7 @@ void CameraSession::processRequest(Request *request)\n \t\treturn;\n \n \trequest->reuse(Request::ReuseBuffers);\n-\tcamera_->queueRequest(request);\n+\tqueueRequest(request);\n }\n \n void CameraSession::sinkRelease(Request *request)\n", "prefixes": [ "libcamera-devel", "v2", "2/3" ] }