From patchwork Fri May 20 16:52:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15993 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 411EDC3256 for ; Fri, 20 May 2022 16:52:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 463F16566F; Fri, 20 May 2022 18:52:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1653065568; bh=CsJGxDB+lznfsPzdwGWvVrfUxFStto0ILMnvgpVn4XE=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=o+fEw79MTc3NPsN2BD23/1pOBfB4m6hDP85LqV/hIsfl0s2r7iAl9EiwSVmyin3OC NfkIptQc03B4pi9nMxHpmqCkiProJA3WlOMd6Gdp48+k6V6PeWAJUKFvuEGSjEG3ug e/Hbx3mdugL0qaQ3+3FidqHD3jl8pLMGMHc1u7r/BMG4YL5NZt8Kik4+FbIKBsajmZ 3HhLKtVBn/3lEUP23wm7+Y5C316rC1a7qOTsniL8FrNVu421hTvPZvhZORA29w1s/s JlwZMusP7M+QaVTZIVHULvvS1YAd0yiLyL3yFtXmsRF9a6BEVZIdWrZqxGNhiEDcQx 53f/++9kXy4QA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CB20865653 for ; Fri, 20 May 2022 18:52:45 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="H/JkwRSa"; dkim-atps=neutral Received: from localhost.localdomain (unknown [45.131.31.124]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 669E85A4; Fri, 20 May 2022 18:52:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1653065565; bh=CsJGxDB+lznfsPzdwGWvVrfUxFStto0ILMnvgpVn4XE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=H/JkwRSaOGMx3nY0qOYyMm8mV1vV3STbkW0jDCCSYqqhWcaxtHIA+wvINRzeIdRnY Y7nXRE+3J4Oec5qTYvhyKRbZTWRI4Qmscyc19D6P2bD2Yb5UWyp7kNVMoAc/C6MeAe W+eMMoWHYcVQWJMIEt7+V4m2pgFsRC7aP4hx+n2E= To: libcamera-devel@lists.libcamera.org Date: Fri, 20 May 2022 19:52:33 +0300 Message-Id: <20220520165234.7642-3-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220520165234.7642-1-laurent.pinchart@ideasonboard.com> References: <20220520165234.7642-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 2/3] cam: Queue requests through CameraSession::queueRequest() X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" From: Jacopo Mondi The CameraSession::processRequest() frame completion handler currently re-queues completed requests by calling Camera::queueRequests() explicitely. In order to maintain the CameraSession::queuedRequest_ counter up to date with the actual number of queued requests, call the CameraSession::queueRequest() instead of operating the Camera directly. Signed-off-by: Jacopo Mondi Reviewed-by: Laurent Pinchart --- src/cam/camera_session.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/cam/camera_session.cpp b/src/cam/camera_session.cpp index efffafbf9e9a..0bb95c8bf682 100644 --- a/src/cam/camera_session.cpp +++ b/src/cam/camera_session.cpp @@ -418,7 +418,7 @@ void CameraSession::processRequest(Request *request) return; request->reuse(Request::ReuseBuffers); - camera_->queueRequest(request); + queueRequest(request); } void CameraSession::sinkRelease(Request *request)