Patch Detail
Show a patch.
GET /api/1.1/patches/15857/?format=api
{ "id": 15857, "url": "https://patchwork.libcamera.org/api/1.1/patches/15857/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15857/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220510115147.19360-18-laurent.pinchart@ideasonboard.com>", "date": "2022-05-10T11:51:14", "name": "[libcamera-devel,17/50] staging: media: imx: imx7-media-csi: Don't set subdev group id", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": false, "hash": "2e6dc4a52118f796eb692ff0c6e658f5b6892be0", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15857/mbox/", "series": [ { "id": 3106, "url": "https://patchwork.libcamera.org/api/1.1/series/3106/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3106", "date": "2022-05-10T11:50:57", "name": "staging: media: imx: Prepare destaging of imx7-media-csi", "version": 1, "mbox": "https://patchwork.libcamera.org/series/3106/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15857/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15857/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4CC50C3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 10 May 2022 11:52:21 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E966B6564F;\n\tTue, 10 May 2022 13:52:20 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF9556566E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 May 2022 13:52:11 +0200 (CEST)", "from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D6DC4824;\n\tTue, 10 May 2022 13:52:10 +0200 (CEST)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1652183541;\n\tbh=2nqqOrgtxjxD2pNMktw8yQmUenswVmx0ziFCRdrpaxQ=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZZ7hwin7xT8VovCocBUv5ifZjyyUzmMEE3OLY4cXbRmN7lI9QRZF/HMc4O349yhMn\n\tJkv4fdKw/Gweg5o6f5UwBztU2KErfWQm/wpk1+H3rve7Rj1Q8WviIMTmY8vPRbhNPw\n\tJub9wzQ1z2JkjfJJkOUdpCsMV9MbbsIX+SXJZyr5n5UYzRXJikHcbUC3GPtE90jogB\n\ttlcum99qOATIK7ASpJg0Zl/pZo0TrH9yWP/wXoI8TCPwIIUFey5VJXMPAXfGj6So4S\n\tinB9wgC+KIATpsVJbUmMBywq/VB7Pz5g1gWDWxUSl1e06ACaF5hO6TQ+IhbevlQI+E\n\tDRnQwhk4HU3FA==", "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1652183531;\n\tbh=2nqqOrgtxjxD2pNMktw8yQmUenswVmx0ziFCRdrpaxQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=i2W1m6aNPQk7K4VeHDm8MksObo7T2kcevK/6wltfC48DmoziQUCchCjP4KXDk7gVS\n\tME+pvn+qf6YvQlQyN9gCa09Y86gddzqvYEHCQKWJrP3QppG7CrMEDOKBO12j8bTq+a\n\tMvkm2NFnt6eiJvUnx+U6DlW84AcFMAf+J8BdXXnE=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=ideasonboard.com\n\theader.i=@ideasonboard.com\n\theader.b=\"i2W1m6aN\"; dkim-atps=neutral", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 10 May 2022 14:51:14 +0300", "Message-Id": "<20220510115147.19360-18-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.35.1", "In-Reply-To": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "References": "<20220510115147.19360-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 17/50] staging: media: imx:\n\timx7-media-csi: Don't set subdev group id", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Laurent Pinchart via libcamera-devel\n\t<libcamera-devel@lists.libcamera.org>", "Reply-To": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "Cc": "Martin Kepplinger <martin.kepplinger@puri.sm>, kernel@pengutronix.de,\n\tDorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,\n\tAlexander Stein <alexander.stein@ew.tq-group.com>,\n\tRui Miguel Silva <rmfrfs@gmail.com>,\n\tPhilipp Zabel <p.zabel@pengutronix.de>, \n\tSteve Longerbeam <slongerbeam@gmail.com>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The subdev group id isn't used by any of the remaining helpers used by\nthis driver, don't set it.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n drivers/staging/media/imx/imx7-media-csi.c | 7 -------\n 1 file changed, 7 deletions(-)", "diff": "diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c\nindex 80d666416d47..bd1bdc09e701 100644\n--- a/drivers/staging/media/imx/imx7-media-csi.c\n+++ b/drivers/staging/media/imx/imx7-media-csi.c\n@@ -1749,13 +1749,6 @@ static int imx7_csi_notify_bound(struct v4l2_async_notifier *notifier,\n \tstruct imx7_csi *csi = imx7_csi_notifier_to_dev(notifier);\n \tstruct media_pad *sink = &csi->sd.entity.pads[IMX7_CSI_PAD_SINK];\n \n-\t/*\n-\t * If the subdev is a video mux, it must be one of the CSI\n-\t * muxes. Mark it as such via its group id.\n-\t */\n-\tif (sd->entity.function == MEDIA_ENT_F_VID_MUX)\n-\t\tsd->grp_id = IMX_MEDIA_GRP_ID_CSI_MUX;\n-\n \tcsi->src_sd = sd;\n \n \treturn v4l2_create_fwnode_links_to_pad(sd, sink, MEDIA_LNK_FL_ENABLED |\n", "prefixes": [ "libcamera-devel", "17/50" ] }