From patchwork Tue May 10 11:51:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 15857 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 4CC50C3256 for ; Tue, 10 May 2022 11:52:21 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id E966B6564F; Tue, 10 May 2022 13:52:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1652183541; bh=2nqqOrgtxjxD2pNMktw8yQmUenswVmx0ziFCRdrpaxQ=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZZ7hwin7xT8VovCocBUv5ifZjyyUzmMEE3OLY4cXbRmN7lI9QRZF/HMc4O349yhMn Jkv4fdKw/Gweg5o6f5UwBztU2KErfWQm/wpk1+H3rve7Rj1Q8WviIMTmY8vPRbhNPw Jub9wzQ1z2JkjfJJkOUdpCsMV9MbbsIX+SXJZyr5n5UYzRXJikHcbUC3GPtE90jogB tlcum99qOATIK7ASpJg0Zl/pZo0TrH9yWP/wXoI8TCPwIIUFey5VJXMPAXfGj6So4S inB9wgC+KIATpsVJbUmMBywq/VB7Pz5g1gWDWxUSl1e06ACaF5hO6TQ+IhbevlQI+E DRnQwhk4HU3FA== Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id AF9556566E for ; Tue, 10 May 2022 13:52:11 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="i2W1m6aN"; dkim-atps=neutral Received: from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D6DC4824; Tue, 10 May 2022 13:52:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1652183531; bh=2nqqOrgtxjxD2pNMktw8yQmUenswVmx0ziFCRdrpaxQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i2W1m6aNPQk7K4VeHDm8MksObo7T2kcevK/6wltfC48DmoziQUCchCjP4KXDk7gVS ME+pvn+qf6YvQlQyN9gCa09Y86gddzqvYEHCQKWJrP3QppG7CrMEDOKBO12j8bTq+a Mvkm2NFnt6eiJvUnx+U6DlW84AcFMAf+J8BdXXnE= To: libcamera-devel@lists.libcamera.org Date: Tue, 10 May 2022 14:51:14 +0300 Message-Id: <20220510115147.19360-18-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> References: <20220510115147.19360-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 17/50] staging: media: imx: imx7-media-csi: Don't set subdev group id X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Laurent Pinchart via libcamera-devel From: Laurent Pinchart Reply-To: Laurent Pinchart Cc: Martin Kepplinger , kernel@pengutronix.de, Dorota Czaplejewicz , Alexander Stein , Rui Miguel Silva , Philipp Zabel , Steve Longerbeam Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The subdev group id isn't used by any of the remaining helpers used by this driver, don't set it. Signed-off-by: Laurent Pinchart --- drivers/staging/media/imx/imx7-media-csi.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c b/drivers/staging/media/imx/imx7-media-csi.c index 80d666416d47..bd1bdc09e701 100644 --- a/drivers/staging/media/imx/imx7-media-csi.c +++ b/drivers/staging/media/imx/imx7-media-csi.c @@ -1749,13 +1749,6 @@ static int imx7_csi_notify_bound(struct v4l2_async_notifier *notifier, struct imx7_csi *csi = imx7_csi_notifier_to_dev(notifier); struct media_pad *sink = &csi->sd.entity.pads[IMX7_CSI_PAD_SINK]; - /* - * If the subdev is a video mux, it must be one of the CSI - * muxes. Mark it as such via its group id. - */ - if (sd->entity.function == MEDIA_ENT_F_VID_MUX) - sd->grp_id = IMX_MEDIA_GRP_ID_CSI_MUX; - csi->src_sd = sd; return v4l2_create_fwnode_links_to_pad(sd, sink, MEDIA_LNK_FL_ENABLED |