Patch Detail
Show a patch.
GET /api/1.1/patches/15714/?format=api
{ "id": 15714, "url": "https://patchwork.libcamera.org/api/1.1/patches/15714/?format=api", "web_url": "https://patchwork.libcamera.org/patch/15714/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20220426090029.1350103-2-chenghaoyang@chromium.org>", "date": "2022-04-26T09:00:26", "name": "[libcamera-devel,v2,1/4] Allow inheritance of FrameBuffer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d78749ed8f4bce5d76dcf6ebd520776e9ce97bdb", "submitter": { "id": 117, "url": "https://patchwork.libcamera.org/api/1.1/people/117/?format=api", "name": "Cheng-Hao Yang", "email": "chenghaoyang@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/15714/mbox/", "series": [ { "id": 3070, "url": "https://patchwork.libcamera.org/api/1.1/series/3070/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=3070", "date": "2022-04-26T09:00:25", "name": "Add CrOS JEA implementation", "version": 2, "mbox": "https://patchwork.libcamera.org/series/3070/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/15714/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/15714/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCADBC3256\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 26 Apr 2022 09:01:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 71F6D65642;\n\tTue, 26 Apr 2022 11:01:16 +0200 (CEST)", "from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com\n\t[IPv6:2607:f8b0:4864:20::62c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D2FE60431\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Apr 2022 11:01:14 +0200 (CEST)", "by mail-pl1-x62c.google.com with SMTP id j8so29590086pll.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 26 Apr 2022 02:01:14 -0700 (PDT)", "from chenghaoyang.c.googlers.com.com\n\t(93.135.240.35.bc.googleusercontent.com. [35.240.135.93])\n\tby smtp.gmail.com with ESMTPSA id\n\tc18-20020a056a000ad200b004cdccd3da08sm15449379pfl.44.2022.04.26.02.01.11\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 26 Apr 2022 02:01:12 -0700 (PDT)" ], "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org;\n\ts=mail; t=1650963676;\n\tbh=lzcCD/wUuwv9amQ1ylMz9Bi3mQNyfX9OQ+yx4ldhW/8=;\n\th=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe:\n\tList-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc:\n\tFrom;\n\tb=ZG/KpiTRmAgZdoegMOuLR3kX9L3/lmYEf+lYIcOY8qJ8h7O1tCOIW4gGjv4JiCtpK\n\tRGnbzi1XSCFlWgXZHTD2QD/tZkdrnzcDauOTXXCvTEeaTAhv7dk86TGRWaWnRrsPgh\n\thwST2B+4eIiJFC5MVh2M3PKThvmYmJ7M9Ld5YoXy9XfU7WRlEs2BpXXBAwqmQJQ/+h\n\tOytGz7LiGadq6Y/kuUXdkRHFIPY7cXBbQq/iMrJwzdbDPbWJWBw4zhzMDv6+DDFfr/\n\tkBnQGkVzoF62DYuYo+iyImAbZxJ7xxDMHKiUvHzi1FAliN/vZDtTN27SsKkCrREeGk\n\t6IltTaT7PfyhA==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=dpOE5Q0DYLJGXkGvveo9hJL3T4KTOzV101WGZGY0tB0=;\n\tb=gQbUkVlR4bkfjATs/1Y5a+HyqRkLaM7ecupDDxE81gkq4AhZ21Q24dZZpkc3wL5FGU\n\ti46GscLyNlCIIowkRACUd1y38IBpaM/R2t+Zol87ccjc5cGHWZBJl8nf6Uiu02WDVIsg\n\tTaUctbharxDBbZ71qkgz5Em0LFmSS0BR8fVds=" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key; \n\tunprotected) header.d=chromium.org\n\theader.i=@chromium.org header.b=\"gQbUkVlR\"; \n\tdkim-atps=neutral", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=dpOE5Q0DYLJGXkGvveo9hJL3T4KTOzV101WGZGY0tB0=;\n\tb=pLgI3/T8xN0hT7iGiT+SBCy/MTtiegok4J0PUVMStwuK4igO3WmQj7cr+68WF/ES3F\n\t1AWxyDQ1bxdQ262St086zYi9JPOZvDxeO+6EqVXZHYzwha/idJ9D4a56u/udCXJmuD8H\n\t+t6OlEXw6flk//l8Gt4TO0JYBzwNn/KdT8EiK4zTXtQplJF4FiQWV1nByxQ7mDc0T7Ps\n\tbekr4w9sbVknkLJbAy+nCC8eJCxq+gD1kj6HxIqqYAVhfDK0sPGzUFodjDXfBTIRQSYy\n\tNCn8Sc9Nlh/GaN8pWsg+vykZyvsag0XCEyofC6RwurOiIcdZa31jH/91HFdPcsXRXgut\n\tNXqw==", "X-Gm-Message-State": "AOAM531IpI64E1ek6UPJvMblpGARMpivRuN6ZQ+D/mKUXdbUy+YLZxmj\n\t3/PSqt9NLC7KQZPLikfO5B7lPt+rBCuwnzPz", "X-Google-Smtp-Source": "ABdhPJyqhe9Dl/TDu+799DQpfIGIySKNSHAmerpP2wcWqLnL2rwA8OruzbiS5Th1P8VcCwgc+bQbvA==", "X-Received": "by 2002:a17:902:82c9:b0:15d:3a76:936f with SMTP id\n\tu9-20020a17090282c900b0015d3a76936fmr1358786plz.139.1650963672670; \n\tTue, 26 Apr 2022 02:01:12 -0700 (PDT)", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 26 Apr 2022 09:00:26 +0000", "Message-Id": "<20220426090029.1350103-2-chenghaoyang@chromium.org>", "X-Mailer": "git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog", "In-Reply-To": "<20220426090029.1350103-1-chenghaoyang@chromium.org>", "References": "<20220426090029.1350103-1-chenghaoyang@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/4] Allow inheritance of FrameBuffer", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "From": "Harvey Yang via libcamera-devel <libcamera-devel@lists.libcamera.org>", "Reply-To": "Harvey Yang <chenghaoyang@chromium.org>", "Cc": "Harvey Yang <chenghaoyang@chromium.org>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To add buffer_handle_t access in android, this CL allows inheritance of\nFrameBuffer to add a derived class in android.\n---\n include/libcamera/framebuffer.h | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h\nindex 3b1118d1..e6c769b4 100644\n--- a/include/libcamera/framebuffer.h\n+++ b/include/libcamera/framebuffer.h\n@@ -46,7 +46,7 @@ private:\n \tstd::vector<Plane> planes_;\n };\n \n-class FrameBuffer final : public Extensible\n+class FrameBuffer : public Extensible\n {\n \tLIBCAMERA_DECLARE_PRIVATE()\n \n@@ -61,6 +61,7 @@ public:\n \tFrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);\n \tFrameBuffer(std::unique_ptr<Private> d,\n \t\t const std::vector<Plane> &planes, unsigned int cookie = 0);\n+\tvirtual ~FrameBuffer() {}\n \n \tconst std::vector<Plane> &planes() const { return planes_; }\n \tRequest *request() const;\n", "prefixes": [ "libcamera-devel", "v2", "1/4" ] }