From patchwork Tue Apr 26 09:00:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cheng-Hao Yang X-Patchwork-Id: 15714 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id BCADBC3256 for ; Tue, 26 Apr 2022 09:01:16 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 71F6D65642; Tue, 26 Apr 2022 11:01:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=libcamera.org; s=mail; t=1650963676; bh=lzcCD/wUuwv9amQ1ylMz9Bi3mQNyfX9OQ+yx4ldhW/8=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ZG/KpiTRmAgZdoegMOuLR3kX9L3/lmYEf+lYIcOY8qJ8h7O1tCOIW4gGjv4JiCtpK RGnbzi1XSCFlWgXZHTD2QD/tZkdrnzcDauOTXXCvTEeaTAhv7dk86TGRWaWnRrsPgh hwST2B+4eIiJFC5MVh2M3PKThvmYmJ7M9Ld5YoXy9XfU7WRlEs2BpXXBAwqmQJQ/+h OytGz7LiGadq6Y/kuUXdkRHFIPY7cXBbQq/iMrJwzdbDPbWJWBw4zhzMDv6+DDFfr/ kBnQGkVzoF62DYuYo+iyImAbZxJ7xxDMHKiUvHzi1FAliN/vZDtTN27SsKkCrREeGk 6IltTaT7PfyhA== Received: from mail-pl1-x62c.google.com (mail-pl1-x62c.google.com [IPv6:2607:f8b0:4864:20::62c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D2FE60431 for ; Tue, 26 Apr 2022 11:01:14 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=pass (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="gQbUkVlR"; dkim-atps=neutral Received: by mail-pl1-x62c.google.com with SMTP id j8so29590086pll.11 for ; Tue, 26 Apr 2022 02:01:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dpOE5Q0DYLJGXkGvveo9hJL3T4KTOzV101WGZGY0tB0=; b=gQbUkVlR4bkfjATs/1Y5a+HyqRkLaM7ecupDDxE81gkq4AhZ21Q24dZZpkc3wL5FGU i46GscLyNlCIIowkRACUd1y38IBpaM/R2t+Zol87ccjc5cGHWZBJl8nf6Uiu02WDVIsg TaUctbharxDBbZ71qkgz5Em0LFmSS0BR8fVds= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dpOE5Q0DYLJGXkGvveo9hJL3T4KTOzV101WGZGY0tB0=; b=pLgI3/T8xN0hT7iGiT+SBCy/MTtiegok4J0PUVMStwuK4igO3WmQj7cr+68WF/ES3F 1AWxyDQ1bxdQ262St086zYi9JPOZvDxeO+6EqVXZHYzwha/idJ9D4a56u/udCXJmuD8H +t6OlEXw6flk//l8Gt4TO0JYBzwNn/KdT8EiK4zTXtQplJF4FiQWV1nByxQ7mDc0T7Ps bekr4w9sbVknkLJbAy+nCC8eJCxq+gD1kj6HxIqqYAVhfDK0sPGzUFodjDXfBTIRQSYy NCn8Sc9Nlh/GaN8pWsg+vykZyvsag0XCEyofC6RwurOiIcdZa31jH/91HFdPcsXRXgut NXqw== X-Gm-Message-State: AOAM531IpI64E1ek6UPJvMblpGARMpivRuN6ZQ+D/mKUXdbUy+YLZxmj 3/PSqt9NLC7KQZPLikfO5B7lPt+rBCuwnzPz X-Google-Smtp-Source: ABdhPJyqhe9Dl/TDu+799DQpfIGIySKNSHAmerpP2wcWqLnL2rwA8OruzbiS5Th1P8VcCwgc+bQbvA== X-Received: by 2002:a17:902:82c9:b0:15d:3a76:936f with SMTP id u9-20020a17090282c900b0015d3a76936fmr1358786plz.139.1650963672670; Tue, 26 Apr 2022 02:01:12 -0700 (PDT) Received: from chenghaoyang.c.googlers.com.com (93.135.240.35.bc.googleusercontent.com. [35.240.135.93]) by smtp.gmail.com with ESMTPSA id c18-20020a056a000ad200b004cdccd3da08sm15449379pfl.44.2022.04.26.02.01.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Apr 2022 02:01:12 -0700 (PDT) To: libcamera-devel@lists.libcamera.org Date: Tue, 26 Apr 2022 09:00:26 +0000 Message-Id: <20220426090029.1350103-2-chenghaoyang@chromium.org> X-Mailer: git-send-email 2.36.0.rc2.479.g8af0fa9b8e-goog In-Reply-To: <20220426090029.1350103-1-chenghaoyang@chromium.org> References: <20220426090029.1350103-1-chenghaoyang@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v2 1/4] Allow inheritance of FrameBuffer X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Harvey Yang via libcamera-devel From: Cheng-Hao Yang Reply-To: Harvey Yang Cc: Harvey Yang Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" To add buffer_handle_t access in android, this CL allows inheritance of FrameBuffer to add a derived class in android. --- include/libcamera/framebuffer.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h index 3b1118d1..e6c769b4 100644 --- a/include/libcamera/framebuffer.h +++ b/include/libcamera/framebuffer.h @@ -46,7 +46,7 @@ private: std::vector planes_; }; -class FrameBuffer final : public Extensible +class FrameBuffer : public Extensible { LIBCAMERA_DECLARE_PRIVATE() @@ -61,6 +61,7 @@ public: FrameBuffer(const std::vector &planes, unsigned int cookie = 0); FrameBuffer(std::unique_ptr d, const std::vector &planes, unsigned int cookie = 0); + virtual ~FrameBuffer() {} const std::vector &planes() const { return planes_; } Request *request() const;