Patch Detail
Show a patch.
GET /api/1.1/patches/14992/?format=api
{ "id": 14992, "url": "https://patchwork.libcamera.org/api/1.1/patches/14992/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14992/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211202140317.3118364-5-hanlinchen@chromium.org>", "date": "2021-12-02T14:03:16", "name": "[libcamera-devel,v7,4/5] libcamera: camera_lens: add CameraLens as a member of CameraSensor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "37c6deee69dff807d5e589c59f9fe693e4a3eb9a", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/1.1/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14992/mbox/", "series": [ { "id": 2804, "url": "https://patchwork.libcamera.org/api/1.1/series/2804/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2804", "date": "2021-12-02T14:03:12", "name": "Introduce Lens class and apply auto focus on ipu3", "version": 7, "mbox": "https://patchwork.libcamera.org/series/2804/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14992/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14992/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB693BF415\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 2 Dec 2021 14:03:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8F62E60862;\n\tThu, 2 Dec 2021 15:03:35 +0100 (CET)", "from mail-pf1-x433.google.com (mail-pf1-x433.google.com\n\t[IPv6:2607:f8b0:4864:20::433])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1A0DD605B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 2 Dec 2021 15:03:34 +0100 (CET)", "by mail-pf1-x433.google.com with SMTP id n85so27982700pfd.10\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 02 Dec 2021 06:03:34 -0800 (PST)", "from localhost ([2401:fa00:1:10:9029:d68:4045:e723])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tf2sm3878134pfe.132.2021.12.02.06.03.31\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tThu, 02 Dec 2021 06:03:32 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"AXUwuHgD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=2McPthkXJ9/lLtflTowN3HeopjV9PW8uYtzgNugHnu8=;\n\tb=AXUwuHgD8Mfqs+jXkcBMD97qPt/N9BCQ0QSO7IqzTJgrRpJCvFWnEH/IsHYZqfvLG4\n\tuqpT7cwYEg6o7GrETg8YN7o23HXTRDd3dbHiJI0EN44UYJsyjXQ3dcF/zuRI6rrVfb52\n\t6zKq3s56lA5lJds+sbVJhP3gue39/KHNbPPbE=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=2McPthkXJ9/lLtflTowN3HeopjV9PW8uYtzgNugHnu8=;\n\tb=1olzYpaonjlWOI3vxtgLfFC8GSYaUAtDqxeFxJby8CgaTt3EMLFfdWIfiE4deQNMBk\n\tb427GhtL4YA7fAJ0SVklhTHQvamLcgq6izgNZC/IJ1oBqvJyBc7aPg6nFvKrsQHuROkZ\n\toZnB8KcIp92/79c0u2jdiml7xO5BMaEuaAw+36FuhEpjzMOtyW1ek7R8lgB6xFFTOEIL\n\tRidyOmjUBCoyCQcFWDRcnRo0yaJkg9L+exl3GKoGd5CihX2usoEDzawFCsIUHhaBEKcy\n\t28FBC/IrIQeFkMzqR3LFckLfHBYuZKL3OmJjKT6jMMbBvNlR1c8IWpi2tplNJK6DWI3X\n\teI6A==", "X-Gm-Message-State": "AOAM533a8r3U5A2C+CZYsiJIDL6uP7NHMfBS8aIXPoZUQuXJPugoFl6q\n\tlm6IyllgArEXy6WbFCZhyJQCgY2V4S5M+A==", "X-Google-Smtp-Source": "ABdhPJwasaRNLRu9/L82wW5C6ikqUxfHmYyvBGtCsOW9rgCL1+yTNqQh3JKeTQzykMMqPVMoV3Gu0A==", "X-Received": "by 2002:a65:4cc1:: with SMTP id n1mr9710857pgt.420.1638453812374;\n\tThu, 02 Dec 2021 06:03:32 -0800 (PST)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 2 Dec 2021 22:03:16 +0800", "Message-Id": "<20211202140317.3118364-5-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.34.1.400.ga245620fadb-goog", "In-Reply-To": "<20211202140317.3118364-1-hanlinchen@chromium.org>", "References": "<20211202140317.3118364-1-hanlinchen@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v7 4/5] libcamera: camera_lens: add\n\tCameraLens as a member of CameraSensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add CameraLens as a member of CameraSenosr. The patch does not implement how\nto link the lens to the specific sensor yet. Only to provide an interface for\npipeline handler's usage.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n include/libcamera/internal/camera_sensor.h | 5 +++++\n src/libcamera/camera_sensor.cpp | 8 ++++++++\n 2 files changed, 13 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex d25a1165..8e97a80e 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -24,6 +24,7 @@\n namespace libcamera {\n \n class BayerFormat;\n+class CameraLens;\n class MediaEntity;\n \n class CameraSensor : protected Loggable\n@@ -60,6 +61,8 @@ public:\n \n \tvoid updateControlInfo();\n \n+\tCameraLens *lens() { return lens_.get(); }\n+\n protected:\n \tstd::string logPrefix() const override;\n \n@@ -91,6 +94,8 @@ private:\n \tconst BayerFormat *bayerFormat_;\n \n \tControlList properties_;\n+\n+\tstd::unique_ptr<CameraLens> lens_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 6151b32e..b386e7b0 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -20,6 +20,7 @@\n #include <libcamera/base/utils.h>\n \n #include \"libcamera/internal/bayer_format.h\"\n+#include \"libcamera/internal/camera_lens.h\"\n #include \"libcamera/internal/camera_sensor_properties.h\"\n #include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/sysfs.h\"\n@@ -787,6 +788,13 @@ void CameraSensor::updateControlInfo()\n \tsubdev_->updateControlInfo();\n }\n \n+/**\n+ * \\fn CameraSensor::lens()\n+ * \\brief Retrieve the lens controller\n+ *\n+ * \\return The lens controller. nullptr if no lens is connected to the sensor\n+ */\n+\n std::string CameraSensor::logPrefix() const\n {\n \treturn \"'\" + entity_->name() + \"'\";\n", "prefixes": [ "libcamera-devel", "v7", "4/5" ] }