Patch Detail
Show a patch.
GET /api/1.1/patches/14418/?format=api
{ "id": 14418, "url": "https://patchwork.libcamera.org/api/1.1/patches/14418/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14418/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211029120001.2469018-1-hanlinchen@chromium.org>", "date": "2021-10-29T11:59:56", "name": "[libcamera-devel,v2,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "35283964bcb66bd71089c6b8d35a7c4da5597353", "submitter": { "id": 98, "url": "https://patchwork.libcamera.org/api/1.1/people/98/?format=api", "name": "Hanlin Chen", "email": "hanlinchen@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14418/mbox/", "series": [ { "id": 2681, "url": "https://patchwork.libcamera.org/api/1.1/series/2681/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2681", "date": "2021-10-29T11:59:56", "name": "[libcamera-devel,v2,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ", "version": 2, "mbox": "https://patchwork.libcamera.org/series/2681/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14418/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14418/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E5C0DBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 29 Oct 2021 12:00:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A7403600BF;\n\tFri, 29 Oct 2021 14:00:10 +0200 (CEST)", "from mail-pg1-x52c.google.com (mail-pg1-x52c.google.com\n\t[IPv6:2607:f8b0:4864:20::52c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7A6FD600B8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Oct 2021 14:00:09 +0200 (CEST)", "by mail-pg1-x52c.google.com with SMTP id j9so1543267pgh.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 29 Oct 2021 05:00:09 -0700 (PDT)", "from localhost ([2401:fa00:1:10:35fe:d53b:684:b538])\n\tby smtp.gmail.com with UTF8SMTPSA id\n\tn9sm11587805pjk.3.2021.10.29.05.00.03\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 29 Oct 2021 05:00:04 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"mORXNa/D\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; h=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tR9zsB15kCVtnpZ46suSVvmTtEQhG1D1AqAr7QKKInw=;\n\tb=mORXNa/DrBx60QPYtycNOWjs6W9c+t9QJayhB6FQgv109VAcp3RCjXXaq05IGkbIQC\n\tnCckyX/lREnWuZI+EUEBmawL+9NEHd/tSiyuHvZK7BzSCuShbHy3AedoQz0oKsgDHOp9\n\tSbCsYdPuxQuwY5aXTa74oi/YCafPO9tl2NllY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=tR9zsB15kCVtnpZ46suSVvmTtEQhG1D1AqAr7QKKInw=;\n\tb=XQ33bYaVB2BmOFUr+CFG9x9VKE+1fmgwrzWJoNt1Y4jwbXth5zZcNJcA2ulSaICdvj\n\tkktihtBt8rKCJaIUmo0rXIDut6YHgnGRhjBv40sYnONtQxxPs83IN6tQH/kFIhSAvAhh\n\tRNEjbGMtDFM4loM0LP0JHQMgCOpToLqFWXPWRy89fdUxACBq+DcLcDE+aeg10m8YBUuu\n\tvPJAIGALESSbfe7YxtwuHbtnntWH3KNyLUIbDG1g05QAgtqWBpR3/t/0Kw1VI2CJj24d\n\twbJp9FcR0E+3qCfYgNJ1ew6/U7GLbQW9PNu/vV4FS2FLFUyM2nfvndYx1G52YWOnQJrt\n\tPmBA==", "X-Gm-Message-State": "AOAM530Q4bNAMPjKr1CcHglLBoIeDd9W6VUp6Vg2cixQqXJNKa9MhdK5\n\teJZLwP86DkgEHFHtNTGz5bQW5nDv+fV3vovz", "X-Google-Smtp-Source": "ABdhPJwAtpqTFc/Pl7w6Ca+/i6M99yTY2JQRWdo11JggqePFODD5+qFQNfyA46vcOgtekXGF/tVSNA==", "X-Received": "by 2002:a63:9554:: with SMTP id\n\tt20mr7760818pgn.255.1635508804735; \n\tFri, 29 Oct 2021 05:00:04 -0700 (PDT)", "From": "Han-Lin Chen <hanlinchen@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 29 Oct 2021 19:59:56 +0800", "Message-Id": "<20211029120001.2469018-1-hanlinchen@chromium.org>", "X-Mailer": "git-send-email 2.33.1.1089.g2158813163f-goog", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v2 1/6] ipu3: Use ia_aiq_frame_use_preview\n\tas default mode for AIQ", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The frame use mode is set according to Android Capture Intent in Intel\nHAL's implememtation. The current default mode ia_aiq_frame_use_still is\nonly used with the single capture request. For preview use case, it has\nhard time converging AE and AF smoothly. Change the default mode to\nia_aiq_frame_use_preview for better user experience.\n\nSigned-off-by: Han-Lin Chen <hanlinchen@chromium.org>\n---\n aiq/aiq_input_parameters.cpp | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp\nindex 36e2b07..bc87b31 100644\n--- a/aiq/aiq_input_parameters.cpp\n+++ b/aiq/aiq_input_parameters.cpp\n@@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n {\n \t/*Ae Params */\n \taeInputParams.num_exposures = NUM_EXPOSURES;\n-\taeInputParams.frame_use = ia_aiq_frame_use_still;\n+\taeInputParams.frame_use = ia_aiq_frame_use_preview;\n \taeInputParams.flash_mode = ia_aiq_flash_mode_off;\n \taeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic;\n \taeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative;\n@@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \taeInputParams.manual_convergence_time = -1;\n \n \t/* AWB Params */\n-\tawbParams.frame_use = ia_aiq_frame_use_still;\n+\tawbParams.frame_use = ia_aiq_frame_use_preview;\n \tawbParams.scene_mode = ia_aiq_awb_operation_mode_auto;\n \tawbParams.manual_convergence_time = -1.0;\n \tawbParams.manual_cct_range = nullptr;\n@@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \n \t/* AF Params */\n \tafParams = {\n-\t\tia_aiq_frame_use_still, 0, 1500,\n+\t\tia_aiq_frame_use_preview, 0, 1500,\n \t\tia_aiq_af_operation_mode_auto,\n \t\tia_aiq_af_range_normal,\n \t\tia_aiq_af_metering_mode_auto,\n@@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults()\n \t/* GBCE Params */\n \tgbceParams.gbce_level = ia_aiq_gbce_level_bypass;\n \tgbceParams.tone_map_level = ia_aiq_tone_map_level_default;\n-\tgbceParams.frame_use = ia_aiq_frame_use_still;\n+\tgbceParams.frame_use = ia_aiq_frame_use_preview;\n \tgbceParams.ev_shift = 0;\n \n \t/* SA Params */\n-\tsaParams.frame_use = ia_aiq_frame_use_still;\n+\tsaParams.frame_use = ia_aiq_frame_use_preview;\n }\n \n } /* namespace ipa::ipu3::aiq */\n", "prefixes": [ "libcamera-devel", "v2", "1/6" ] }