[libcamera-devel,v2,1/6] ipu3: Use ia_aiq_frame_use_preview as default mode for AIQ

14418 diff mbox series

The frame use mode is set according to Android Capture Intent in Intel
HAL's implememtation. The current default mode ia_aiq_frame_use_still is
only used with the single capture request. For preview use case, it has
hard time converging AE and AF smoothly. Change the default mode to
ia_aiq_frame_use_preview for better user experience.

Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
---
 aiq/aiq_input_parameters.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Hi Han-Lin,

Quoting Han-Lin Chen (2021-10-29 12:59:56)
> The frame use mode is set according to Android Capture Intent in Intel
> HAL's implememtation. The current default mode ia_aiq_frame_use_still is
> only used with the single capture request. For preview use case, it has

'has a hard time' (missing 'a').

> hard time converging AE and AF smoothly. Change the default mode to
> ia_aiq_frame_use_preview for better user experience.

I see that on the first version, Umang offered his RB tag:

Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>

When you post a new version of a series, could you aim to collect tags
that have been provided, and add them to your commit message please?

Otherwise, (unless otherwise spotted) they will get lost.


Could you also try to add a cover letter to any multipatch series
please? It really helps group the series together, and provides a space
to write any commentary or notes about the series.

Finally, for IPU3-IPA patches, could you add a prefix to the patches to
clearly mark them when sending? They are distinct from the main
libcamera project.

You can make sure it's set by running this in your ipu3-ipa checkout:
  git config format.subjectPrefix "IPU3-IPA PATCH"

We 'could' set up a separate list - but I think that's overkill right
now.


But this patch looks fine.


Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>


> 
> Signed-off-by: Han-Lin Chen <hanlinchen@chromium.org>
> ---
>  aiq/aiq_input_parameters.cpp | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/aiq/aiq_input_parameters.cpp b/aiq/aiq_input_parameters.cpp
> index 36e2b07..bc87b31 100644
> --- a/aiq/aiq_input_parameters.cpp
> +++ b/aiq/aiq_input_parameters.cpp
> @@ -132,7 +132,7 @@ void AiqInputParameters::setAeAwbAfDefaults()
>  {
>         /*Ae Params */
>         aeInputParams.num_exposures = NUM_EXPOSURES;
> -       aeInputParams.frame_use = ia_aiq_frame_use_still;
> +       aeInputParams.frame_use = ia_aiq_frame_use_preview;
>         aeInputParams.flash_mode = ia_aiq_flash_mode_off;
>         aeInputParams.operation_mode = ia_aiq_ae_operation_mode_automatic;
>         aeInputParams.metering_mode = ia_aiq_ae_metering_mode_evaluative;
> @@ -153,7 +153,7 @@ void AiqInputParameters::setAeAwbAfDefaults()
>         aeInputParams.manual_convergence_time = -1;
>  
>         /* AWB Params */
> -       awbParams.frame_use = ia_aiq_frame_use_still;
> +       awbParams.frame_use = ia_aiq_frame_use_preview;
>         awbParams.scene_mode = ia_aiq_awb_operation_mode_auto;
>         awbParams.manual_convergence_time = -1.0;
>         awbParams.manual_cct_range = nullptr;
> @@ -161,7 +161,7 @@ void AiqInputParameters::setAeAwbAfDefaults()
>  
>         /* AF Params */
>         afParams = {
> -               ia_aiq_frame_use_still, 0, 1500,
> +               ia_aiq_frame_use_preview, 0, 1500,
>                 ia_aiq_af_operation_mode_auto,
>                 ia_aiq_af_range_normal,
>                 ia_aiq_af_metering_mode_auto,
> @@ -172,11 +172,11 @@ void AiqInputParameters::setAeAwbAfDefaults()
>         /* GBCE Params */
>         gbceParams.gbce_level = ia_aiq_gbce_level_bypass;
>         gbceParams.tone_map_level = ia_aiq_tone_map_level_default;
> -       gbceParams.frame_use = ia_aiq_frame_use_still;
> +       gbceParams.frame_use = ia_aiq_frame_use_preview;
>         gbceParams.ev_shift = 0;
>  
>         /* SA Params */
> -       saParams.frame_use = ia_aiq_frame_use_still;
> +       saParams.frame_use = ia_aiq_frame_use_preview;
>  }
>  
>  } /* namespace ipa::ipu3::aiq */
> -- 
> 2.33.1.1089.g2158813163f-goog
>