Patch Detail
Show a patch.
GET /api/1.1/patches/14071/?format=api
{ "id": 14071, "url": "https://patchwork.libcamera.org/api/1.1/patches/14071/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14071/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211007093937.121357-2-umang.jain@ideasonboard.com>", "date": "2021-10-07T09:39:37", "name": "[libcamera-devel,2/2] android: camera_stream: Fix error message for buffer creation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "98b57f3c068bae9a680aab7c3cccd0ca535d967c", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14071/mbox/", "series": [ { "id": 2607, "url": "https://patchwork.libcamera.org/api/1.1/series/2607/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2607", "date": "2021-10-07T09:39:36", "name": "[libcamera-devel,1/2] android: mm: Null check for CameraBufferManager", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2607/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14071/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14071/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DF3CBDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 7 Oct 2021 09:39:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 01D3C691B7;\n\tThu, 7 Oct 2021 11:39:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9B3F691B6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 7 Oct 2021 11:39:48 +0200 (CEST)", "from perceval.ideasonboard.com (unknown [103.251.226.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF24EDDE;\n\tThu, 7 Oct 2021 11:39:47 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"g0rdof1h\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1633599588;\n\tbh=jFI4DLDO42yMfKkd9C3PyiArQ49OgE+aLAraLcK67nM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=g0rdof1hX7Btq9rDUR/s6t3ALfk0PneYQWb0UsODJToG5Eoie1xAUtGIYQfNGAlOp\n\tas+FZ59bBeOwVOFcwBKvvO8Ld/xyuAbFh+eboDwZcvOSBWmb/+AAB4gQgYNi3I8GKP\n\taIOPa0Fa06iS8nY8g1BppQPOxIeyXAmXS4A2fRC4=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 7 Oct 2021 15:09:37 +0530", "Message-Id": "<20211007093937.121357-2-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211007093937.121357-1-umang.jain@ideasonboard.com>", "References": "<20211007093937.121357-1-umang.jain@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 2/2] android: camera_stream: Fix error\n\tmessage for buffer creation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\nCreating a CameraBuffer instance doesn't map memory. Fix the error\nmessage accordingly.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Umang Jain <umang.jain@ideasonboard.com>\nSigned-off-by: Umang Jain <umang.jain@ideasonboard.com>\n---\n src/android/camera_stream.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex db8d854b..3b96d2e9 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,\n \tCameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,\n \t\t\t PROT_READ | PROT_WRITE);\n \tif (!dest.isValid()) {\n-\t\tLOG(HAL, Error) << \"Failed to map android blob buffer\";\n+\t\tLOG(HAL, Error) << \"Failed to create destination buffer\";\n \t\treturn -EINVAL;\n \t}\n \n", "prefixes": [ "libcamera-devel", "2/2" ] }