[libcamera-devel,2/2] android: camera_stream: Fix error message for buffer creation
diff mbox series

Message ID 20211007093937.121357-2-umang.jain@ideasonboard.com
State Accepted
Headers show
Series
  • [libcamera-devel,1/2] android: mm: Null check for CameraBufferManager
Related show

Commit Message

Umang Jain Oct. 7, 2021, 9:39 a.m. UTC 
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Creating a CameraBuffer instance doesn't map memory. Fix the error
message accordingly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
 src/android/camera_stream.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hirokazu Honda Oct. 7, 2021, 10:35 a.m. UTC | #1 
Hi Umang, thank you for the patch.

On Thu, Oct 7, 2021 at 6:39 PM Umang Jain <umang.jain@ideasonboard.com> wrote:
>
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Creating a CameraBuffer instance doesn't map memory. Fix the error
> message accordingly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> ---
>  src/android/camera_stream.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
> index db8d854b..3b96d2e9 100644
> --- a/src/android/camera_stream.cpp
> +++ b/src/android/camera_stream.cpp
> @@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,
>         CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,
>                           PROT_READ | PROT_WRITE);
>         if (!dest.isValid()) {
> -               LOG(HAL, Error) << "Failed to map android blob buffer";
> +               LOG(HAL, Error) << "Failed to create destination buffer";
>                 return -EINVAL;
>         }
>
> --
> 2.31.1
>
Jacopo Mondi Oct. 11, 2021, 10:23 a.m. UTC | #2 
On Thu, Oct 07, 2021 at 03:09:37PM +0530, Umang Jain wrote:
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Creating a CameraBuffer instance doesn't map memory. Fix the error
> message accordingly.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>

Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>


> ---
>  src/android/camera_stream.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
> index db8d854b..3b96d2e9 100644
> --- a/src/android/camera_stream.cpp
> +++ b/src/android/camera_stream.cpp
> @@ -171,7 +171,7 @@ int CameraStream::process(const FrameBuffer &source,
>  	CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,
>  			  PROT_READ | PROT_WRITE);
>  	if (!dest.isValid()) {
> -		LOG(HAL, Error) << "Failed to map android blob buffer";
> +		LOG(HAL, Error) << "Failed to create destination buffer";
>  		return -EINVAL;
>  	}
>
> --
> 2.31.1
>

Patch
diff mbox series 

diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
index db8d854b..3b96d2e9 100644
--- a/src/android/camera_stream.cpp
+++ b/src/android/camera_stream.cpp
@@ -171,7 +171,7 @@  int CameraStream::process(const FrameBuffer &source,
 	CameraBuffer dest(*camera3Dest.buffer, output.pixelFormat, output.size,
 			  PROT_READ | PROT_WRITE);
 	if (!dest.isValid()) {
-		LOG(HAL, Error) << "Failed to map android blob buffer";
+		LOG(HAL, Error) << "Failed to create destination buffer";
 		return -EINVAL;
 	}