Patch Detail
Show a patch.
GET /api/1.1/patches/14046/?format=api
{ "id": 14046, "url": "https://patchwork.libcamera.org/api/1.1/patches/14046/?format=api", "web_url": "https://patchwork.libcamera.org/patch/14046/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20211005073114.3997303-3-hiroh@chromium.org>", "date": "2021-10-05T07:31:10", "name": "[libcamera-devel,RFC,2/6] cam: Remove using namespace in stream_options.h", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d5ba9140ce3b9295a31c96e380f0b4ef490c8f87", "submitter": { "id": 63, "url": "https://patchwork.libcamera.org/api/1.1/people/63/?format=api", "name": "Hirokazu Honda", "email": "hiroh@chromium.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/14046/mbox/", "series": [ { "id": 2602, "url": "https://patchwork.libcamera.org/api/1.1/series/2602/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2602", "date": "2021-10-05T07:31:08", "name": "Remove using namespace in header files", "version": 1, "mbox": "https://patchwork.libcamera.org/series/2602/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/14046/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/14046/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5745BDC71\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 5 Oct 2021 07:31:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 896EB691C0;\n\tTue, 5 Oct 2021 09:31:30 +0200 (CEST)", "from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com\n\t[IPv6:2607:f8b0:4864:20::102f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8489C691AD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 5 Oct 2021 09:31:28 +0200 (CEST)", "by mail-pj1-x102f.google.com with SMTP id np13so3417703pjb.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 05 Oct 2021 00:31:28 -0700 (PDT)", "from hiroh2.tok.corp.google.com\n\t([2401:fa00:8f:203:debc:d0db:3bd8:f961])\n\tby smtp.gmail.com with ESMTPSA id\n\to14sm16761812pfh.145.2021.10.05.00.31.25\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 05 Oct 2021 00:31:26 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"ag/d1zN2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kL/CgG4PVTmQWbYcC3g4MNyOX0OGDyYjYFMI+Kj5Rzc=;\n\tb=ag/d1zN2CBwRbyeSqIHOhUVuMAmXxd21ilbR0QNRsUyx7Xm8XMALIAhACtx8a8zXBq\n\tPvAdqvR68hUcx4s/vVLue2pOpVT2AtohFIgpB+Tls2/nqLC+xcrOuID+WVHjbyuZOsOi\n\tUFzhiXYQWrye/O+BtCu95tALAUAXihuAwTcsU=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20210112;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kL/CgG4PVTmQWbYcC3g4MNyOX0OGDyYjYFMI+Kj5Rzc=;\n\tb=x1DDgQug5SgReTsE4ZqbfxwORblEl9jdPW3v1ZcKNV2bhdugY9qj3AJ+hIA5GxeVrk\n\tD0TmMIBhq68CRBtqQIvv4vulfLScmXCwBaDmC+ZEOIIqZ6ezo6e91n5pfquvZofiboxa\n\tt2fagk10Mcv/OaraxJ6A0NiCX/6KQu8xOtBObldUmWGno/M0PSHRXtRiw64vkfz8R2Ea\n\tMzmpnt4RqOckrza0XvRh2W9MAVABlkQFzD8d6k9V01omOnwQynF+A92g0cQIa9k8X4mn\n\t8FsFLiBeENI3+kTIQvDCx71MqmSeghbH7oRtweXX4FEAkMFsscKVBMDeAHWL5Xl/VyVZ\n\tC7AQ==", "X-Gm-Message-State": "AOAM531L+UwTH9LbjvNBs+v9tHHiq/N+IqwskX7YuxROa4NGvA49gWZb\n\t101d3AYFWIBY9dEtD/FaIhYVStZY4jz1lg==", "X-Google-Smtp-Source": "ABdhPJy3Z7lCQ9CHr6eNPW4DgIvcMWfa1UqA5fwu+OZv2GwJB4YapUf1yIlZipdbceCfwT30+kYHew==", "X-Received": "by 2002:a17:902:8bc4:b029:12b:8470:e29e with SMTP id\n\tr4-20020a1709028bc4b029012b8470e29emr3904637plo.2.1633419086572; \n\tTue, 05 Oct 2021 00:31:26 -0700 (PDT)", "From": "Hirokazu Honda <hiroh@chromium.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 5 Oct 2021 16:31:10 +0900", "Message-Id": "<20211005073114.3997303-3-hiroh@chromium.org>", "X-Mailer": "git-send-email 2.33.0.800.g4c38ced690-goog", "In-Reply-To": "<20211005073114.3997303-1-hiroh@chromium.org>", "References": "<20211005073114.3997303-1-hiroh@chromium.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [RFC PATCH 2/6] cam: Remove using namespace in\n\tstream_options.h", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "\"using namespace\" in a header file propagates the namespace to\nthe files including the header file. So it should be avoided.\nThis removes \"using namespace\" in stream_options.h\n\nSigned-off-by: Hirokazu Honda <hiroh@chromium.org>\n---\n src/cam/stream_options.h | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/cam/stream_options.h b/src/cam/stream_options.h\nindex 577391f0..fbbc13a3 100644\n--- a/src/cam/stream_options.h\n+++ b/src/cam/stream_options.h\n@@ -11,8 +11,6 @@\n \n #include \"options.h\"\n \n-using namespace libcamera;\n-\n class StreamKeyValueParser : public KeyValueParser\n {\n public:\n@@ -20,12 +18,12 @@ public:\n \n \tKeyValueParser::Options parse(const char *arguments) override;\n \n-\tstatic StreamRoles roles(const OptionValue &values);\n-\tstatic int updateConfiguration(CameraConfiguration *config,\n+\tstatic libcamera::StreamRoles roles(const OptionValue &values);\n+\tstatic int updateConfiguration(libcamera::CameraConfiguration *config,\n \t\t\t\t const OptionValue &values);\n \n private:\n-\tstatic bool parseRole(StreamRole *role,\n+\tstatic bool parseRole(libcamera::StreamRole *role,\n \t\t\t const KeyValueParser::Options &options);\n };\n \n", "prefixes": [ "libcamera-devel", "RFC", "2/6" ] }