From patchwork Tue Oct 5 07:31:10 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hirokazu Honda X-Patchwork-Id: 14046 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C5745BDC71 for ; Tue, 5 Oct 2021 07:31:30 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 896EB691C0; Tue, 5 Oct 2021 09:31:30 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=chromium.org header.i=@chromium.org header.b="ag/d1zN2"; dkim-atps=neutral Received: from mail-pj1-x102f.google.com (mail-pj1-x102f.google.com [IPv6:2607:f8b0:4864:20::102f]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 8489C691AD for ; Tue, 5 Oct 2021 09:31:28 +0200 (CEST) Received: by mail-pj1-x102f.google.com with SMTP id np13so3417703pjb.4 for ; Tue, 05 Oct 2021 00:31:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kL/CgG4PVTmQWbYcC3g4MNyOX0OGDyYjYFMI+Kj5Rzc=; b=ag/d1zN2CBwRbyeSqIHOhUVuMAmXxd21ilbR0QNRsUyx7Xm8XMALIAhACtx8a8zXBq PvAdqvR68hUcx4s/vVLue2pOpVT2AtohFIgpB+Tls2/nqLC+xcrOuID+WVHjbyuZOsOi UFzhiXYQWrye/O+BtCu95tALAUAXihuAwTcsU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kL/CgG4PVTmQWbYcC3g4MNyOX0OGDyYjYFMI+Kj5Rzc=; b=x1DDgQug5SgReTsE4ZqbfxwORblEl9jdPW3v1ZcKNV2bhdugY9qj3AJ+hIA5GxeVrk D0TmMIBhq68CRBtqQIvv4vulfLScmXCwBaDmC+ZEOIIqZ6ezo6e91n5pfquvZofiboxa t2fagk10Mcv/OaraxJ6A0NiCX/6KQu8xOtBObldUmWGno/M0PSHRXtRiw64vkfz8R2Ea Mzmpnt4RqOckrza0XvRh2W9MAVABlkQFzD8d6k9V01omOnwQynF+A92g0cQIa9k8X4mn 8FsFLiBeENI3+kTIQvDCx71MqmSeghbH7oRtweXX4FEAkMFsscKVBMDeAHWL5Xl/VyVZ C7AQ== X-Gm-Message-State: AOAM531L+UwTH9LbjvNBs+v9tHHiq/N+IqwskX7YuxROa4NGvA49gWZb 101d3AYFWIBY9dEtD/FaIhYVStZY4jz1lg== X-Google-Smtp-Source: ABdhPJy3Z7lCQ9CHr6eNPW4DgIvcMWfa1UqA5fwu+OZv2GwJB4YapUf1yIlZipdbceCfwT30+kYHew== X-Received: by 2002:a17:902:8bc4:b029:12b:8470:e29e with SMTP id r4-20020a1709028bc4b029012b8470e29emr3904637plo.2.1633419086572; Tue, 05 Oct 2021 00:31:26 -0700 (PDT) Received: from hiroh2.tok.corp.google.com ([2401:fa00:8f:203:debc:d0db:3bd8:f961]) by smtp.gmail.com with ESMTPSA id o14sm16761812pfh.145.2021.10.05.00.31.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 00:31:26 -0700 (PDT) From: Hirokazu Honda To: libcamera-devel@lists.libcamera.org Date: Tue, 5 Oct 2021 16:31:10 +0900 Message-Id: <20211005073114.3997303-3-hiroh@chromium.org> X-Mailer: git-send-email 2.33.0.800.g4c38ced690-goog In-Reply-To: <20211005073114.3997303-1-hiroh@chromium.org> References: <20211005073114.3997303-1-hiroh@chromium.org> MIME-Version: 1.0 Subject: [libcamera-devel] [RFC PATCH 2/6] cam: Remove using namespace in stream_options.h X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" "using namespace" in a header file propagates the namespace to the files including the header file. So it should be avoided. This removes "using namespace" in stream_options.h Signed-off-by: Hirokazu Honda Reviewed-by: Laurent Pinchart --- src/cam/stream_options.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/cam/stream_options.h b/src/cam/stream_options.h index 577391f0..fbbc13a3 100644 --- a/src/cam/stream_options.h +++ b/src/cam/stream_options.h @@ -11,8 +11,6 @@ #include "options.h" -using namespace libcamera; - class StreamKeyValueParser : public KeyValueParser { public: @@ -20,12 +18,12 @@ public: KeyValueParser::Options parse(const char *arguments) override; - static StreamRoles roles(const OptionValue &values); - static int updateConfiguration(CameraConfiguration *config, + static libcamera::StreamRoles roles(const OptionValue &values); + static int updateConfiguration(libcamera::CameraConfiguration *config, const OptionValue &values); private: - static bool parseRole(StreamRole *role, + static bool parseRole(libcamera::StreamRole *role, const KeyValueParser::Options &options); };