Patch Detail
Show a patch.
GET /api/1.1/patches/1389/?format=api
{ "id": 1389, "url": "https://patchwork.libcamera.org/api/1.1/patches/1389/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1389/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190610220759.7192-1-kieran.bingham@ideasonboard.com>", "date": "2019-06-10T22:07:57", "name": "[libcamera-devel,1/3] libcamera: pipeline: Fix 'request' grammar", "commit_ref": "a0f869f4ed92144aed6f8d9ad8f06eb02f365939", "pull_url": null, "state": "accepted", "archived": false, "hash": "59bd618046b927d65df606b974e8ad9acb367c35", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1389/mbox/", "series": [ { "id": 346, "url": "https://patchwork.libcamera.org/api/1.1/series/346/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=346", "date": "2019-06-10T22:07:57", "name": "[libcamera-devel,1/3] libcamera: pipeline: Fix 'request' grammar", "version": 1, "mbox": "https://patchwork.libcamera.org/series/346/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1389/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1389/checks/", "tags": {}, "headers": { "Return-Path": "<kieran.bingham@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1DDD661E49\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 11 Jun 2019 00:08:04 +0200 (CEST)", "from localhost.localdomain\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82C2F9CB;\n\tTue, 11 Jun 2019 00:08:03 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1560204483;\n\tbh=+iVOT40c42yVBP6yijbsBRpQJ+jEwNaTOhGGALQiXKU=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=cn0+BG4DBy8OdJUAtV2SWqOM26pDcdTkMPd5g5oTdsgTpHoGSDsg49tgFUOH7MzI3\n\t408i0nojEkGZRPvCWyLD3O4kR6rGNIKVJHglcnRs7NgXwoXbCWsNXUz/4pgqwYD4BM\n\t4GfqSV0LLnKmUu+7pYzcvn8CPgD3ZT/7DNFDy1ZM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "LibCamera Devel <libcamera-devel@lists.libcamera.org>", "Date": "Mon, 10 Jun 2019 23:07:57 +0100", "Message-Id": "<20190610220759.7192-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.20.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 1/3] libcamera: pipeline: Fix 'request'\n\tgrammar", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Mon, 10 Jun 2019 22:08:04 -0000" }, "content": "The PipelineHandler::completeBuffer documentation repeats the word\n'request'.\n\nRemove the duplication and reformat the lines to fit.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline_handler.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\nindex af19f4a33187..c91ef2f7d336 100644\n--- a/src/libcamera/pipeline_handler.cpp\n+++ b/src/libcamera/pipeline_handler.cpp\n@@ -391,8 +391,8 @@ bool PipelineHandler::completeBuffer(Camera *camera, Request *request,\n * \\param[in] request The request that has completed\n *\n * The pipeline handler shall call this method to notify the \\a camera that the\n- * request request has complete. The request is deleted and shall not be\n- * accessed once this method returns.\n+ * request has completed. The request is deleted and shall not be accessed once\n+ * this method returns.\n *\n * The pipeline handler shall ensure that requests complete in the same order\n * they are submitted.\n", "prefixes": [ "libcamera-devel", "1/3" ] }