Patch Detail
Show a patch.
GET /api/1.1/patches/12658/?format=api
{ "id": 12658, "url": "https://patchwork.libcamera.org/api/1.1/patches/12658/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12658/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210618220430.31457-3-david.plowman@raspberrypi.com>", "date": "2021-06-18T22:04:29", "name": "[libcamera-devel,v3,2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "2a61ab090174e2fc3baae2dd3f2bdde50d19af16", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12658/mbox/", "series": [ { "id": 2155, "url": "https://patchwork.libcamera.org/api/1.1/series/2155/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=2155", "date": "2021-06-18T22:04:28", "name": "Support monochrome raw sensors", "version": 3, "mbox": "https://patchwork.libcamera.org/series/2155/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12658/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12658/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEF34C3218\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Jun 2021 22:04:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC9B968945;\n\tSat, 19 Jun 2021 00:04:37 +0200 (CEST)", "from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com\n\t[IPv6:2a00:1450:4864:20::32c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9405E68941\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 19 Jun 2021 00:04:34 +0200 (CEST)", "by mail-wm1-x32c.google.com with SMTP id k42so4579537wms.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jun 2021 15:04:34 -0700 (PDT)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tz6sm6966322wrl.15.2021.06.18.15.04.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 18 Jun 2021 15:04:33 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PknzAU9T\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Hcf9ofbdLPIh6tqcosN/IW8wPf9ss9qQbmBmaZ6sQUc=;\n\tb=PknzAU9T870XozakSQzOLtPq838TMNSYc2yLkhjFW9N+RcM40tMw6tWIlpz0yl0ZXY\n\th+oIIHtNcl00gEyp2g3aRlDQDlB90M8xslL9cN8uahqZmP9uwW09sn6wTos1j+DUBFkT\n\tB98hLPkfGdd9HXYuM7yor5IGAO9FFQrCPwaWNlAz7sVteRTre2/tAl8kQHSe47jAbmvw\n\tJpesjTdB7mVpbNz1vlu0KZs/82weZDXRTnbpKaHdV5pbe9bo9mz1X8nysYoZlZo86OyX\n\t7nWyO1SjiCwMz6Z9EHIDpU6C/JC4HjMawhIYNdGLc9znME7QpeKvyNTHqiL7wc5S56qj\n\tDJ3Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Hcf9ofbdLPIh6tqcosN/IW8wPf9ss9qQbmBmaZ6sQUc=;\n\tb=Jd2V/dapANJncV0N1WKt2oCtH4+Y4MoSWv9Oshx+71r4KH/G5o5Uc7I2+if/gcopys\n\tB8pxdKhB1JsKrsZYUFvz9rQMiGZ3h0sxM5kdehEfQvzewZnw0VksdAarfDP7cq60O5Nk\n\tUefXy/1JjAimNhngwDjqn+LW5MYOw8xAxKn04brVlo2c0aQtgv4ZN5H4tacSBy7d2251\n\t9nWtIsyaTHY07tSjzt3UD7Dw4Tzdo9xzzJ8Wxp0T0nnqr6x0yIVFCpJ9dku5fE8Ov6ZE\n\tdaHS+q2miARuIaLh8ylswOyFfs6Oh0yXVcw9/NpcHjlR0eNX2vGw93p2BNjjFpzArwlP\n\tAkpQ==", "X-Gm-Message-State": "AOAM531MIi8N1wpepfdoM0/qK+LnK3zIBRD0hTQqFOxx/FEBXZrtPI6s\n\taTK6EXVD/oxVSXem7Tfs8YjRvbZrurGGM2HR", "X-Google-Smtp-Source": "ABdhPJy5SPpics3ay1EjhF+SS/LA079OAMNHEouQAc8VlmhD3ROoHP4kcT8lKj2reL+WAGXxj43vng==", "X-Received": "by 2002:a1c:7c19:: with SMTP id x25mr7236139wmc.99.1624053874144;\n\tFri, 18 Jun 2021 15:04:34 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Fri, 18 Jun 2021 23:04:29 +0100", "Message-Id": "<20210618220430.31457-3-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20210618220430.31457-1-david.plowman@raspberrypi.com>", "References": "<20210618220430.31457-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH v3 2/3] libcamera: ipa: raspberrypi:\n\tDemote warnings about lack of AWB results", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Warnings about the lack of AWB status results are demoted to being\njust \"Debug\". With monochrome sensors becoming more common this would\notherwise overwhelm the console output, and in practice nothing is\nreally lost as it is normally very evident if AWB is failing to run.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +-\n src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++--\n 2 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex 55e80ac7..2c95f287 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata)\n \tawb_.gain_g = 1.0;\n \tawb_.gain_b = 1.0;\n \tif (image_metadata->Get(\"awb.status\", awb_) != 0)\n-\t\tLOG(RPiAgc, Warning) << \"Agc: no AWB status found\";\n+\t\tLOG(RPiAgc, Debug) << \"Agc: no AWB status found\";\n }\n \n static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb,\ndiff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\nindex b0d24aa2..ef99c1b0 100644\n--- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp\n@@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct)\n \tAwbStatus awb_status;\n \tawb_status.temperature_K = default_ct; // in case nothing found\n \tif (metadata->Get(\"awb.status\", awb_status) != 0)\n-\t\tLOG(RPiAlsc, Warning) << \"no AWB results found, using \"\n-\t\t\t\t << awb_status.temperature_K;\n+\t\tLOG(RPiAlsc, Debug) << \"no AWB results found, using \"\n+\t\t\t\t << awb_status.temperature_K;\n \telse\n \t\tLOG(RPiAlsc, Debug) << \"AWB results found, using \"\n \t\t\t\t << awb_status.temperature_K;\n", "prefixes": [ "libcamera-devel", "v3", "2/3" ] }