From patchwork Fri Jun 18 22:04:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 12658 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CEF34C3218 for ; Fri, 18 Jun 2021 22:04:39 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id BC9B968945; Sat, 19 Jun 2021 00:04:37 +0200 (CEST) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="PknzAU9T"; dkim-atps=neutral Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 9405E68941 for ; Sat, 19 Jun 2021 00:04:34 +0200 (CEST) Received: by mail-wm1-x32c.google.com with SMTP id k42so4579537wms.0 for ; Fri, 18 Jun 2021 15:04:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Hcf9ofbdLPIh6tqcosN/IW8wPf9ss9qQbmBmaZ6sQUc=; b=PknzAU9T870XozakSQzOLtPq838TMNSYc2yLkhjFW9N+RcM40tMw6tWIlpz0yl0ZXY h+oIIHtNcl00gEyp2g3aRlDQDlB90M8xslL9cN8uahqZmP9uwW09sn6wTos1j+DUBFkT B98hLPkfGdd9HXYuM7yor5IGAO9FFQrCPwaWNlAz7sVteRTre2/tAl8kQHSe47jAbmvw JpesjTdB7mVpbNz1vlu0KZs/82weZDXRTnbpKaHdV5pbe9bo9mz1X8nysYoZlZo86OyX 7nWyO1SjiCwMz6Z9EHIDpU6C/JC4HjMawhIYNdGLc9znME7QpeKvyNTHqiL7wc5S56qj DJ3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Hcf9ofbdLPIh6tqcosN/IW8wPf9ss9qQbmBmaZ6sQUc=; b=Jd2V/dapANJncV0N1WKt2oCtH4+Y4MoSWv9Oshx+71r4KH/G5o5Uc7I2+if/gcopys B8pxdKhB1JsKrsZYUFvz9rQMiGZ3h0sxM5kdehEfQvzewZnw0VksdAarfDP7cq60O5Nk UefXy/1JjAimNhngwDjqn+LW5MYOw8xAxKn04brVlo2c0aQtgv4ZN5H4tacSBy7d2251 9nWtIsyaTHY07tSjzt3UD7Dw4Tzdo9xzzJ8Wxp0T0nnqr6x0yIVFCpJ9dku5fE8Ov6ZE daHS+q2miARuIaLh8ylswOyFfs6Oh0yXVcw9/NpcHjlR0eNX2vGw93p2BNjjFpzArwlP AkpQ== X-Gm-Message-State: AOAM531MIi8N1wpepfdoM0/qK+LnK3zIBRD0hTQqFOxx/FEBXZrtPI6s aTK6EXVD/oxVSXem7Tfs8YjRvbZrurGGM2HR X-Google-Smtp-Source: ABdhPJy5SPpics3ay1EjhF+SS/LA079OAMNHEouQAc8VlmhD3ROoHP4kcT8lKj2reL+WAGXxj43vng== X-Received: by 2002:a1c:7c19:: with SMTP id x25mr7236139wmc.99.1624053874144; Fri, 18 Jun 2021 15:04:34 -0700 (PDT) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id z6sm6966322wrl.15.2021.06.18.15.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Jun 2021 15:04:33 -0700 (PDT) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Fri, 18 Jun 2021 23:04:29 +0100 Message-Id: <20210618220430.31457-3-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210618220430.31457-1-david.plowman@raspberrypi.com> References: <20210618220430.31457-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v3 2/3] libcamera: ipa: raspberrypi: Demote warnings about lack of AWB results X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Warnings about the lack of AWB status results are demoted to being just "Debug". With monochrome sensors becoming more common this would otherwise overwhelm the console output, and in practice nothing is really lost as it is normally very evident if AWB is failing to run. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 2 +- src/ipa/raspberrypi/controller/rpi/alsc.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index 55e80ac7..2c95f287 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -481,7 +481,7 @@ void Agc::fetchAwbStatus(Metadata *image_metadata) awb_.gain_g = 1.0; awb_.gain_b = 1.0; if (image_metadata->Get("awb.status", awb_) != 0) - LOG(RPiAgc, Warning) << "Agc: no AWB status found"; + LOG(RPiAgc, Debug) << "Agc: no AWB status found"; } static double compute_initial_Y(bcm2835_isp_stats *stats, AwbStatus const &awb, diff --git a/src/ipa/raspberrypi/controller/rpi/alsc.cpp b/src/ipa/raspberrypi/controller/rpi/alsc.cpp index b0d24aa2..ef99c1b0 100644 --- a/src/ipa/raspberrypi/controller/rpi/alsc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/alsc.cpp @@ -267,8 +267,8 @@ double get_ct(Metadata *metadata, double default_ct) AwbStatus awb_status; awb_status.temperature_K = default_ct; // in case nothing found if (metadata->Get("awb.status", awb_status) != 0) - LOG(RPiAlsc, Warning) << "no AWB results found, using " - << awb_status.temperature_K; + LOG(RPiAlsc, Debug) << "no AWB results found, using " + << awb_status.temperature_K; else LOG(RPiAlsc, Debug) << "AWB results found, using " << awb_status.temperature_K;