Patch Detail
Show a patch.
GET /api/1.1/patches/1218/?format=api
{ "id": 1218, "url": "https://patchwork.libcamera.org/api/1.1/patches/1218/?format=api", "web_url": "https://patchwork.libcamera.org/patch/1218/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>", "date": "2019-05-17T23:06:10", "name": "[libcamera-devel,PATCH/RFC,01/12] libcamera: camera: Fix std::ostringstream initialisation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bb9dba7969da871f23b067ca16ced800a6eebb1f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/1.1/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/1218/mbox/", "series": [ { "id": 307, "url": "https://patchwork.libcamera.org/api/1.1/series/307/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=307", "date": "2019-05-17T23:06:09", "name": "Rework camera configuration to introduce negotiation of parameters", "version": 1, "mbox": "https://patchwork.libcamera.org/series/307/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/1218/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/1218/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E3AC60E4C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 May 2019 01:06:43 +0200 (CEST)", "from pendragon.bb.dnainternet.fi\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3E26336\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 18 May 2019 01:06:42 +0200 (CEST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1558134403;\n\tbh=OztG7646FvjlGJg9+Qv8ZGXpLDBaAmZjKkvDnogxvgo=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=Rf813KH/LqB2n0ipA218Myu161GPaQoUsiy5ORb1rnN+H5o14anx6n7u0+/LLFwom\n\txYq1NPM9nf8Q7FdECycdbKWCnUiKo8kR2yXIZWYRTPIoVQdgUETKrd2Do5X7xsGZ2R\n\t4pWqjU4in1xHqYwEnUpHhC9tZS1shQDzQJaG8y1E=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 18 May 2019 02:06:10 +0300", "Message-Id": "<20190517230621.24668-2-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>", "References": "<20190517230621.24668-1-laurent.pinchart@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix\n\tstd::ostringstream initialisation", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.23", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Fri, 17 May 2019 23:06:43 -0000" }, "content": "We use the std::ostringstream class to generate log messages in the\nCamera class. The stream is initialised with initial content, but is not\nopened without seeking to the end, which results in the content being\noverwritten immediately. Fix it by opening the stream with\nstd::ios_base::ate.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/camera.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex fbc66dedba51..1a21acac9899 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -560,7 +560,7 @@ Camera::streamConfiguration(const std::vector<StreamUsage> &usages)\n \n \tCameraConfiguration config = pipe_->streamConfiguration(this, usages);\n \n-\tstd::ostringstream msg(\"streams configuration:\");\n+\tstd::ostringstream msg(\"streams configuration:\", std::ios_base::ate);\n \tunsigned int index = 0;\n \n \tfor (Stream *stream : config) {\n@@ -614,7 +614,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n \t\treturn -EINVAL;\n \t}\n \n-\tstd::ostringstream msg(\"configuring streams:\");\n+\tstd::ostringstream msg(\"configuring streams:\", std::ios_base::ate);\n \tunsigned int index = 0;\n \n \tfor (Stream *stream : config) {\n", "prefixes": [ "libcamera-devel", "PATCH/RFC", "01/12" ] }