From patchwork Fri May 17 23:06:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Laurent Pinchart X-Patchwork-Id: 1218 Return-Path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id 6E3AC60E4C for ; Sat, 18 May 2019 01:06:43 +0200 (CEST) Received: from pendragon.bb.dnainternet.fi (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E3E26336 for ; Sat, 18 May 2019 01:06:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1558134403; bh=OztG7646FvjlGJg9+Qv8ZGXpLDBaAmZjKkvDnogxvgo=; h=From:To:Subject:Date:In-Reply-To:References:From; b=Rf813KH/LqB2n0ipA218Myu161GPaQoUsiy5ORb1rnN+H5o14anx6n7u0+/LLFwom xYq1NPM9nf8Q7FdECycdbKWCnUiKo8kR2yXIZWYRTPIoVQdgUETKrd2Do5X7xsGZ2R 4pWqjU4in1xHqYwEnUpHhC9tZS1shQDzQJaG8y1E= From: Laurent Pinchart To: libcamera-devel@lists.libcamera.org Date: Sat, 18 May 2019 02:06:10 +0300 Message-Id: <20190517230621.24668-2-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190517230621.24668-1-laurent.pinchart@ideasonboard.com> References: <20190517230621.24668-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH/RFC 01/12] libcamera: camera: Fix std::ostringstream initialisation X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 May 2019 23:06:43 -0000 We use the std::ostringstream class to generate log messages in the Camera class. The stream is initialised with initial content, but is not opened without seeking to the end, which results in the content being overwritten immediately. Fix it by opening the stream with std::ios_base::ate. Signed-off-by: Laurent Pinchart Reviewed-by: Niklas Söderlund --- src/libcamera/camera.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp index fbc66dedba51..1a21acac9899 100644 --- a/src/libcamera/camera.cpp +++ b/src/libcamera/camera.cpp @@ -560,7 +560,7 @@ Camera::streamConfiguration(const std::vector &usages) CameraConfiguration config = pipe_->streamConfiguration(this, usages); - std::ostringstream msg("streams configuration:"); + std::ostringstream msg("streams configuration:", std::ios_base::ate); unsigned int index = 0; for (Stream *stream : config) { @@ -614,7 +614,7 @@ int Camera::configureStreams(const CameraConfiguration &config) return -EINVAL; } - std::ostringstream msg("configuring streams:"); + std::ostringstream msg("configuring streams:", std::ios_base::ate); unsigned int index = 0; for (Stream *stream : config) {