Patch Detail
Show a patch.
GET /api/1.1/patches/12013/?format=api
{ "id": 12013, "url": "https://patchwork.libcamera.org/api/1.1/patches/12013/?format=api", "web_url": "https://patchwork.libcamera.org/patch/12013/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210420130741.236848-4-kieran.bingham@ideasonboard.com>", "date": "2021-04-20T13:07:38", "name": "[libcamera-devel,v4,3/6] libcamera: pipeline: rkisp1: Fail RkISP1FrameInfo can't be found", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "670a9dfeca7b2b17a6bb5682c1ef716d30851c35", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/12013/mbox/", "series": [ { "id": 1952, "url": "https://patchwork.libcamera.org/api/1.1/series/1952/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1952", "date": "2021-04-20T13:07:35", "name": "IPU3 Debug Improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1952/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/12013/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/12013/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE401BDB16\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 Apr 2021 13:07:51 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 368D068856;\n\tTue, 20 Apr 2021 15:07:51 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0135E68840\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 Apr 2021 15:07:47 +0200 (CEST)", "from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8C8238AD;\n\tTue, 20 Apr 2021 15:07:46 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EZVAI5UA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1618924066;\n\tbh=bh91nfL9I021cEfFTqVmCZcvRLjgxiXMG8vnDBDBZQs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=EZVAI5UAPWXxlaFik7TIJNNBaMjWZyUTyScUTksme2DoZCxl/VBpFBznNKXnwn+Yy\n\t4ONyCufYz6DX7vIvRFPU3ljRV0Nqf9UQrpb27mtJUw8P1oXigNloZMNM2vt4VfKoll\n\tFVTDqKKw4gaAj8RQT4zET8E7MF7S1ZM30wqkhXF0=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Tue, 20 Apr 2021 14:07:38 +0100", "Message-Id": "<20210420130741.236848-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210420130741.236848-1-kieran.bingham@ideasonboard.com>", "References": "<20210420130741.236848-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 3/6] libcamera: pipeline: rkisp1: Fail\n\tRkISP1FrameInfo can't be found", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The RkISP1FrameInfo structure associated data sent to the IPA and is\nessential for handling events.\n\nIf it can not be found, this is a fatal error which must be fixed.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 549f4a4e61a8..c75666391222 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)\n \tif (itInfo != frameInfo_.end())\n \t\treturn itInfo->second;\n \n-\tLOG(RkISP1, Error) << \"Can't locate info from frame\";\n+\tLOG(RkISP1, Fatal) << \"Can't locate info from frame\";\n+\n \treturn nullptr;\n }\n \n@@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)\n \t\t\treturn info;\n \t}\n \n-\tLOG(RkISP1, Error) << \"Can't locate info from buffer\";\n+\tLOG(RkISP1, Fatal) << \"Can't locate info from buffer\";\n+\n \treturn nullptr;\n }\n \n@@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)\n \t\t\treturn info;\n \t}\n \n-\tLOG(RkISP1, Error) << \"Can't locate info from request\";\n+\tLOG(RkISP1, Fatal) << \"Can't locate info from request\";\n+\n \treturn nullptr;\n }\n \n", "prefixes": [ "libcamera-devel", "v4", "3/6" ] }