[libcamera-devel,v4,3/6] libcamera: pipeline: rkisp1: Fail RkISP1FrameInfo can't be found
diff mbox series

Message ID 20210420130741.236848-4-kieran.bingham@ideasonboard.com
State Accepted
Headers show
Series
  • IPU3 Debug Improvements
Related show

Commit Message

Kieran Bingham April 20, 2021, 1:07 p.m. UTC 
The RkISP1FrameInfo structure associated data sent to the IPA and is
essential for handling events.

If it can not be found, this is a fatal error which must be fixed.

Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Jean-Michel Hautbois April 20, 2021, 5:22 p.m. UTC | #1 
Hi Kieran,

Thanks for the patch !

On 20/04/2021 15:07, Kieran Bingham wrote:
> The RkISP1FrameInfo structure associated data sent to the IPA and is
> essential for handling events.

So, this is not a IPU3 series only after all :-).

> If it can not be found, this is a fatal error which must be fixed.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 549f4a4e61a8..c75666391222 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)
>  	if (itInfo != frameInfo_.end())
>  		return itInfo->second;
>  
> -	LOG(RkISP1, Error) << "Can't locate info from frame";
> +	LOG(RkISP1, Fatal) << "Can't locate info from frame";
> +
>  	return nullptr;
>  }
>  
> @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from buffer";
> +	LOG(RkISP1, Fatal) << "Can't locate info from buffer";
> +
>  	return nullptr;
>  }
>  
> @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from request";
> +	LOG(RkISP1, Fatal) << "Can't locate info from request";
> +
>  	return nullptr;
>  }
>  
>
Laurent Pinchart April 20, 2021, 10:20 p.m. UTC | #2 
Hi Kieran,

Thank you for the patch.

On Tue, Apr 20, 2021 at 02:07:38PM +0100, Kieran Bingham wrote:
> The RkISP1FrameInfo structure associated data sent to the IPA and is
> essential for handling events.
> 
> If it can not be found, this is a fatal error which must be fixed.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 549f4a4e61a8..c75666391222 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)
>  	if (itInfo != frameInfo_.end())
>  		return itInfo->second;
>  
> -	LOG(RkISP1, Error) << "Can't locate info from frame";
> +	LOG(RkISP1, Fatal) << "Can't locate info from frame";
> +
>  	return nullptr;
>  }
>  
> @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from buffer";
> +	LOG(RkISP1, Fatal) << "Can't locate info from buffer";
> +
>  	return nullptr;
>  }
>  
> @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)
>  			return info;
>  	}
>  
> -	LOG(RkISP1, Error) << "Can't locate info from request";
> +	LOG(RkISP1, Fatal) << "Can't locate info from request";
> +
>  	return nullptr;
>  }
>
Hirokazu Honda April 21, 2021, 4:51 a.m. UTC | #3 
Hi Kieran, Thank you for the patch.

On Wed, Apr 21, 2021 at 7:20 AM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Kieran,
>
> Thank you for the patch.
>
> On Tue, Apr 20, 2021 at 02:07:38PM +0100, Kieran Bingham wrote:
> > The RkISP1FrameInfo structure associated data sent to the IPA and is
> > essential for handling events.
> >
> > If it can not be found, this is a fatal error which must be fixed.
> >
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>

Reviewed-by: Hirokazu Honda <hiroh@chromium.org>

> > ---
> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++++++---
> >  1 file changed, 6 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > index 549f4a4e61a8..c75666391222 100644
> > --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> > @@ -267,7 +267,8 @@ RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)
> >       if (itInfo != frameInfo_.end())
> >               return itInfo->second;
> >
> > -     LOG(RkISP1, Error) << "Can't locate info from frame";
> > +     LOG(RkISP1, Fatal) << "Can't locate info from frame";
> > +
> >       return nullptr;
> >  }
> >
> > @@ -283,7 +284,8 @@ RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)
> >                       return info;
> >       }
> >
> > -     LOG(RkISP1, Error) << "Can't locate info from buffer";
> > +     LOG(RkISP1, Fatal) << "Can't locate info from buffer";
> > +
> >       return nullptr;
> >  }
> >
> > @@ -296,7 +298,8 @@ RkISP1FrameInfo *RkISP1Frames::find(Request *request)
> >                       return info;
> >       }
> >
> > -     LOG(RkISP1, Error) << "Can't locate info from request";
> > +     LOG(RkISP1, Fatal) << "Can't locate info from request";
> > +
> >       return nullptr;
> >  }
> >
>
> --
> Regards,
>
> Laurent Pinchart
> _______________________________________________
> libcamera-devel mailing list
> libcamera-devel@lists.libcamera.org
> https://lists.libcamera.org/listinfo/libcamera-devel

Patch
diff mbox series 

diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
index 549f4a4e61a8..c75666391222 100644
--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
@@ -267,7 +267,8 @@  RkISP1FrameInfo *RkISP1Frames::find(unsigned int frame)
 	if (itInfo != frameInfo_.end())
 		return itInfo->second;
 
-	LOG(RkISP1, Error) << "Can't locate info from frame";
+	LOG(RkISP1, Fatal) << "Can't locate info from frame";
+
 	return nullptr;
 }
 
@@ -283,7 +284,8 @@  RkISP1FrameInfo *RkISP1Frames::find(FrameBuffer *buffer)
 			return info;
 	}
 
-	LOG(RkISP1, Error) << "Can't locate info from buffer";
+	LOG(RkISP1, Fatal) << "Can't locate info from buffer";
+
 	return nullptr;
 }
 
@@ -296,7 +298,8 @@  RkISP1FrameInfo *RkISP1Frames::find(Request *request)
 			return info;
 	}
 
-	LOG(RkISP1, Error) << "Can't locate info from request";
+	LOG(RkISP1, Fatal) << "Can't locate info from request";
+
 	return nullptr;
 }