Patch Detail
Show a patch.
GET /api/1.1/patches/11917/?format=api
{ "id": 11917, "url": "https://patchwork.libcamera.org/api/1.1/patches/11917/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11917/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210413154907.50449-1-jacopo@jmondi.org>", "date": "2021-04-13T15:49:07", "name": "[libcamera-devel] libcamera: camera_sensor: Demote error message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "74f52f562f293c29beae2762f4167bd39f480b01", "submitter": { "id": 3, "url": "https://patchwork.libcamera.org/api/1.1/people/3/?format=api", "name": "Jacopo Mondi", "email": "jacopo@jmondi.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11917/mbox/", "series": [ { "id": 1920, "url": "https://patchwork.libcamera.org/api/1.1/series/1920/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1920", "date": "2021-04-13T15:49:07", "name": "[libcamera-devel] libcamera: camera_sensor: Demote error message", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1920/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11917/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11917/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CAF59BD1F6\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 13 Apr 2021 15:49:17 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 43B64687FE;\n\tTue, 13 Apr 2021 17:49:17 +0200 (CEST)", "from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEE6B602D1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 13 Apr 2021 17:49:15 +0200 (CEST)", "from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 5887410000B;\n\tTue, 13 Apr 2021 15:49:14 +0000 (UTC)" ], "From": "Jacopo Mondi <jacopo@jmondi.org>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 13 Apr 2021 17:49:07 +0200", "Message-Id": "<20210413154907.50449-1-jacopo@jmondi.org>", "X-Mailer": "git-send-email 2.31.1", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH] libcamera: camera_sensor: Demote error\n\tmessage", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The CameraSensor class is noisy enough in reporting the missing\nsensor driver features.\n\nDemote an error message about defaulting the active sensor area when\nretrieving the camera sensor info to a warning.\n\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/camera_sensor.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex f7ed91d990f7..2887bb69ca02 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -774,7 +774,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const\n \tint ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop);\n \tif (ret) {\n \t\tinfo->analogCrop = activeArea_;\n-\t\tLOG(CameraSensor, Error)\n+\t\tLOG(CameraSensor, Warning)\n \t\t\t<< \"The analogue crop rectangle has been defaulted to the active area size\";\n \t}\n \n", "prefixes": [ "libcamera-devel" ] }