| Message ID | 20210413154907.50449-1-jacopo@jmondi.org |
|---|---|
| State | Accepted |
| Headers | show |
| Series |
|
| Related | show |
Hi Jacopo, Thank you for the patch. On Tue, Apr 13, 2021 at 05:49:07PM +0200, Jacopo Mondi wrote: > The CameraSensor class is noisy enough in reporting the missing > sensor driver features. > > Demote an error message about defaulting the active sensor area when > retrieving the camera sensor info to a warning. > > Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > src/libcamera/camera_sensor.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp > index f7ed91d990f7..2887bb69ca02 100644 > --- a/src/libcamera/camera_sensor.cpp > +++ b/src/libcamera/camera_sensor.cpp > @@ -774,7 +774,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const > int ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop); > if (ret) { > info->analogCrop = activeArea_; > - LOG(CameraSensor, Error) > + LOG(CameraSensor, Warning) > << "The analogue crop rectangle has been defaulted to the active area size"; > } >
diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp index f7ed91d990f7..2887bb69ca02 100644 --- a/src/libcamera/camera_sensor.cpp +++ b/src/libcamera/camera_sensor.cpp @@ -774,7 +774,7 @@ int CameraSensor::sensorInfo(CameraSensorInfo *info) const int ret = subdev_->getSelection(pad_, V4L2_SEL_TGT_CROP, &info->analogCrop); if (ret) { info->analogCrop = activeArea_; - LOG(CameraSensor, Error) + LOG(CameraSensor, Warning) << "The analogue crop rectangle has been defaulted to the active area size"; }
The CameraSensor class is noisy enough in reporting the missing sensor driver features. Demote an error message about defaulting the active sensor area when retrieving the camera sensor info to a warning. Signed-off-by: Jacopo Mondi <jacopo@jmondi.org> --- src/libcamera/camera_sensor.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)