Patch Detail
Show a patch.
GET /api/1.1/patches/11563/?format=api
{ "id": 11563, "url": "https://patchwork.libcamera.org/api/1.1/patches/11563/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11563/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210312061131.854849-4-kieran.bingham@ideasonboard.com>", "date": "2021-03-12T06:11:26", "name": "[libcamera-devel,3/8] libcamera: pipeline: ipu3: Reset sequence counts to zero on stop", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "f2ca4c47cdf2507dfd9e7aeddf5375f6d20afa0f", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/1.1/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": { "id": 11, "url": "https://patchwork.libcamera.org/api/1.1/users/11/?format=api", "username": "kbingham", "first_name": "Kieran", "last_name": "Bingham", "email": "kieran.bingham@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/patch/11563/mbox/", "series": [ { "id": 1786, "url": "https://patchwork.libcamera.org/api/1.1/series/1786/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1786", "date": "2021-03-12T06:11:23", "name": "IPU3 Debug improvements", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1786/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11563/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11563/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 54F37BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Mar 2021 06:11:41 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A02A668C77;\n\tFri, 12 Mar 2021 07:11:40 +0100 (CET)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8B7E602ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)", "from localhost.localdomain\n\t(cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 80695A2A;\n\tFri, 12 Mar 2021 07:11:36 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HHetBgmJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1615529496;\n\tbh=yytt+4azPIqoYR4s4qT2V1wzg8BBRWKQN5WkdQJsu3A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HHetBgmJ/ch0tMsopHdgynsZ/CCd16GhlhQ0jQGBt7VqXjD0RsJJeEoX5dwFFRVdk\n\ta9ehQaWcCgFdqLLXDkXpv/hO7i4eMgQhpdCgFHBSYhvyEv/m4YHZu4cJYfDjGTSXRO\n\tYTY/1Mk+7I1z6ytybeZsLG8DwMmRtomPgrCEeENM=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Date": "Fri, 12 Mar 2021 06:11:26 +0000", "Message-Id": "<20210312061131.854849-4-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "References": "<20210312061131.854849-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 3/8] libcamera: pipeline: ipu3: Reset\n\tsequence counts to zero on stop", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Reset the request sequence counter back to zero when a camera has\nstopped, giving each camera run an independent sequence stream.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\n---\nRFC: This again would be perhaps better handled by the base class to\nensure all pipeline handlers handle this in a consistent manner.\n\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++\n 1 file changed, 2 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex a61e2b51ef9e..3d3bd4a43c23 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -780,6 +780,8 @@ void PipelineHandlerIPU3::stop(Camera *camera)\n \t\tLOG(IPU3, Fatal) << \"There are still requests to complete.\";\n \n \tfreeBuffers(camera);\n+\n+\tdata->requestSequence_ = 0;\n }\n \n int PipelineHandlerIPU3::queueRequestDevice(Camera *camera, Request *request)\n", "prefixes": [ "libcamera-devel", "3/8" ] }