From patchwork Fri Mar 12 06:11:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 11563 X-Patchwork-Delegate: kieran.bingham@ideasonboard.com Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 54F37BD1F1 for ; Fri, 12 Mar 2021 06:11:41 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id A02A668C77; Fri, 12 Mar 2021 07:11:40 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="HHetBgmJ"; dkim-atps=neutral Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id E8B7E602ED for ; Fri, 12 Mar 2021 07:11:36 +0100 (CET) Received: from localhost.localdomain (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 80695A2A; Fri, 12 Mar 2021 07:11:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615529496; bh=yytt+4azPIqoYR4s4qT2V1wzg8BBRWKQN5WkdQJsu3A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HHetBgmJ/ch0tMsopHdgynsZ/CCd16GhlhQ0jQGBt7VqXjD0RsJJeEoX5dwFFRVdk a9ehQaWcCgFdqLLXDkXpv/hO7i4eMgQhpdCgFHBSYhvyEv/m4YHZu4cJYfDjGTSXRO YTY/1Mk+7I1z6ytybeZsLG8DwMmRtomPgrCEeENM= From: Kieran Bingham To: libcamera devel Date: Fri, 12 Mar 2021 06:11:26 +0000 Message-Id: <20210312061131.854849-4-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210312061131.854849-1-kieran.bingham@ideasonboard.com> References: <20210312061131.854849-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 3/8] libcamera: pipeline: ipu3: Reset sequence counts to zero on stop X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" Reset the request sequence counter back to zero when a camera has stopped, giving each camera run an independent sequence stream. Signed-off-by: Kieran Bingham --- RFC: This again would be perhaps better handled by the base class to ensure all pipeline handlers handle this in a consistent manner. src/libcamera/pipeline/ipu3/ipu3.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp index a61e2b51ef9e..3d3bd4a43c23 100644 --- a/src/libcamera/pipeline/ipu3/ipu3.cpp +++ b/src/libcamera/pipeline/ipu3/ipu3.cpp @@ -780,6 +780,8 @@ void PipelineHandlerIPU3::stop(Camera *camera) LOG(IPU3, Fatal) << "There are still requests to complete."; freeBuffers(camera); + + data->requestSequence_ = 0; } int PipelineHandlerIPU3::queueRequestDevice(Camera *camera, Request *request)