Patch Detail
Show a patch.
GET /api/1.1/patches/11348/?format=api
{ "id": 11348, "url": "https://patchwork.libcamera.org/api/1.1/patches/11348/?format=api", "web_url": "https://patchwork.libcamera.org/patch/11348/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20210220100608.14267-1-dave@bewaar.me>", "date": "2021-02-20T10:06:08", "name": "[libcamera-devel] libcamera: pipeline: ipu3: change IF_CROP_MAX to 40", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "6f0a55b6aa85e315c49dfc00391ce351802cbb4d", "submitter": { "id": 82, "url": "https://patchwork.libcamera.org/api/1.1/people/82/?format=api", "name": "Dave Olsthoorn", "email": "dave@bewaar.me" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/11348/mbox/", "series": [ { "id": 1712, "url": "https://patchwork.libcamera.org/api/1.1/series/1712/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1712", "date": "2021-02-20T10:06:08", "name": "[libcamera-devel] libcamera: pipeline: ipu3: change IF_CROP_MAX to 40", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1712/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/11348/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/11348/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C1726BD1F1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat, 20 Feb 2021 14:50:52 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A42E689B3;\n\tSat, 20 Feb 2021 15:50:52 +0100 (CET)", "from outbound4.mail.transip.nl (outbound4.mail.transip.nl\n\t[IPv6:2a01:7c8:7c9:ca11:136:144:136:2])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C5EDD689B3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 20 Feb 2021 11:06:29 +0100 (CET)", "from submission8.mail.transip.nl (unknown [10.103.8.159])\n\tby outbound4.mail.transip.nl (Postfix) with ESMTP id 4DjPH92MK2zR7l; \n\tSat, 20 Feb 2021 11:06:29 +0100 (CET)", "from oppervlak.thuis.lan (201-101-158-163.dynamic.caiway.nl\n\t[163.158.101.201])\n\tby submission8.mail.transip.nl (Postfix) with ESMTPA id\n\t4DjPH76vDnz2ZNrV; Sat, 20 Feb 2021 11:06:26 +0100 (CET)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=bewaar.me header.i=@bewaar.me\n\theader.b=\"EaK1gRvp\"; dkim-atps=neutral", "From": "Dave Olsthoorn <dave@bewaar.me>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 20 Feb 2021 11:06:08 +0100", "Message-Id": "<20210220100608.14267-1-dave@bewaar.me>", "X-Mailer": "git-send-email 2.29.2", "MIME-Version": "1.0", "X-Scanned-By": "ClueGetter at submission8.mail.transip.nl", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\ts=transip-a; d=bewaar.me; t=1613815588; h=from:subject:to:cc:date:\n\tmime-version; bh=VYdsaoLP8OQHW61mMwfmNTk3BoZQVeTaDRp8irrLDvI=;\n\tb=EaK1gRvpVH2KKtco/NbkqC7WNELU10Vw/Czd1+AOSHNrnEbLsdxa0j3hbo2soOkMT5Eoxa\n\tc6FfQgFJrq1N8oieepPeg+q/JMYiSgBJ5zWMMtoGPlITHanfI0K7gB5u9QSy1yuJGMlQaL\n\tCHcGMM2RFhRlNabNYZb3LirAE8Jqy9SD2VFAf21PvdO4DM7OqZ/GtJOTNAFP3yHESTKxoY\n\tVBWQyQowc6p+dPrBJ3kRrzIqQ/zoZfrBWW4nodr0RBCWd1sd4okxOZjDf8fj0u7EitGnZx\n\tCFhYIY0DYI5+ei7Fr8OdTk4WAhoglsPXflSR9nYDg6YXLOHREbTAeACxV6hdzw==", "X-Report-Abuse-To": "abuse@transip.nl", "X-Mailman-Approved-At": "Sat, 20 Feb 2021 15:50:50 +0100", "Subject": "[libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change\n\tIF_CROP_MAX to 40", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Cc": "Dave Olsthoorn <dave@bewaar.me>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 seems\nunlikely and excludes camera's with a 640x480 resolution, like the OV7251\nin several Microsoft Surface products, from working.\n\nThis patch corrects the value to 40 since a minimal resolution of 40x40\nseems more logical.\n---\n src/libcamera/pipeline/ipu3/imgu.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp\nindex d5cf05b0..fb995008 100644\n--- a/src/libcamera/pipeline/ipu3/imgu.cpp\n+++ b/src/libcamera/pipeline/ipu3/imgu.cpp\n@@ -42,7 +42,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2;\n static constexpr unsigned int BDS_ALIGN_H = 4;\n \n static constexpr unsigned int IF_CROP_MAX_W = 40;\n-static constexpr unsigned int IF_CROP_MAX_H = 540;\n+static constexpr unsigned int IF_CROP_MAX_H = 40;\n \n static constexpr float BDS_SF_MAX = 2.5;\n static constexpr float BDS_SF_MIN = 1.0;\n", "prefixes": [ "libcamera-devel" ] }