From patchwork Sat Feb 20 10:06:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dave Olsthoorn X-Patchwork-Id: 11348 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id C1726BD1F1 for ; Sat, 20 Feb 2021 14:50:52 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3A42E689B3; Sat, 20 Feb 2021 15:50:52 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bewaar.me header.i=@bewaar.me header.b="EaK1gRvp"; dkim-atps=neutral Received: from outbound4.mail.transip.nl (outbound4.mail.transip.nl [IPv6:2a01:7c8:7c9:ca11:136:144:136:2]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id C5EDD689B3 for ; Sat, 20 Feb 2021 11:06:29 +0100 (CET) Received: from submission8.mail.transip.nl (unknown [10.103.8.159]) by outbound4.mail.transip.nl (Postfix) with ESMTP id 4DjPH92MK2zR7l; Sat, 20 Feb 2021 11:06:29 +0100 (CET) Received: from oppervlak.thuis.lan (201-101-158-163.dynamic.caiway.nl [163.158.101.201]) by submission8.mail.transip.nl (Postfix) with ESMTPA id 4DjPH76vDnz2ZNrV; Sat, 20 Feb 2021 11:06:26 +0100 (CET) From: Dave Olsthoorn To: libcamera-devel@lists.libcamera.org Date: Sat, 20 Feb 2021 11:06:08 +0100 Message-Id: <20210220100608.14267-1-dave@bewaar.me> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 X-Scanned-By: ClueGetter at submission8.mail.transip.nl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=transip-a; d=bewaar.me; t=1613815588; h=from:subject:to:cc:date: mime-version; bh=VYdsaoLP8OQHW61mMwfmNTk3BoZQVeTaDRp8irrLDvI=; b=EaK1gRvpVH2KKtco/NbkqC7WNELU10Vw/Czd1+AOSHNrnEbLsdxa0j3hbo2soOkMT5Eoxa c6FfQgFJrq1N8oieepPeg+q/JMYiSgBJ5zWMMtoGPlITHanfI0K7gB5u9QSy1yuJGMlQaL CHcGMM2RFhRlNabNYZb3LirAE8Jqy9SD2VFAf21PvdO4DM7OqZ/GtJOTNAFP3yHESTKxoY VBWQyQowc6p+dPrBJ3kRrzIqQ/zoZfrBWW4nodr0RBCWd1sd4okxOZjDf8fj0u7EitGnZx CFhYIY0DYI5+ei7Fr8OdTk4WAhoglsPXflSR9nYDg6YXLOHREbTAeACxV6hdzw== X-Report-Abuse-To: abuse@transip.nl X-Mailman-Approved-At: Sat, 20 Feb 2021 15:50:50 +0100 Subject: [libcamera-devel] [PATCH] libcamera: pipeline: ipu3: change IF_CROP_MAX to 40 X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Olsthoorn Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The value of IF_CROP_MAX seems to be a typo. A resolution of 40x540 seems unlikely and excludes camera's with a 640x480 resolution, like the OV7251 in several Microsoft Surface products, from working. This patch corrects the value to 40 since a minimal resolution of 40x40 seems more logical. Signed-off-by: Dave Olsthoorn --- src/libcamera/pipeline/ipu3/imgu.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libcamera/pipeline/ipu3/imgu.cpp b/src/libcamera/pipeline/ipu3/imgu.cpp index d5cf05b0..fb995008 100644 --- a/src/libcamera/pipeline/ipu3/imgu.cpp +++ b/src/libcamera/pipeline/ipu3/imgu.cpp @@ -42,7 +42,7 @@ static constexpr unsigned int BDS_ALIGN_W = 2; static constexpr unsigned int BDS_ALIGN_H = 4; static constexpr unsigned int IF_CROP_MAX_W = 40; -static constexpr unsigned int IF_CROP_MAX_H = 540; +static constexpr unsigned int IF_CROP_MAX_H = 40; static constexpr float BDS_SF_MAX = 2.5; static constexpr float BDS_SF_MIN = 1.0;