Patch Detail
Show a patch.
GET /api/1.1/patches/10540/?format=api
{ "id": 10540, "url": "https://patchwork.libcamera.org/api/1.1/patches/10540/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10540/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201201175536.11093-6-david.plowman@raspberrypi.com>", "date": "2020-12-01T17:55:36", "name": "[libcamera-devel,v4,5/5] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "94ad3560d8abf3c20c8a2be5b9dc3e2829a59a53", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10540/mbox/", "series": [ { "id": 1499, "url": "https://patchwork.libcamera.org/api/1.1/series/1499/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1499", "date": "2020-12-01T17:55:31", "name": "Raspberry Pi AGC improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1499/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10540/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10540/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 31960BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Dec 2020 17:55:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F29CC63503;\n\tTue, 1 Dec 2020 18:55:49 +0100 (CET)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CF3C363503\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Dec 2020 18:55:47 +0100 (CET)", "by mail-wr1-x432.google.com with SMTP id 64so4013352wra.11\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 01 Dec 2020 09:55:47 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl3sm438561wrr.89.2020.12.01.09.55.46\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 01 Dec 2020 09:55:46 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"BskxjTdb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=1IhhX9Kxp2LTXRJWgP4dKUm1Yko7iAPqLiD2A8MLxcI=;\n\tb=BskxjTdbHdpFISwKssg5t2X9tqWz9kmtmrITwqLXOWIKCme6bi93rNzNrWFOF817vy\n\tmL7V4opx7kwxtrlvY2GVeI3Hwwgsv7UGIRGUUhRWphf9dl1R/ROmOScxbf0Hsk9JL72s\n\tMhl6mJzvSP8fVh+QpupqxMdXTeCAP+FWcKWsK9bqb+ZY3dtWsxdIW5iTXV57idh8cRO1\n\tZLuDvPyn16eTg8a57VGz6IlgCL+fYmCHQwjL1OwGtwfHSkP2Vc9Bs1h6bZM1MCNyvydh\n\tAxfmh8cpRDQjEaao5imx3lHSU6IVkgE8uhI3O4qv0OsHYKpWowe5VDYUzdc7Icn2tKzf\n\tG7+w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=1IhhX9Kxp2LTXRJWgP4dKUm1Yko7iAPqLiD2A8MLxcI=;\n\tb=krbdzwS9SFzAAFqui4t+qzNSZpJyU8KkQ6z/rJu5aq71d+2zjaQI7AaKjmIQ/BX6qK\n\t1DduApmG+8KnxzavErt6RH98vsu4AD9TfCnB83sAQsKf+dQ2ZV1mM+9ZRa99YJtbu2r/\n\tX+d+E9C5ur7IaQ3YANStmkaAqHVJMCjS7sovJceb/6bSjD6ZNGHIn6VZ7JmSeL6U9zMf\n\tDGh+Hy7Mz/BMKKgK2OaclSBGJeiKn2amStlIrW0rLU72OtJDzm+PW7zApDrTXbZLLY6Z\n\thPO9nwFJwtVOLLj8oNLtbU8ypwxZ69uVAQXgqfKXOD899QKj8yLZQDyi+ySKc4FMUaos\n\tYdng==", "X-Gm-Message-State": "AOAM533RJNanDDKFTK8lXfxwHJFc1zGPScaxjh3soLqmB7JCiUwX5l4v\n\tjHmKZY2lF5IsnpDa3OGCmIkjglahvQuDG4wp", "X-Google-Smtp-Source": "ABdhPJxF12yNmBYENuhBCScw13XdA0cJzuw+FAFnyrMMEIO7i21D7j7dqu68F8WzlEEeAsH8rgDkWg==", "X-Received": "by 2002:a5d:5604:: with SMTP id l4mr5357185wrv.127.1606845347408;\n\tTue, 01 Dec 2020 09:55:47 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 1 Dec 2020 17:55:36 +0000", "Message-Id": "<20201201175536.11093-6-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201201175536.11093-1-david.plowman@raspberrypi.com>", "References": "<20201201175536.11093-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 5/5] src: ipa: raspberrypi: Fix initial\n\tAGC oscillation for imx219 sensor", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The exposure times in the exposure modes were causing AGC oscillations\nbecause the algorithm was demanding long unachievable exposure times\nbut, without working sensor metadata, thought it was getting them when\nactually it was not. We fix it by making the exposure profile request\nonly achievable exposure times, as we do for the ov5647 tuning.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/ipa/raspberrypi/data/imx219.json | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json\nindex b03a7beb..212f8b9a 100644\n--- a/src/ipa/raspberrypi/data/imx219.json\n+++ b/src/ipa/raspberrypi/data/imx219.json\n@@ -133,7 +133,7 @@\n {\n \"shutter\":\n [\n- 100, 10000, 30000, 60000, 120000\n+ 100, 10000, 30000, 30000, 30000\n ],\n \"gain\":\n [\n@@ -144,7 +144,7 @@\n {\n \"shutter\":\n [\n- 100, 5000, 10000, 20000, 120000\n+ 100, 5000, 10000, 20000, 30000\n ],\n \"gain\":\n [\n", "prefixes": [ "libcamera-devel", "v4", "5/5" ] }