From patchwork Tue Dec 1 17:55:36 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10540 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 31960BE176 for ; Tue, 1 Dec 2020 17:55:50 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id F29CC63503; Tue, 1 Dec 2020 18:55:49 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BskxjTdb"; dkim-atps=neutral Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id CF3C363503 for ; Tue, 1 Dec 2020 18:55:47 +0100 (CET) Received: by mail-wr1-x432.google.com with SMTP id 64so4013352wra.11 for ; Tue, 01 Dec 2020 09:55:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=1IhhX9Kxp2LTXRJWgP4dKUm1Yko7iAPqLiD2A8MLxcI=; b=BskxjTdbHdpFISwKssg5t2X9tqWz9kmtmrITwqLXOWIKCme6bi93rNzNrWFOF817vy mL7V4opx7kwxtrlvY2GVeI3Hwwgsv7UGIRGUUhRWphf9dl1R/ROmOScxbf0Hsk9JL72s Mhl6mJzvSP8fVh+QpupqxMdXTeCAP+FWcKWsK9bqb+ZY3dtWsxdIW5iTXV57idh8cRO1 ZLuDvPyn16eTg8a57VGz6IlgCL+fYmCHQwjL1OwGtwfHSkP2Vc9Bs1h6bZM1MCNyvydh Axfmh8cpRDQjEaao5imx3lHSU6IVkgE8uhI3O4qv0OsHYKpWowe5VDYUzdc7Icn2tKzf G7+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1IhhX9Kxp2LTXRJWgP4dKUm1Yko7iAPqLiD2A8MLxcI=; b=krbdzwS9SFzAAFqui4t+qzNSZpJyU8KkQ6z/rJu5aq71d+2zjaQI7AaKjmIQ/BX6qK 1DduApmG+8KnxzavErt6RH98vsu4AD9TfCnB83sAQsKf+dQ2ZV1mM+9ZRa99YJtbu2r/ X+d+E9C5ur7IaQ3YANStmkaAqHVJMCjS7sovJceb/6bSjD6ZNGHIn6VZ7JmSeL6U9zMf DGh+Hy7Mz/BMKKgK2OaclSBGJeiKn2amStlIrW0rLU72OtJDzm+PW7zApDrTXbZLLY6Z hPO9nwFJwtVOLLj8oNLtbU8ypwxZ69uVAQXgqfKXOD899QKj8yLZQDyi+ySKc4FMUaos Ydng== X-Gm-Message-State: AOAM533RJNanDDKFTK8lXfxwHJFc1zGPScaxjh3soLqmB7JCiUwX5l4v jHmKZY2lF5IsnpDa3OGCmIkjglahvQuDG4wp X-Google-Smtp-Source: ABdhPJxF12yNmBYENuhBCScw13XdA0cJzuw+FAFnyrMMEIO7i21D7j7dqu68F8WzlEEeAsH8rgDkWg== X-Received: by 2002:a5d:5604:: with SMTP id l4mr5357185wrv.127.1606845347408; Tue, 01 Dec 2020 09:55:47 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l3sm438561wrr.89.2020.12.01.09.55.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 09:55:46 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Dec 2020 17:55:36 +0000 Message-Id: <20201201175536.11093-6-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201201175536.11093-1-david.plowman@raspberrypi.com> References: <20201201175536.11093-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 5/5] src: ipa: raspberrypi: Fix initial AGC oscillation for imx219 sensor X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The exposure times in the exposure modes were causing AGC oscillations because the algorithm was demanding long unachievable exposure times but, without working sensor metadata, thought it was getting them when actually it was not. We fix it by making the exposure profile request only achievable exposure times, as we do for the ov5647 tuning. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck Reviewed-by: Laurent Pinchart Reviewed-by: Kieran Bingham --- src/ipa/raspberrypi/data/imx219.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json index b03a7beb..212f8b9a 100644 --- a/src/ipa/raspberrypi/data/imx219.json +++ b/src/ipa/raspberrypi/data/imx219.json @@ -133,7 +133,7 @@ { "shutter": [ - 100, 10000, 30000, 60000, 120000 + 100, 10000, 30000, 30000, 30000 ], "gain": [ @@ -144,7 +144,7 @@ { "shutter": [ - 100, 5000, 10000, 20000, 120000 + 100, 5000, 10000, 20000, 30000 ], "gain": [