Patch Detail
Show a patch.
GET /api/1.1/patches/10538/?format=api
{ "id": 10538, "url": "https://patchwork.libcamera.org/api/1.1/patches/10538/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10538/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201201175536.11093-4-david.plowman@raspberrypi.com>", "date": "2020-12-01T17:55:34", "name": "[libcamera-devel,v4,3/5] src: ipa: raspberrypi: Improve behaviour when AE disabled", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "0687016ed4b5afb825c4cf68ccb27ee98f22ef1d", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10538/mbox/", "series": [ { "id": 1499, "url": "https://patchwork.libcamera.org/api/1.1/series/1499/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1499", "date": "2020-12-01T17:55:31", "name": "Raspberry Pi AGC improvements", "version": 4, "mbox": "https://patchwork.libcamera.org/series/1499/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10538/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10538/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 92D23BE176\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Dec 2020 17:55:47 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3549F6350F;\n\tTue, 1 Dec 2020 18:55:47 +0100 (CET)", "from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D136D63507\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Dec 2020 18:55:45 +0100 (CET)", "by mail-wm1-x334.google.com with SMTP id k10so5163549wmi.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 01 Dec 2020 09:55:45 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl3sm438561wrr.89.2020.12.01.09.55.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 01 Dec 2020 09:55:44 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"sp4Qkzb4\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=QUSybnUtj7GW9ZjPR+j3KFbT+EDJ6U5W05X8JBEXZyw=;\n\tb=sp4Qkzb4h4MD5owE2IEuoYdvuPxE73Qua3UVNooGtaQLxfYd9uVuQnWRzpEaz7HvHG\n\tMr1acRnYjnh8Ij2LV3M0Hjbc6Fjaxf4LV2b1KvNbjNcZDjx+iXcg1+xC5jbuvVEuez+v\n\tc2tuRevlBC4x1kDpRC4Q39tCYt7vYS+XdYiyLDT8vSgbox1H+L2UJTgrULeoCzuPjTPK\n\tr4LO53ekPcJhT75529stXtOBRXNVjKplNu3ZO34X5uNmaqKVpYSOYMf4rgGT64OXmkl7\n\tZstyVF4Z93HETVjxl48Olh6k5x30YxgPt3g37jTmVSoOjrjFTjjmo566ZjvWcm1y2Jvc\n\tQYwA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=QUSybnUtj7GW9ZjPR+j3KFbT+EDJ6U5W05X8JBEXZyw=;\n\tb=ZwU/RleuawA3nlFT+aYVc9Imzg7XkwG9Bp9tCCAO9pT23pdfZUa6cv8jEfqq3jXqEq\n\tvX6P2esr9d9y2JjeZLAPOChsSwZETGxXSTW27OZQ5NqOfVnhPEqRlN3v83rvmNdgqnVx\n\tGDCbOHOwXqVxEjbQELYBumKDeGXUuwStYqVHuLEvhQ96xB68aupsgRE2wsrYwrqHun0F\n\tGBmtexhxxD650Nwc0N/UanFBl6N0dQ4NwcR/UKimGqG2jgpzldPZbZt00vS76vsmT6CY\n\tgsE9ECe57BBdm69C+WvlyQUtuZUB0YOZYuzT3YbkBndrfkXcC/2MMsxGJARf6v3ioaIG\n\tJRQQ==", "X-Gm-Message-State": "AOAM530ROLtF2OgCHgVGODngJQhr0MfjMOBvUrJ6zykOnXiPlTYR1uLn\n\tUlL5nMkLW5XhserA5ZE9v5kd1FXD/8IlFjlP", "X-Google-Smtp-Source": "ABdhPJyy15hYeKrrAuhrQv+NV1kMoI2b+OkQiMg+6Hx4VavHr9sJ4PrdpnF1GgLEqoyxFbH9BUaQRg==", "X-Received": "by 2002:a1c:1fc4:: with SMTP id\n\tf187mr3834216wmf.107.1606845345356; \n\tTue, 01 Dec 2020 09:55:45 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Tue, 1 Dec 2020 17:55:34 +0000", "Message-Id": "<20201201175536.11093-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201201175536.11093-1-david.plowman@raspberrypi.com>", "References": "<20201201175536.11093-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH v4 3/5] src: ipa: raspberrypi: Improve\n\tbehaviour when AE disabled", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "AE/AGC \"disabled\" is now handled better by the algorithm for itself,\nso it no longer needs to be \"resumed\" before setting fixed shutter or\ngain values.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/ipa/raspberrypi/raspberrypi.cpp | 8 --------\n 1 file changed, 8 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex 9853a343..29d48b1b 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\t/* This expects units of micro-seconds. */\n \t\t\tagc->SetFixedShutter(ctrl.second.get<int32_t>());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::ExposureTime, ctrl.second.get<int32_t>());\n \t\t\tbreak;\n \t\t}\n@@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls)\n \t\t\tASSERT(agc);\n \t\t\tagc->SetFixedAnalogueGain(ctrl.second.get<float>());\n \n-\t\t\t/* For the manual values to take effect, AGC must be unpaused. */\n-\t\t\tif (agc->IsPaused())\n-\t\t\t\tagc->Resume();\n-\n \t\t\tlibcameraMetadata_.set(controls::AnalogueGain,\n \t\t\t\t\t ctrl.second.get<float>());\n \t\t\tbreak;\n", "prefixes": [ "libcamera-devel", "v4", "3/5" ] }