From patchwork Tue Dec 1 17:55:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10538 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id 92D23BE176 for ; Tue, 1 Dec 2020 17:55:47 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 3549F6350F; Tue, 1 Dec 2020 18:55:47 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="sp4Qkzb4"; dkim-atps=neutral Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id D136D63507 for ; Tue, 1 Dec 2020 18:55:45 +0100 (CET) Received: by mail-wm1-x334.google.com with SMTP id k10so5163549wmi.3 for ; Tue, 01 Dec 2020 09:55:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QUSybnUtj7GW9ZjPR+j3KFbT+EDJ6U5W05X8JBEXZyw=; b=sp4Qkzb4h4MD5owE2IEuoYdvuPxE73Qua3UVNooGtaQLxfYd9uVuQnWRzpEaz7HvHG Mr1acRnYjnh8Ij2LV3M0Hjbc6Fjaxf4LV2b1KvNbjNcZDjx+iXcg1+xC5jbuvVEuez+v c2tuRevlBC4x1kDpRC4Q39tCYt7vYS+XdYiyLDT8vSgbox1H+L2UJTgrULeoCzuPjTPK r4LO53ekPcJhT75529stXtOBRXNVjKplNu3ZO34X5uNmaqKVpYSOYMf4rgGT64OXmkl7 ZstyVF4Z93HETVjxl48Olh6k5x30YxgPt3g37jTmVSoOjrjFTjjmo566ZjvWcm1y2Jvc QYwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QUSybnUtj7GW9ZjPR+j3KFbT+EDJ6U5W05X8JBEXZyw=; b=ZwU/RleuawA3nlFT+aYVc9Imzg7XkwG9Bp9tCCAO9pT23pdfZUa6cv8jEfqq3jXqEq vX6P2esr9d9y2JjeZLAPOChsSwZETGxXSTW27OZQ5NqOfVnhPEqRlN3v83rvmNdgqnVx GDCbOHOwXqVxEjbQELYBumKDeGXUuwStYqVHuLEvhQ96xB68aupsgRE2wsrYwrqHun0F GBmtexhxxD650Nwc0N/UanFBl6N0dQ4NwcR/UKimGqG2jgpzldPZbZt00vS76vsmT6CY gsE9ECe57BBdm69C+WvlyQUtuZUB0YOZYuzT3YbkBndrfkXcC/2MMsxGJARf6v3ioaIG JRQQ== X-Gm-Message-State: AOAM530ROLtF2OgCHgVGODngJQhr0MfjMOBvUrJ6zykOnXiPlTYR1uLn UlL5nMkLW5XhserA5ZE9v5kd1FXD/8IlFjlP X-Google-Smtp-Source: ABdhPJyy15hYeKrrAuhrQv+NV1kMoI2b+OkQiMg+6Hx4VavHr9sJ4PrdpnF1GgLEqoyxFbH9BUaQRg== X-Received: by 2002:a1c:1fc4:: with SMTP id f187mr3834216wmf.107.1606845345356; Tue, 01 Dec 2020 09:55:45 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id l3sm438561wrr.89.2020.12.01.09.55.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Dec 2020 09:55:44 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Tue, 1 Dec 2020 17:55:34 +0000 Message-Id: <20201201175536.11093-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201201175536.11093-1-david.plowman@raspberrypi.com> References: <20201201175536.11093-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH v4 3/5] src: ipa: raspberrypi: Improve behaviour when AE disabled X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" AE/AGC "disabled" is now handled better by the algorithm for itself, so it no longer needs to be "resumed" before setting fixed shutter or gain values. Signed-off-by: David Plowman Reviewed-by: Kieran Bingham Reviewed-by: Naushir Patuck Reviewed-by: Laurent Pinchart --- src/ipa/raspberrypi/raspberrypi.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp index 9853a343..29d48b1b 100644 --- a/src/ipa/raspberrypi/raspberrypi.cpp +++ b/src/ipa/raspberrypi/raspberrypi.cpp @@ -512,10 +512,6 @@ void IPARPi::queueRequest(const ControlList &controls) /* This expects units of micro-seconds. */ agc->SetFixedShutter(ctrl.second.get()); - /* For the manual values to take effect, AGC must be unpaused. */ - if (agc->IsPaused()) - agc->Resume(); - libcameraMetadata_.set(controls::ExposureTime, ctrl.second.get()); break; } @@ -526,10 +522,6 @@ void IPARPi::queueRequest(const ControlList &controls) ASSERT(agc); agc->SetFixedAnalogueGain(ctrl.second.get()); - /* For the manual values to take effect, AGC must be unpaused. */ - if (agc->IsPaused()) - agc->Resume(); - libcameraMetadata_.set(controls::AnalogueGain, ctrl.second.get()); break;