Patch Detail
Show a patch.
GET /api/1.1/patches/10432/?format=api
{ "id": 10432, "url": "https://patchwork.libcamera.org/api/1.1/patches/10432/?format=api", "web_url": "https://patchwork.libcamera.org/patch/10432/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20201116164918.2055-4-david.plowman@raspberrypi.com>", "date": "2020-11-16T16:49:11", "name": "[libcamera-devel,03/10] libcamera: ipa: raspberrypi: agc: Rename method to divideUpExposure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "46233b4282d658ee74c95f710abca03dee97b100", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/1.1/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/10432/mbox/", "series": [ { "id": 1464, "url": "https://patchwork.libcamera.org/api/1.1/series/1464/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=1464", "date": "2020-11-16T16:49:08", "name": "Raspberry Pi AGC", "version": 1, "mbox": "https://patchwork.libcamera.org/series/1464/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/10432/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/10432/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CEE34BE082\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Nov 2020 16:49:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8B5C9632D5;\n\tMon, 16 Nov 2020 17:49:29 +0100 (CET)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A72B9632C8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Nov 2020 17:49:27 +0100 (CET)", "by mail-wm1-x32b.google.com with SMTP id c9so24343733wml.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Nov 2020 08:49:27 -0800 (PST)", "from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tq16sm23716973wrn.13.2020.11.16.08.49.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 16 Nov 2020 08:49:26 -0800 (PST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"GNN1Gkod\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=xqNctcBDmlL2x/krLkjaVmnpGJIy8M2P+aQ68PdFEbc=;\n\tb=GNN1GkodywIzjUO31ylKH+L9oKeuTQ3B2Nuk4PQLjNbYegE93B+GQuGoWhEd9w4+1L\n\tlvsI+S0g+3WJUoyXgpoLTfnwTZZTbnUeSgvFklk96IlXd5JmSkuGNP4I96anbwPE4y+e\n\tGcFoE5ftb9yv5tKTeHp693PtMogAM1GQZ8aA0NlVygu0/NWgBKB7zfaHXGDj4TAbCEiY\n\tjw2vvbGfO8STfL2LYheAMqpZcJTG3YkIvvXW29DcvZFnlAqUSNw2UEr6svuMrCcBG9D8\n\tpXUQje/92FurOe5Z8PlOcz14U4NUS1qV8XI7mhW3WZVpD6FN2f3oEBNikwsKwXMESEdg\n\tEK/Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=xqNctcBDmlL2x/krLkjaVmnpGJIy8M2P+aQ68PdFEbc=;\n\tb=iBQwOAoqTgeI4BkJfMRIQG/lo16ryy3ok/BOi2ZLQv50VVArYEbMwSQnnQX9uhC/3R\n\tQR+/CAoqfjlEjTXqi6M5R0H0xknk4vxbAsDt4mInhUygNZuyuFdW4NGk5rnkT5tDdtdQ\n\t1wTThtTrbVREcqrLJeUsZ5+/B03U2NDlO1/0hUWZw+5jfsp4UTRnzeqQk2haLx7Rddy0\n\tAXm9IOnXThV4oDA2NbuAasoUcydvt673f6hgaoRSX0F0Det0Jb6c59Vi8CJhaxE2+UBF\n\tdFZeoEFa/r2WQHK6Gz+h4ugEsWs8l4i1mI4FB51IrCcwyXV3Wledwf+LNtaQPY74q9U0\n\tuxdQ==", "X-Gm-Message-State": "AOAM53382qP+SG2bEwQrLKi2a2Xi8GlRTZy8kq9zoUdEmLA0JQ5sgXvq\n\tN9o3cF8OFUdAJLWQTQCqzVZSAMGHq30/MA==", "X-Google-Smtp-Source": "ABdhPJyGBt+eIZh1+23sLrpAA+yi2KhKL1E0+q1wAjVpLx9OsMtjjqcqPYgHOofu2DEi33BZe/db8g==", "X-Received": "by 2002:a1c:99d3:: with SMTP id\n\tb202mr16116727wme.0.1605545367120; \n\tMon, 16 Nov 2020 08:49:27 -0800 (PST)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Mon, 16 Nov 2020 16:49:11 +0000", "Message-Id": "<20201116164918.2055-4-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20201116164918.2055-1-david.plowman@raspberrypi.com>", "References": "<20201116164918.2055-1-david.plowman@raspberrypi.com>", "MIME-Version": "1.0", "Subject": "[libcamera-devel] [PATCH 03/10] libcamera: ipa: raspberrypi: agc:\n\tRename method to divideUpExposure", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The method formerly known as divvyupExposure is given a more\nunderstandable name.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 ++++----\n src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +-\n 2 files changed, 5 insertions(+), 5 deletions(-)", "diff": "diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp\nindex c4379b99..d29b1156 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp\n@@ -225,7 +225,7 @@ void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode,\n \t// write the results into the metadata we've been given.\n \tif (status_.total_exposure_value) {\n \t\thousekeepConfig();\n-\t\tdivvyupExposure();\n+\t\tdivideUpExposure();\n \t\twriteAndFinish(metadata, false);\n \t}\n }\n@@ -304,9 +304,9 @@ void Agc::Process(StatisticsPtr &stats, Metadata *image_metadata)\n \tbool desaturate = applyDigitalGain(image_metadata, gain, target_Y);\n \t// The results have to be filtered so as not to change too rapidly.\n \tfilterExposure(desaturate);\n-\t// The last thing is to divvy up the exposure value into a shutter time\n+\t// The last thing is to divide up the exposure value into a shutter time\n \t// and analogue_gain, according to the current exposure mode.\n-\tdivvyupExposure();\n+\tdivideUpExposure();\n \t// Finally advertise what we've done.\n \twriteAndFinish(image_metadata, desaturate);\n }\n@@ -545,7 +545,7 @@ void Agc::filterExposure(bool desaturate)\n \t\t\t << \" no dg \" << filtered_.total_exposure_no_dg;\n }\n \n-void Agc::divvyupExposure()\n+void Agc::divideUpExposure()\n {\n \t// Sending the fixed shutter/gain cases through the same code may seem\n \t// unnecessary, but it will make more sense when extend this to cover\ndiff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp\nindex 5a02df4e..2442fc03 100644\n--- a/src/ipa/raspberrypi/controller/rpi/agc.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp\n@@ -89,7 +89,7 @@ private:\n \tbool applyDigitalGain(Metadata *image_metadata, double gain,\n \t\t\t double target_Y);\n \tvoid filterExposure(bool desaturate);\n-\tvoid divvyupExposure();\n+\tvoid divideUpExposure();\n \tvoid writeAndFinish(Metadata *image_metadata, bool desaturate);\n \tAgcMeteringMode *metering_mode_;\n \tAgcExposureMode *exposure_mode_;\n", "prefixes": [ "libcamera-devel", "03/10" ] }