From patchwork Mon Nov 16 16:49:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Plowman X-Patchwork-Id: 10432 Return-Path: X-Original-To: parsemail@patchwork.libcamera.org Delivered-To: parsemail@patchwork.libcamera.org Received: from lancelot.ideasonboard.com (lancelot.ideasonboard.com [92.243.16.209]) by patchwork.libcamera.org (Postfix) with ESMTPS id CEE34BE082 for ; Mon, 16 Nov 2020 16:49:29 +0000 (UTC) Received: from lancelot.ideasonboard.com (localhost [IPv6:::1]) by lancelot.ideasonboard.com (Postfix) with ESMTP id 8B5C9632D5; Mon, 16 Nov 2020 17:49:29 +0100 (CET) Authentication-Results: lancelot.ideasonboard.com; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="GNN1Gkod"; dkim-atps=neutral Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by lancelot.ideasonboard.com (Postfix) with ESMTPS id A72B9632C8 for ; Mon, 16 Nov 2020 17:49:27 +0100 (CET) Received: by mail-wm1-x32b.google.com with SMTP id c9so24343733wml.5 for ; Mon, 16 Nov 2020 08:49:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xqNctcBDmlL2x/krLkjaVmnpGJIy8M2P+aQ68PdFEbc=; b=GNN1GkodywIzjUO31ylKH+L9oKeuTQ3B2Nuk4PQLjNbYegE93B+GQuGoWhEd9w4+1L lvsI+S0g+3WJUoyXgpoLTfnwTZZTbnUeSgvFklk96IlXd5JmSkuGNP4I96anbwPE4y+e GcFoE5ftb9yv5tKTeHp693PtMogAM1GQZ8aA0NlVygu0/NWgBKB7zfaHXGDj4TAbCEiY jw2vvbGfO8STfL2LYheAMqpZcJTG3YkIvvXW29DcvZFnlAqUSNw2UEr6svuMrCcBG9D8 pXUQje/92FurOe5Z8PlOcz14U4NUS1qV8XI7mhW3WZVpD6FN2f3oEBNikwsKwXMESEdg EK/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xqNctcBDmlL2x/krLkjaVmnpGJIy8M2P+aQ68PdFEbc=; b=iBQwOAoqTgeI4BkJfMRIQG/lo16ryy3ok/BOi2ZLQv50VVArYEbMwSQnnQX9uhC/3R QR+/CAoqfjlEjTXqi6M5R0H0xknk4vxbAsDt4mInhUygNZuyuFdW4NGk5rnkT5tDdtdQ 1wTThtTrbVREcqrLJeUsZ5+/B03U2NDlO1/0hUWZw+5jfsp4UTRnzeqQk2haLx7Rddy0 AXm9IOnXThV4oDA2NbuAasoUcydvt673f6hgaoRSX0F0Det0Jb6c59Vi8CJhaxE2+UBF dFZeoEFa/r2WQHK6Gz+h4ugEsWs8l4i1mI4FB51IrCcwyXV3Wledwf+LNtaQPY74q9U0 uxdQ== X-Gm-Message-State: AOAM53382qP+SG2bEwQrLKi2a2Xi8GlRTZy8kq9zoUdEmLA0JQ5sgXvq N9o3cF8OFUdAJLWQTQCqzVZSAMGHq30/MA== X-Google-Smtp-Source: ABdhPJyGBt+eIZh1+23sLrpAA+yi2KhKL1E0+q1wAjVpLx9OsMtjjqcqPYgHOofu2DEi33BZe/db8g== X-Received: by 2002:a1c:99d3:: with SMTP id b202mr16116727wme.0.1605545367120; Mon, 16 Nov 2020 08:49:27 -0800 (PST) Received: from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72]) by smtp.gmail.com with ESMTPSA id q16sm23716973wrn.13.2020.11.16.08.49.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Nov 2020 08:49:26 -0800 (PST) From: David Plowman To: libcamera-devel@lists.libcamera.org Date: Mon, 16 Nov 2020 16:49:11 +0000 Message-Id: <20201116164918.2055-4-david.plowman@raspberrypi.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201116164918.2055-1-david.plowman@raspberrypi.com> References: <20201116164918.2055-1-david.plowman@raspberrypi.com> MIME-Version: 1.0 Subject: [libcamera-devel] [PATCH 03/10] libcamera: ipa: raspberrypi: agc: Rename method to divideUpExposure X-BeenThere: libcamera-devel@lists.libcamera.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: libcamera-devel-bounces@lists.libcamera.org Sender: "libcamera-devel" The method formerly known as divvyupExposure is given a more understandable name. Signed-off-by: David Plowman Reviewed-by: Naushir Patuck --- src/ipa/raspberrypi/controller/rpi/agc.cpp | 8 ++++---- src/ipa/raspberrypi/controller/rpi/agc.hpp | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/ipa/raspberrypi/controller/rpi/agc.cpp b/src/ipa/raspberrypi/controller/rpi/agc.cpp index c4379b99..d29b1156 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.cpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.cpp @@ -225,7 +225,7 @@ void Agc::SwitchMode([[maybe_unused]] CameraMode const &camera_mode, // write the results into the metadata we've been given. if (status_.total_exposure_value) { housekeepConfig(); - divvyupExposure(); + divideUpExposure(); writeAndFinish(metadata, false); } } @@ -304,9 +304,9 @@ void Agc::Process(StatisticsPtr &stats, Metadata *image_metadata) bool desaturate = applyDigitalGain(image_metadata, gain, target_Y); // The results have to be filtered so as not to change too rapidly. filterExposure(desaturate); - // The last thing is to divvy up the exposure value into a shutter time + // The last thing is to divide up the exposure value into a shutter time // and analogue_gain, according to the current exposure mode. - divvyupExposure(); + divideUpExposure(); // Finally advertise what we've done. writeAndFinish(image_metadata, desaturate); } @@ -545,7 +545,7 @@ void Agc::filterExposure(bool desaturate) << " no dg " << filtered_.total_exposure_no_dg; } -void Agc::divvyupExposure() +void Agc::divideUpExposure() { // Sending the fixed shutter/gain cases through the same code may seem // unnecessary, but it will make more sense when extend this to cover diff --git a/src/ipa/raspberrypi/controller/rpi/agc.hpp b/src/ipa/raspberrypi/controller/rpi/agc.hpp index 5a02df4e..2442fc03 100644 --- a/src/ipa/raspberrypi/controller/rpi/agc.hpp +++ b/src/ipa/raspberrypi/controller/rpi/agc.hpp @@ -89,7 +89,7 @@ private: bool applyDigitalGain(Metadata *image_metadata, double gain, double target_Y); void filterExposure(bool desaturate); - void divvyupExposure(); + void divideUpExposure(); void writeAndFinish(Metadata *image_metadata, bool desaturate); AgcMeteringMode *metering_mode_; AgcExposureMode *exposure_mode_;