Cover Letter Detail
Show a cover letter.
GET /api/1.1/covers/20648/?format=api
{ "id": 20648, "url": "https://patchwork.libcamera.org/api/1.1/covers/20648/?format=api", "web_url": "https://patchwork.libcamera.org/cover/20648/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/1.1/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20240712052920.33396-1-umang.jain@ideasonboard.com>", "date": "2024-07-12T05:29:14", "name": "[RFC,0/6] converter_dw100: Add vertex map support", "submitter": { "id": 86, "url": "https://patchwork.libcamera.org/api/1.1/people/86/?format=api", "name": "Umang Jain", "email": "umang.jain@ideasonboard.com" }, "mbox": "https://patchwork.libcamera.org/cover/20648/mbox/", "series": [ { "id": 4451, "url": "https://patchwork.libcamera.org/api/1.1/series/4451/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=4451", "date": "2024-07-12T05:29:14", "name": "converter_dw100: Add vertex map support", "version": 1, "mbox": "https://patchwork.libcamera.org/series/4451/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/covers/20648/comments/", "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BE74DBDB1C\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 12 Jul 2024 05:29:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 285FF63370;\n\tFri, 12 Jul 2024 07:29:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6D203619A9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 12 Jul 2024 07:29:32 +0200 (CEST)", "from localhost.localdomain (unknown\n\t[IPv6:2405:201:2015:f873:55f8:639e:8e9f:12ec])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 12C04CC8;\n\tFri, 12 Jul 2024 07:28:56 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ilIAoTA5\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1720762138;\n\tbh=BHNG8LgGdh0bb9lm+OQF+sYvcrjEpw2bB1veDsgIuqE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ilIAoTA5zuJtHsRbe2fy5FyoMVeK2ZvhIGNjiyLSyVk+lRi1jyVW0nPKh1Vd5beD9\n\t3C1c/FhwseZiZFTKz5XnTdh8AmGBWeUFC04ewY6SlvtiEzzOfNvOh1VmkWg6NWATm6\n\t+ALC/nYfNw1JKMrFnkGgkX34ELHsgE/c1ENw5lwc=", "From": "Umang Jain <umang.jain@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Xavier Roumegue <xavier.roumegue@oss.nxp.com>,\n\tUmang Jain <umang.jain@ideasonboard.com>", "Subject": "[RFC PATCH 0/6] converter_dw100: Add vertex map support", "Date": "Fri, 12 Jul 2024 10:59:14 +0530", "Message-ID": "<20240712052920.33396-1-umang.jain@ideasonboard.com>", "X-Mailer": "git-send-email 2.45.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add vertex map support in converter_dw100. It has been successfully\ntested via plumbing rkisp1 pipeline handler on i.MX8MP with identity\ndewarp maps.\n\nPlease look at each patch for details. This is an RFC/plumbing for\nsetting of vertex map V4L2_CID_DW100_DEWARPING_16x16_VERTEX_MAP on\nDW100 converter.\n\nBased on [1].\n\nDocumentation has been deliberately skipped here. It will be done\nlater when the interface is finalised. I feel we need more\nimplementations/integration of dewarpers, before working on an actual\ndewarper Converter interface. It has been highlighted at previous\nattempts as well [2]:\n\n```\nAs we have a single converter that can perform dewarping, I'd prefer\nmoving the Mapping support from V4L2M2MConverter to this class. It's\nhard to predict what other dewarpers will need, and designing an API\nbased on a single example usually doesn't produce the best design. We\ncan always refactor the code later when we'll get a second device.\n```\n\nI agree with above and I have felt the same while ressurcting DW100\nwork, hence currently tried to contain it within converter_v4l2_m2m\nand converter_dw100 (without touching the Converter interface).\nWill wait on more feedback and see what direction it will take.\n\n[1]: https://patchwork.libcamera.org/project/libcamera/list/?series=4450\n[2]: https://patchwork.libcamera.org/patch/17351/#25248\n\nUmang Jain (4):\n libcamera: v4l2_device: Add support for V4L2_CTRL_TYPE_U32\n libcamera: converter_v4l2_m2m: Add vertex mapping class\n libcamera: converter_v4l2_m2m: Add helper to apply controls\n libcamera: converter_dw100: Load and apply dewarp vertex maps\n\nXavier Roumegue (2):\n include: linux: Update headers for Dw100 dewarper engine\n libcamera: yaml_parser: Increase sentinel to 100k\n\n include/libcamera/controls.h | 5 +\n .../internal/converter/converter_dw100.h | 5 +\n .../internal/converter/converter_v4l2_m2m.h | 25 ++++\n include/linux/dw100.h | 14 ++\n src/libcamera/converter/converter_dw100.cpp | 127 ++++++++++++++++++\n .../converter/converter_v4l2_m2m.cpp | 18 +++\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 4 +\n src/libcamera/v4l2_device.cpp | 11 ++\n src/libcamera/yaml_parser.cpp | 9 +-\n 9 files changed, 215 insertions(+), 3 deletions(-)\n create mode 100644 include/linux/dw100.h" }