| Message ID | 20201002143154.468162-39-paul.elder@ideasonboard.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series |
|
| Related | show |
Hi Paul, Thank you for the patch. On Fri, Oct 02, 2020 at 11:31:54PM +0900, Paul Elder wrote: > Specify in the readme that we depend on python3-ply for generating the > IPA interface. > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > --- > New in v3 > --- > README.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/README.rst b/README.rst > index 74babaf7..a4279a4b 100644 > --- a/README.rst > +++ b/README.rst > @@ -60,6 +60,9 @@ Meson Build system: [required] > for the libcamera core: [required] > python3-yaml > > +for generating IPA interfaces: [required] > + python3-ply > + Do we need a separate section, can't we add that in the previous section with python3-yaml ? We should also add ply to py_modules, in utils/ipc/meson.build. See utils/meson.build for an example. I would do so in this patch, and move it right after the one that adds the mojo parser (I'd normally ask for py_modules to be updated in the patch that creates the dependency, but it's best to import mojo as-is). With this addressed, Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > for IPA module signing: [required] > libgnutls28-dev openssl >
On Sun, Oct 04, 2020 at 11:58:23AM +0300, Laurent Pinchart wrote: > Hi Paul, > > Thank you for the patch. > > On Fri, Oct 02, 2020 at 11:31:54PM +0900, Paul Elder wrote: > > Specify in the readme that we depend on python3-ply for generating the > > IPA interface. > > > > Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> > > > > --- > > New in v3 > > --- > > README.rst | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/README.rst b/README.rst > > index 74babaf7..a4279a4b 100644 > > --- a/README.rst > > +++ b/README.rst > > @@ -60,6 +60,9 @@ Meson Build system: [required] > > for the libcamera core: [required] > > python3-yaml > > > > +for generating IPA interfaces: [required] > > + python3-ply > > + > > Do we need a separate section, can't we add that in the previous section > with python3-yaml ? > > We should also add ply to py_modules, in utils/ipc/meson.build. See > utils/meson.build for an example. I would do so in this patch, and move > it right after the one that adds the mojo parser (I'd normally ask for > py_modules to be updated in the patch that creates the dependency, but > it's best to import mojo as-is). And by the way, I think you should also add python3-jinja2. I've checked mojo and there are a few other dependencies, but none that are required by the code we use (they're for unit tests or ancillary scripts such as compile_typescript.py or gen_data_files_list.py) > With this addressed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > > for IPA module signing: [required] > > libgnutls28-dev openssl > >
diff --git a/README.rst b/README.rst index 74babaf7..a4279a4b 100644 --- a/README.rst +++ b/README.rst @@ -60,6 +60,9 @@ Meson Build system: [required] for the libcamera core: [required] python3-yaml +for generating IPA interfaces: [required] + python3-ply + for IPA module signing: [required] libgnutls28-dev openssl
Specify in the readme that we depend on python3-ply for generating the IPA interface. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> --- New in v3 --- README.rst | 3 +++ 1 file changed, 3 insertions(+)